In perl.git, the branch blead has been updated
<http://perl5.git.perl.org/perl.git/commitdiff/dc21de0ce42c790f35d2d6062e09e01e787138af?hp=b35b96b6f8e35207d18b15dfcdbd0d08a7c6437c>
- Log -----------------------------------------------------------------
commit dc21de0ce42c790f35d2d6062e09e01e787138af
Author: Tony Cook <t...@develop-help.com>
Date: Wed May 21 10:45:58 2014 +1000
remove comment that no longer applies
M x2p/a2py.c
commit ea427bdd8fee9d8ef22a77ac967f3bd71516faf0
Author: Tony Cook <t...@develop-help.com>
Date: Tue May 20 15:06:33 2014 +1000
bump $XS::APItest::VERSION to 0.61
M ext/XS-APItest/APItest.pm
commit de092133b63ee6f61ed274e5c366adf60622300e
Author: Jarkko Hietaniemi <j...@iki.fi>
Date: Fri Apr 25 21:52:54 2014 -0400
Pointers set but then (immediately or very shortly) overwritten.
Fix for Coverity perl5 CIDs 29203, 29207, 29211, 29214, 29217, 29218,
29222: Unused pointer value (UNUSED_VALUE) Pointer foo returned by
bar() is overwritten.
M ext/XS-APItest/APItest.xs
M perlio.c
M toke.c
M x2p/a2py.c
M x2p/walk.c
-----------------------------------------------------------------------
Summary of changes:
ext/XS-APItest/APItest.pm | 2 +-
ext/XS-APItest/APItest.xs | 4 ++--
perlio.c | 6 +++---
toke.c | 1 -
x2p/a2py.c | 1 -
x2p/walk.c | 3 +--
6 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/ext/XS-APItest/APItest.pm b/ext/XS-APItest/APItest.pm
index 8c72b35..e17e263 100644
--- a/ext/XS-APItest/APItest.pm
+++ b/ext/XS-APItest/APItest.pm
@@ -5,7 +5,7 @@ use strict;
use warnings;
use Carp;
-our $VERSION = '0.60';
+our $VERSION = '0.61';
require XSLoader;
diff --git a/ext/XS-APItest/APItest.xs b/ext/XS-APItest/APItest.xs
index a51924d..f741664 100644
--- a/ext/XS-APItest/APItest.xs
+++ b/ext/XS-APItest/APItest.xs
@@ -1457,10 +1457,10 @@ common(params)
if ((svp = hv_fetchs(params, "hash", 0)))
hash = SvUV(*svp);
- if ((svp = hv_fetchs(params, "hash_pv", 0))) {
+ if (hv_fetchs(params, "hash_pv", 0)) {
PERL_HASH(hash, key, klen);
}
- if ((svp = hv_fetchs(params, "hash_sv", 0))) {
+ if (hv_fetchs(params, "hash_sv", 0)) {
STRLEN len;
const char *const p = SvPV(keysv, len);
PERL_HASH(hash, p, len);
diff --git a/perlio.c b/perlio.c
index aa9a932..03c6513 100644
--- a/perlio.c
+++ b/perlio.c
@@ -2948,7 +2948,7 @@ PerlIO_importFILE(FILE *stdio, const char *mode)
}
fclose(f2);
}
- if ((f = PerlIO_push(aTHX_(f = PerlIO_allocate(aTHX)),
PERLIO_FUNCS_CAST(&PerlIO_stdio), mode, NULL))) {
+ if ((f = PerlIO_push(aTHX_(PerlIO_allocate(aTHX)),
PERLIO_FUNCS_CAST(&PerlIO_stdio), mode, NULL))) {
s = PerlIOSelf(f, PerlIOStdio);
s->stdio = stdio;
PerlIOUnix_refcnt_inc(fileno(stdio));
@@ -2971,8 +2971,8 @@ PerlIOStdio_open(pTHX_ PerlIO_funcs *self, PerlIO_list_t
*layers,
if (!IS_SAFE_PATHNAME(path, len, "open"))
return NULL;
PerlIOUnix_refcnt_dec(fileno(s->stdio));
- stdio = PerlSIO_freopen(path, (mode = PerlIOStdio_mode(mode, tmode)),
- s->stdio);
+ stdio = PerlSIO_freopen(path, PerlIOStdio_mode(mode, tmode),
+ s->stdio);
if (!s->stdio)
return NULL;
s->stdio = stdio;
diff --git a/toke.c b/toke.c
index a3e9ad5..3f5336a 100644
--- a/toke.c
+++ b/toke.c
@@ -10399,7 +10399,6 @@ S_scan_inputsymbol(pTHX_ char *start)
Copy("ARGV",d,5,char);
/* Check whether readline() is overriden */
- gv_readline = gv_fetchpvs("readline", GV_NOTQUAL, SVt_PVCV);
if ((gv_readline = gv_override("readline",8)))
readline_overriden = TRUE;
diff --git a/x2p/a2py.c b/x2p/a2py.c
index 8c08202..695c4fd 100644
--- a/x2p/a2py.c
+++ b/x2p/a2py.c
@@ -70,7 +70,6 @@ main(int argc, const char **argv)
myname = argv[0];
linestr = str_new(80);
- str = str_new(0); /* first used for -I flags */
for (argc--,argv++; argc; argc--,argv++) {
if (argv[0][0] != '-' || !argv[0][1])
break;
diff --git a/x2p/walk.c b/x2p/walk.c
index 0197fea..d6962ed 100644
--- a/x2p/walk.c
+++ b/x2p/walk.c
@@ -254,7 +254,6 @@ sub Pick {\n\
break;
case OHUNK:
if (len == 1) {
- str = str_new(0);
str = walk(0,level,oper1(OPRINT,0),&numarg,P_MIN);
str_cat(str," if ");
str_scat(str,fstr=walk(0,level,ops[node+1].ival,&numarg,P_MIN));
@@ -1104,7 +1103,7 @@ sub Pick {\n\
if (!do_fancy_opens) {
t = tmpstr->str_ptr;
if (*t == '"' || *t == '\'')
- t = cpytill(tokenbuf,t+1,*t);
+ cpytill(tokenbuf,t+1,*t);
else
fatal("Internal error: OCLOSE %s",t);
s = savestr(tokenbuf);
--
Perl5 Master Repository
