In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/0c60e3193cada7eee789f68009742a6f1c55c0ac?hp=04e0f0c28a521a290f29301e7b2abe43d65a5339>
- Log ----------------------------------------------------------------- commit 0c60e3193cada7eee789f68009742a6f1c55c0ac Author: James E Keenan <[email protected]> Date: Sat Jun 21 09:04:12 2014 -0400 Revert 6 tests failing on Win32 smoker. ----------------------------------------------------------------------- Summary of changes: ext/IPC-Open3/t/IPC-Open3.t | 54 ++++++++++++++++++++++----------------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/ext/IPC-Open3/t/IPC-Open3.t b/ext/IPC-Open3/t/IPC-Open3.t index 05aeb4a..a07cc48 100644 --- a/ext/IPC-Open3/t/IPC-Open3.t +++ b/ext/IPC-Open3/t/IPC-Open3.t @@ -14,7 +14,7 @@ BEGIN { } use strict; -use Test::More tests => 44; +use Test::More tests => 38; use IO::Handle; use IPC::Open3; @@ -188,29 +188,29 @@ foreach my $handle (qw (DUMMY STDIN STDOUT STDERR)) { waitpid $pid, 0; } -# Test that tied STDIN, STDOUT, and STDERR do not cause open3 any discomfort. -# In particular, tied STDERR used to be able to prevent open3 from working -# correctly. RT #119843. -{ - { # This just throws things out - package My::Tied::FH; - sub TIEHANDLE { bless \my $self } - sub PRINT {} - # Note the absence of OPEN and FILENO - } - my $message = "japh\n"; - foreach my $handle (*STDIN, *STDOUT, *STDERR) { - tie $handle, 'My::Tied::FH'; - my ($in, $out); - my $pid = eval { - open3 $in, $out, undef, $perl, '-ne', 'print'; - }; - is($@, '', "no errors calling open3 with tied $handle"); - print $in $message; - close $in; - my $japh = <$out>; - waitpid $pid, 0; - is($japh, $message, "read input correctly"); - untie $handle; - } -} +## Test that tied STDIN, STDOUT, and STDERR do not cause open3 any discomfort. +## In particular, tied STDERR used to be able to prevent open3 from working +## correctly. RT #119843. +#{ +# { # This just throws things out +# package My::Tied::FH; +# sub TIEHANDLE { bless \my $self } +# sub PRINT {} +# # Note the absence of OPEN and FILENO +# } +# my $message = "japh\n"; +# foreach my $handle (*STDIN, *STDOUT, *STDERR) { +# tie $handle, 'My::Tied::FH'; +# my ($in, $out); +# my $pid = eval { +# open3 $in, $out, undef, $perl, '-ne', 'print'; +# }; +# is($@, '', "no errors calling open3 with tied $handle"); +# print $in $message; +# close $in; +# my $japh = <$out>; +# waitpid $pid, 0; +# is($japh, $message, "read input correctly"); +# untie $handle; +# } +#} -- Perl5 Master Repository
