In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/1bac45e496301fc6a45ed8ea23862a5bb8faa8a0?hp=623141a15393d2fb245027a0425b976f2853da3a>
- Log ----------------------------------------------------------------- commit 1bac45e496301fc6a45ed8ea23862a5bb8faa8a0 Author: Father Chrysostomos <[email protected]> Date: Thu Sep 18 23:14:04 2014 -0700 Teach diag.t about Perl_mess Every instance of Perl_mess(aTHX_ "..." ...) is used for an error message. M t/porting/diag.t commit 10860bf4ce0e7f176595419cce2e3e8ddd7bc761 Author: Father Chrysostomos <[email protected]> Date: Thu Sep 18 23:02:52 2014 -0700 gv.c: For âGlobal symbolâ msg, donât check utf8ness twice We already take care of possible utf8ness in the format string. There is no need to turn on the flag afterwards. This double utf8 check has been present since ecad31f018. M gv.c ----------------------------------------------------------------------- Summary of changes: gv.c | 9 +++------ t/porting/diag.t | 2 ++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/gv.c b/gv.c index 4930c03..73fb7da 100644 --- a/gv.c +++ b/gv.c @@ -1731,7 +1731,8 @@ S_find_default_stash(pTHX_ HV **stash, const char *name, STRLEN len, if (!*stash) { if (add && !PL_in_clean_all) { - SV * const err = Perl_mess(aTHX_ + GV *gv; + qerror(Perl_mess(aTHX_ "Global symbol \"%s%"UTF8f "\" requires explicit package name (did you forget to " "declare \"my %s%"UTF8f"\"?)", @@ -1742,11 +1743,7 @@ S_find_default_stash(pTHX_ HV **stash, const char *name, STRLEN len, (sv_type == SVt_PV ? "$" : sv_type == SVt_PVAV ? "@" : sv_type == SVt_PVHV ? "%" - : ""), UTF8fARG(is_utf8, len, name)); - GV *gv; - if (is_utf8) - SvUTF8_on(err); - qerror(err); + : ""), UTF8fARG(is_utf8, len, name))); /* To maintain the output of errors after the strict exception * above, and to keep compat with older releases, rather than * placing the variables in the pad, we place diff --git a/t/porting/diag.t b/t/porting/diag.t index d3e0021..e94922b 100644 --- a/t/porting/diag.t +++ b/t/porting/diag.t @@ -39,6 +39,7 @@ foreach (@{(setup_embed())[0]}) { push @functions, 'Perl_' . $_->[2] if $_->[0] =~ /p/; push @functions, 'S_' . $_->[2] if $_->[0] =~ /s/; }; +push @functions, 'Perl_mess'; my $regcomp_fail_re = '\b(?:(?:Simple_)?v)?FAIL[2-4]?(?:utf8f)?\b'; my $regcomp_re = @@ -597,6 +598,7 @@ Not array reference given to mod2fname Operator or semicolon missing before %c%s Out of memory during list extend panic queryaddr +Parse error PerlApp::TextQuery: no arguments, please POSIX syntax [%c %c] is reserved for future extensions in regex; marked by <-- HERE in m/%s/ ptr wrong %p != %p fl=%x nl=%p e=%p for %d -- Perl5 Master Repository
