In perl.git, the branch yves/fix_128085 has been created
<http://perl5.git.perl.org/perl.git/commitdiff/fe6616011149cadb667b778d117acab06fc8ccec?hp=0000000000000000000000000000000000000000>
at fe6616011149cadb667b778d117acab06fc8ccec (commit)
- Log -----------------------------------------------------------------
commit fe6616011149cadb667b778d117acab06fc8ccec
Author: Yves Orton <[email protected]>
Date: Tue May 10 09:44:31 2016 +0200
fix #128109 - do not move RExC_open_parens[0] in reginsert
In d5a00e4af6b155495be31a35728b8fef8e671ebe I merged GOSUB and GOSTART,
part of which involved making RExC_open_parens[0] refer to the start of
the pattern, and RExC_close_parens[0] referring to the end of the pattern.
This tripped up in reginsert in a subtle way, the start of the pattern
cannot and should not move in reginsert(). Unlike a paren that might
be at the start of the pattern which should move when something is inserted
in front of it, the start is a fixed point and should never move.
This patches fixes this up, and adds an assert to check that reginsert()
is not called once study_chunk() starts, as reginsert() does not adjust
RExC_recurse.
This was noticed by hv while debugging [perl #128085], thanks hugo!
M regcomp.c
commit 501c4e1a5cf3d562f05029d731280b566202df8a
Author: Yves Orton <[email protected]>
Date: Mon May 9 08:52:16 2016 +0200
fix #128085 - SIGSEGV in S_regmatch with S_study_chunk: Assertion "!frame"
failed.
The goto target should have been before the if (frame) block.
Clearly this code is not well tested in our test suite. This patch
does NOT include tests.
M regcomp.c
-----------------------------------------------------------------------
--
Perl5 Master Repository
