In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/2e66fe905dd7ad04f1d82df888fa62650d3d2165?hp=e897f2d79346a5c1b43d0948c1c0720cbb220cfa>
- Log ----------------------------------------------------------------- commit 2e66fe905dd7ad04f1d82df888fa62650d3d2165 Author: Father Chrysostomos <spr...@cpan.org> Date: Sun Aug 14 19:00:16 2016 -0700 Revert "#define PERL_NO_GET_CONTEXT in XS::APItest" This reverts commit 6b6b24f11907f607277fd8cf6f08264c234cc693. In <20160814191141.32442.qm...@lists-nntp.develooper.com> Daniel Dragan writes: > If there is 1 module that shouldn't use PERL_NO_GET_CONTEXT XS::APItest > is the one. *Ideally* in perl core, there is nothing else to test that > Get-context-everywhere mode works since no production core module would > be that bitrotten to not use PERL_NO_GET_CONTEXT. I thought about adding > PERL_NO_GET_CONTEXT XS::APItest 2 years ago and decided against it to > make sure there is a test in core that get-context-everywhere > back-compat mode works. ----------------------------------------------------------------------- Summary of changes: ext/XS-APItest/APItest.xs | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/ext/XS-APItest/APItest.xs b/ext/XS-APItest/APItest.xs index 3d8db26..7a027ee 100644 --- a/ext/XS-APItest/APItest.xs +++ b/ext/XS-APItest/APItest.xs @@ -3,7 +3,6 @@ /* We want to be able to test things that aren't API yet. */ #define PERL_EXT -#define PERL_NO_GET_CONTEXT /* we wants efficiency */ #include "EXTERN.h" #include "perl.h" #include "XSUB.h" @@ -118,7 +117,6 @@ my_cxt_getsv_interp_context(void) SV* my_cxt_getsv_interp(void) { - dTHX; dMY_CXT; return MY_CXT.sv; } @@ -143,7 +141,7 @@ bool sv_setsv_cow_hashkey_notcore(void); typedef void (freeent_function)(pTHX_ HV *, HE *); void -test_freeent(pTHX_ freeent_function *f) { +test_freeent(freeent_function *f) { dSP; HV *test_hash = newHV(); HE *victim; @@ -517,9 +515,9 @@ THX_ck_entersub_multi_sum(pTHX_ OP *entersubop, GV *namegv, SV *ckobj) return sumop; } -STATIC void test_op_list_describe_part(pTHX_ SV *res, OP *o); +STATIC void test_op_list_describe_part(SV *res, OP *o); STATIC void -test_op_list_describe_part(pTHX_ SV *res, OP *o) +test_op_list_describe_part(SV *res, OP *o) { sv_catpv(res, PL_op_name[o->op_type]); switch (o->op_type) { @@ -531,7 +529,7 @@ test_op_list_describe_part(pTHX_ SV *res, OP *o) OP *k; sv_catpvs(res, "["); for (k = cUNOPx(o)->op_first; k; k = OpSIBLING(k)) - test_op_list_describe_part(aTHX_ res, k); + test_op_list_describe_part(res, k); sv_catpvs(res, "]"); } else { sv_catpvs(res, "."); @@ -539,11 +537,11 @@ test_op_list_describe_part(pTHX_ SV *res, OP *o) } STATIC char * -test_op_list_describe(pTHX_ OP *o) +test_op_list_describe(OP *o) { SV *res = sv_2mortal(newSVpvs("")); if (o) - test_op_list_describe_part(aTHX_ res, o); + test_op_list_describe_part(res, o); return SvPVX(res); } @@ -587,7 +585,7 @@ THX_mkLISTOP(pTHX_ U32 type, OP *first, OP *sib, OP *last) } static char * -test_op_linklist_describe(pTHX_ OP *start) +test_op_linklist_describe(OP *start) { SV *rv = sv_2mortal(newSVpvs("")); OP *o; @@ -1795,13 +1793,13 @@ common(params) void test_hv_free_ent() PPCODE: - test_freeent(aTHX_ &Perl_hv_free_ent); + test_freeent(&Perl_hv_free_ent); XSRETURN(4); void test_hv_delayfree_ent() PPCODE: - test_freeent(aTHX_ &Perl_hv_delayfree_ent); + test_freeent(&Perl_hv_delayfree_ent); XSRETURN(4); SV * @@ -3428,8 +3426,8 @@ test_op_list() #define iv_op(iv) newSVOP(OP_CONST, 0, newSViv(iv)) #define check_op(o, expect) \ do { \ - if (strcmp(test_op_list_describe(aTHX_ o), (expect))) \ - croak("fail %s %s", test_op_list_describe(aTHX_ o),(expect)); \ + if (strcmp(test_op_list_describe(o), (expect))) \ + croak("fail %s %s", test_op_list_describe(o), (expect)); \ } while(0) a = op_append_elem(OP_LIST, NULL, NULL); check_op(a, ""); @@ -3543,9 +3541,8 @@ test_op_linklist () CODE: #define check_ll(o, expect) \ STMT_START { \ - if (strNE(test_op_linklist_describe(aTHX_ o), (expect))) \ - croak("fail %s %s", test_op_linklist_describe(aTHX_ o), \ - (expect)); \ + if (strNE(test_op_linklist_describe(o), (expect))) \ + croak("fail %s %s", test_op_linklist_describe(o), (expect)); \ } STMT_END o = iv_op(1); check_ll(o, ".const1"); -- Perl5 Master Repository