On 6 October 2017 at 08:50, Steve Hay <steve.m....@googlemail.com> wrote: > On 5 October 2017 at 21:33, Chris 'Bingos' Williams > <ch...@bingosnet.co.uk> wrote: >> In perl.git, the branch blead has been updated >> >> <http://perl5.git.perl.org/perl.git/commitdiff/1195d90a5747942a65c309d1691cb3e85790e09e?hp=93309f6b79580ff87f973d8f99f1b23d197749d7> >> >> - Log ----------------------------------------------------------------- >> commit 1195d90a5747942a65c309d1691cb3e85790e09e >> Author: Chris 'BinGOs' Williams <ch...@bingosnet.co.uk> >> Date: Thu Oct 5 13:35:08 2017 +0100 >> >> Update Test-Simple to CPAN version 1.302098 >> > >> diff --git a/Porting/cmpVERSION.pl b/Porting/cmpVERSION.pl >> index e7ae68d6f8..31b7a6ecf0 100755 >> --- a/Porting/cmpVERSION.pl >> +++ b/Porting/cmpVERSION.pl >> @@ -81,6 +81,7 @@ if ($exclude_upstream) { >> # usually because they pull in their version from some other file. >> my %skip; >> @skip{ >> + 'cpan/Test-Simple/lib/Test/Builder/IO/Scalar.pm', # >> 'cpan/ExtUtils-Install/t/lib/MakeMaker/Test/Setup/BFD.pm', # just a >> test module >> 'cpan/ExtUtils-MakeMaker/t/lib/MakeMaker/Test/Setup/BFD.pm', # just a >> test module >> 'cpan/ExtUtils-MakeMaker/t/lib/MakeMaker/Test/Setup/XS.pm', # just a >> test module > > This was not the correct fix here. Test/Builder/IO/Scalar.pm isn't > just a test module so it shouldn't be skipped in cmpVERSION.pl. > > I already tried an upgrade to this version of Test-Simple and backed > out because that module had been changed without a $VERSION bump. I > reported the problem and was awaiting a new version. > > (I'm not suggesting reverting the upgrade; just noting that the > cmpVERSION.pl change should be reverted when Test-SImple is next > updated.)
The cmpVERSION.pl change is now reverted with the latest Test-Simple upgrade.
