In perl.git, the branch blead has been updated
<https://perl5.git.perl.org/perl.git/commitdiff/2f4ab1b0f783f1c7c78326e61db1a58719973c4f?hp=19a8de486236b6004a51aa6c16eb9fcde47d86d1>
- Log -----------------------------------------------------------------
commit 2f4ab1b0f783f1c7c78326e61db1a58719973c4f
Author: Craig A. Berry <craigbe...@mac.com>
Date: Thu Nov 16 09:08:33 2017 -0600
Use safer symlink name in stat.t.
The file pattern TEST.symlink.$$ is an ambiguous filename on VMS
because the digits of the $$ could be construed as a version
number or as part of the filename proper, depending on various
environmental settings. This would not cause stat.t to fail but
could prevent removal of the symlink. Which would then cause
ext/File-Glob/t/basic.t to fail because it scans the t/ directory
for files match TES* and falls down when it finds files it does
not expect.
In principle this could cause trouble for parallel tests on any
platform if stat.t's detritus happens to be present while the
File::Glob tests are running.
Short of a major rethink of the test suite to stop tests from using
t/ as their personal playground, the safest bet seems to be to use
a filename that is unambiguous on VMS and will not collide with
tests expecting t/TEST to be the only file in that directory that
begins with 'TES'.
-----------------------------------------------------------------------
Summary of changes:
t/op/stat.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/op/stat.t b/t/op/stat.t
index f93f21deb6..2c93ac02ad 100644
--- a/t/op/stat.t
+++ b/t/op/stat.t
@@ -629,7 +629,7 @@ SKIP:
# [perl #131895] stat() doesn't fail on filenames containing \0 / NUL
ok !stat("TEST\0-"), 'stat on filename with \0';
SKIP: {
- my $link = "TEST.symlink.$$";
+ my $link = "stat_t_$$_TEST.symlink";
my $can_symlink = eval { symlink "TEST", $link };
skip "cannot symlink", 1 unless $can_symlink;
ok !lstat("$link\0-"), 'lstat on filename with \0';
--
Perl5 Master Repository
