In perl.git, the branch blead has been updated
<https://perl5.git.perl.org/perl.git/commitdiff/678ae29284d351e19c3401c94ccf83538266b096?hp=1a40b6f708f420ef8d46f93bd4f2c29113f28a55>
- Log -----------------------------------------------------------------
commit 678ae29284d351e19c3401c94ccf83538266b096
Author: David Mitchell <da...@iabyn.com>
Date: Fri Feb 22 10:59:23 2019 +0000
Perl_op_sibling_splice(0 remove dead code
Spotted by Coverity.
We've already checkerd earlier on that at least one of parent and start
is non-null, so the line in question can never be reached. Turn it into
an assertion instead.
-----------------------------------------------------------------------
Summary of changes:
op.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/op.c b/op.c
index 8e7123dff5..6ca89486e3 100644
--- a/op.c
+++ b/op.c
@@ -1442,8 +1442,7 @@ Perl_op_sibling_splice(OP *parent, OP *start, int
del_count, OP* insert)
OpMAYBESIB_set(start, insert, NULL);
}
else {
- if (!parent)
- goto no_parent;
+ assert(parent);
cLISTOPx(parent)->op_first = insert;
if (insert)
parent->op_flags |= OPf_KIDS;
--
Perl5 Master Repository
