Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: ed19e85f760008907bee490c6a8a2df153ede2a5
https://github.com/Perl/perl5/commit/ed19e85f760008907bee490c6a8a2df153ede2a5
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: e30074f08b1489cd66a972def093f47c2cbde2b0
https://github.com/Perl/perl5/commit/e30074f08b1489cd66a972def093f47c2cbde2b0
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 5b26b288c9246d863effd59c85a746f57244f773
https://github.com/Perl/perl5/commit/5b26b288c9246d863effd59c85a746f57244f773
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: f34cf003c15ae93c364a6701935f19ee3b65c569
https://github.com/Perl/perl5/commit/f34cf003c15ae93c364a6701935f19ee3b65c569
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: ac5814238a5c4662fbb1b8e6b04f033673fb51ac
https://github.com/Perl/perl5/commit/ac5814238a5c4662fbb1b8e6b04f033673fb51ac
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 5e9d0fa0891cad331cf72b6f96e286ed314c11a1
https://github.com/Perl/perl5/commit/5e9d0fa0891cad331cf72b6f96e286ed314c11a1
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: f535fa43796b0ed11a18c24ae659e23fc5593d60
https://github.com/Perl/perl5/commit/f535fa43796b0ed11a18c24ae659e23fc5593d60
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: c7a69b0314fc784b56b9161cd8ed08c38bdbdf22
https://github.com/Perl/perl5/commit/c7a69b0314fc784b56b9161cd8ed08c38bdbdf22
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 5ea0cbe82d2044c718f5010f05c476588cc4814d
https://github.com/Perl/perl5/commit/5ea0cbe82d2044c718f5010f05c476588cc4814d
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 0d30aff7cb5310216096f865fabc373c9fbb3499
https://github.com/Perl/perl5/commit/0d30aff7cb5310216096f865fabc373c9fbb3499
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: cdc66a7a395b80989ee9bf76b96bb0c66bbae506
https://github.com/Perl/perl5/commit/cdc66a7a395b80989ee9bf76b96bb0c66bbae506
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: b3986cfad1c1c5931aa10c4d60b9e2f3443e06a0
https://github.com/Perl/perl5/commit/b3986cfad1c1c5931aa10c4d60b9e2f3443e06a0
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: e8ea888dd03384a16d0e01f72b2ebd1eba57960e
https://github.com/Perl/perl5/commit/e8ea888dd03384a16d0e01f72b2ebd1eba57960e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 3268715dcc5177edcb7cc03458566728b2f96b2c
https://github.com/Perl/perl5/commit/3268715dcc5177edcb7cc03458566728b2f96b2c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 256a74ba596d6aaa7fdbebce494cd94fc2157d7f
https://github.com/Perl/perl5/commit/256a74ba596d6aaa7fdbebce494cd94fc2157d7f
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 62c985c6eba74668676a45c50a433bdcc0c3d9c3
https://github.com/Perl/perl5/commit/62c985c6eba74668676a45c50a433bdcc0c3d9c3
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 58b02b23bf33c77f691b58ba9efdcd508fdddb86
https://github.com/Perl/perl5/commit/58b02b23bf33c77f691b58ba9efdcd508fdddb86
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 40f1f350e66f82d56975c5109f0600f70bfeddab
https://github.com/Perl/perl5/commit/40f1f350e66f82d56975c5109f0600f70bfeddab
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 2ced5f710b6c79c228debf04e7df2e39d58ae0ac
https://github.com/Perl/perl5/commit/2ced5f710b6c79c228debf04e7df2e39d58ae0ac
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: c469e3fea59b8e45a6b822c1caa78b414fff8680
https://github.com/Perl/perl5/commit/c469e3fea59b8e45a6b822c1caa78b414fff8680
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: e5fb98328439eeabeccdd44523b110cd0f8db386
https://github.com/Perl/perl5/commit/e5fb98328439eeabeccdd44523b110cd0f8db386
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 62be0f324d14e2621b558fc4400c0a9136c3384e
https://github.com/Perl/perl5/commit/62be0f324d14e2621b558fc4400c0a9136c3384e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 3d5743521d3fd47ca7d760ac27714c718e4c33fe
https://github.com/Perl/perl5/commit/3d5743521d3fd47ca7d760ac27714c718e4c33fe
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: bf18ac908d4f9a9642429915162bd90271e8f333
https://github.com/Perl/perl5/commit/bf18ac908d4f9a9642429915162bd90271e8f333
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 41f612c9f395365ce172bf25678545fcdea634c7
https://github.com/Perl/perl5/commit/41f612c9f395365ce172bf25678545fcdea634c7
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: da7aadb1264dce5ec67e8f88ce24c4a84535c08c
https://github.com/Perl/perl5/commit/da7aadb1264dce5ec67e8f88ce24c4a84535c08c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: fc424e6ea223888cae3909c07e27158b5b8fcfb8
https://github.com/Perl/perl5/commit/fc424e6ea223888cae3909c07e27158b5b8fcfb8
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 04b7c139fdf4fd40b69a5c7697c5aeec19f2e8b3
https://github.com/Perl/perl5/commit/04b7c139fdf4fd40b69a5c7697c5aeec19f2e8b3
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 4539f2d62b3e270a12aca9411cffe005e095ed61
https://github.com/Perl/perl5/commit/4539f2d62b3e270a12aca9411cffe005e095ed61
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 976c6611659d62763dafd4d809d9ce14c61e9cfc
https://github.com/Perl/perl5/commit/976c6611659d62763dafd4d809d9ce14c61e9cfc
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 441e7e75cb4fe86f8e53e3b94d2e7095107756a9
https://github.com/Perl/perl5/commit/441e7e75cb4fe86f8e53e3b94d2e7095107756a9
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: a6c623ea25312cf494891c5596713707f0501420
https://github.com/Perl/perl5/commit/a6c623ea25312cf494891c5596713707f0501420
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: ccae87790b278ade91a3ed9d5982eb3f24314968
https://github.com/Perl/perl5/commit/ccae87790b278ade91a3ed9d5982eb3f24314968
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 3225e8c0b095b56b20d45516f9a7bc20a5d71769
https://github.com/Perl/perl5/commit/3225e8c0b095b56b20d45516f9a7bc20a5d71769
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: b242ce6df69ee5fdbf09da4e78b3091e3972930e
https://github.com/Perl/perl5/commit/b242ce6df69ee5fdbf09da4e78b3091e3972930e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: f62c55a6a88a8322572f327c7f43b4fad563aba7
https://github.com/Perl/perl5/commit/f62c55a6a88a8322572f327c7f43b4fad563aba7
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: e4ce133fcb026e8404f27bf54fde77c4ddaa6da0
https://github.com/Perl/perl5/commit/e4ce133fcb026e8404f27bf54fde77c4ddaa6da0
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: bc5701012c22cc6957c6bd6100339eb7cb0a2e3d
https://github.com/Perl/perl5/commit/bc5701012c22cc6957c6bd6100339eb7cb0a2e3d
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: c671ddb12bf5e38aab3ed75a161b59cff34cbe2e
https://github.com/Perl/perl5/commit/c671ddb12bf5e38aab3ed75a161b59cff34cbe2e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 76d99262dc4b6f99327c22f1499524d50c3d6248
https://github.com/Perl/perl5/commit/76d99262dc4b6f99327c22f1499524d50c3d6248
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: ca4b58259021b4b1b7cf73b1e8e3f4e1631e8d59
https://github.com/Perl/perl5/commit/ca4b58259021b4b1b7cf73b1e8e3f4e1631e8d59
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: e90895d36f939ea0883bf4b1d5af9dc5684121c3
https://github.com/Perl/perl5/commit/e90895d36f939ea0883bf4b1d5af9dc5684121c3
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: fb781ab58b7572d24d83e4f9c6e40496a7ee6df1
https://github.com/Perl/perl5/commit/fb781ab58b7572d24d83e4f9c6e40496a7ee6df1
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 82e1ce4f718f43440edd12a138a81382b9b59b17
https://github.com/Perl/perl5/commit/82e1ce4f718f43440edd12a138a81382b9b59b17
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 365d5d0912f37c2ddeabbcfe3d7b56c9cb617c20
https://github.com/Perl/perl5/commit/365d5d0912f37c2ddeabbcfe3d7b56c9cb617c20
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: e60665470dd04124d6b331435f60f1b1cffcc1c7
https://github.com/Perl/perl5/commit/e60665470dd04124d6b331435f60f1b1cffcc1c7
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 63dfe406dd219f0a32bdb4f490e05705afdf0e52
https://github.com/Perl/perl5/commit/63dfe406dd219f0a32bdb4f490e05705afdf0e52
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: ad7bcb6ae099a504c82be1ba999e96433db35eb0
https://github.com/Perl/perl5/commit/ad7bcb6ae099a504c82be1ba999e96433db35eb0
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 5dc8dfb923d592c413f83b6aab355e446b46900f
https://github.com/Perl/perl5/commit/5dc8dfb923d592c413f83b6aab355e446b46900f
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 840faef3e007fb8de1a459e75e00654f4facffa7
https://github.com/Perl/perl5/commit/840faef3e007fb8de1a459e75e00654f4facffa7
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 701eb15549d762b1d2e9ed69d2d7c2c55b017158
https://github.com/Perl/perl5/commit/701eb15549d762b1d2e9ed69d2d7c2c55b017158
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 4320275bdda39c6657dc99eef957890e0431338d
https://github.com/Perl/perl5/commit/4320275bdda39c6657dc99eef957890e0431338d
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 578aee4f37378056e40c57382d5d542db7a27f95
https://github.com/Perl/perl5/commit/578aee4f37378056e40c57382d5d542db7a27f95
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: d2cb3c01cd67cab70fa1b410011861e6a237a253
https://github.com/Perl/perl5/commit/d2cb3c01cd67cab70fa1b410011861e6a237a253
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 62cdcb6154b32e8c27729544fb8baa03d1db6eae
https://github.com/Perl/perl5/commit/62cdcb6154b32e8c27729544fb8baa03d1db6eae
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 43644e96a9fafd5420b718cc5072056ea27be3fc
https://github.com/Perl/perl5/commit/43644e96a9fafd5420b718cc5072056ea27be3fc
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 5f021db3b90e69801ea441a0f5a96124c8de9666
https://github.com/Perl/perl5/commit/5f021db3b90e69801ea441a0f5a96124c8de9666
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: c11e3d2e1581cb9df2171babe00f79f71ddc9a26
https://github.com/Perl/perl5/commit/c11e3d2e1581cb9df2171babe00f79f71ddc9a26
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 8d27071794918643719cac676cf659c6eaa86b15
https://github.com/Perl/perl5/commit/8d27071794918643719cac676cf659c6eaa86b15
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: b7d99c197625fe7dc6107a8903b3c037481a57c8
https://github.com/Perl/perl5/commit/b7d99c197625fe7dc6107a8903b3c037481a57c8
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 391fb434a2ca1acf87a04fd5127c44ccfbaeb061
https://github.com/Perl/perl5/commit/391fb434a2ca1acf87a04fd5127c44ccfbaeb061
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: b4c31cd086ad08c533614a8b5bc316b90d40e364
https://github.com/Perl/perl5/commit/b4c31cd086ad08c533614a8b5bc316b90d40e364
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: fab46fcea4397b9b3ea5f87a0316052dc51f4771
https://github.com/Perl/perl5/commit/fab46fcea4397b9b3ea5f87a0316052dc51f4771
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: d9cbc5fca7e2822ff7be6a82bbf8ca9e748d9b62
https://github.com/Perl/perl5/commit/d9cbc5fca7e2822ff7be6a82bbf8ca9e748d9b62
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 600b0e1ffb531d78673e95bda51c2e5b3485c527
https://github.com/Perl/perl5/commit/600b0e1ffb531d78673e95bda51c2e5b3485c527
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 572b9e6fdc792fdabbd14dc2188819c6f77142c5
https://github.com/Perl/perl5/commit/572b9e6fdc792fdabbd14dc2188819c6f77142c5
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 63e36935305a9bf6e12fb56db0d6accb8b591e64
https://github.com/Perl/perl5/commit/63e36935305a9bf6e12fb56db0d6accb8b591e64
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: e86d4985cc323d504218269343a699bd8c241680
https://github.com/Perl/perl5/commit/e86d4985cc323d504218269343a699bd8c241680
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 490326bd4aa997b3698ca7377f47c6cfd6a9d563
https://github.com/Perl/perl5/commit/490326bd4aa997b3698ca7377f47c6cfd6a9d563
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: bc1e079fb929561942f6d8bd249456729e7e4b63
https://github.com/Perl/perl5/commit/bc1e079fb929561942f6d8bd249456729e7e4b63
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: c784ec6db80fcd5ac154bc374384bbd4b24e43b3
https://github.com/Perl/perl5/commit/c784ec6db80fcd5ac154bc374384bbd4b24e43b3
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 0bd19f828d1bd782ddc129157c2266ef4cb26efe
https://github.com/Perl/perl5/commit/0bd19f828d1bd782ddc129157c2266ef4cb26efe
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 888fb2742deae03ad3d00360018930fa6f57a72a
https://github.com/Perl/perl5/commit/888fb2742deae03ad3d00360018930fa6f57a72a
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: fa4dd836ddd48faebdb9acddedce6af41dc31c87
https://github.com/Perl/perl5/commit/fa4dd836ddd48faebdb9acddedce6af41dc31c87
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 0f5550222a596b94833a7a43081912c9d644705b
https://github.com/Perl/perl5/commit/0f5550222a596b94833a7a43081912c9d644705b
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 7ffe9ca40c7d8fa371bdc43d868d27956ea52f1f
https://github.com/Perl/perl5/commit/7ffe9ca40c7d8fa371bdc43d868d27956ea52f1f
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: d7129748075c913d8f6f99ddc558036afe4e7db5
https://github.com/Perl/perl5/commit/d7129748075c913d8f6f99ddc558036afe4e7db5
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 9becd0f7ef65da765867e2c2b0b99420e1a01a8b
https://github.com/Perl/perl5/commit/9becd0f7ef65da765867e2c2b0b99420e1a01a8b
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 372db7ab1ec7f6ecc6f85e05e8647db45cf00f52
https://github.com/Perl/perl5/commit/372db7ab1ec7f6ecc6f85e05e8647db45cf00f52
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 32fa0364addf16d9a9743d072b0d6563d34ffcb7
https://github.com/Perl/perl5/commit/32fa0364addf16d9a9743d072b0d6563d34ffcb7
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 3f9d3721cb1aae8ff36e0d5d07eb7e36ffa58748
https://github.com/Perl/perl5/commit/3f9d3721cb1aae8ff36e0d5d07eb7e36ffa58748
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 9fc6e4188e6059c1e4998ea0879ec5c34ca059e9
https://github.com/Perl/perl5/commit/9fc6e4188e6059c1e4998ea0879ec5c34ca059e9
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 94912fc5f274030d382ee602caad3246936902ce
https://github.com/Perl/perl5/commit/94912fc5f274030d382ee602caad3246936902ce
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 5d788a7106ee5475b3bcc46e68588bef440af0c2
https://github.com/Perl/perl5/commit/5d788a7106ee5475b3bcc46e68588bef440af0c2
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 4391bbf3146c3ec1de3d7b7cf6a20faf5dc73739
https://github.com/Perl/perl5/commit/4391bbf3146c3ec1de3d7b7cf6a20faf5dc73739
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: c2e19c2e32315223cad3bd2ef08597e81f899352
https://github.com/Perl/perl5/commit/c2e19c2e32315223cad3bd2ef08597e81f899352
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 6e41cc2a62cfba3a30b7697e8abded4249ba1ebf
https://github.com/Perl/perl5/commit/6e41cc2a62cfba3a30b7697e8abded4249ba1ebf
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: e33ecec8c6c17e32f270b7eb31c521343d27024c
https://github.com/Perl/perl5/commit/e33ecec8c6c17e32f270b7eb31c521343d27024c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: a0ae5287db6a665b3872813ab4a38001a4af9153
https://github.com/Perl/perl5/commit/a0ae5287db6a665b3872813ab4a38001a4af9153
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 144f4ea9538266221461db479824afde1ea51334
https://github.com/Perl/perl5/commit/144f4ea9538266221461db479824afde1ea51334
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: a1cc11c9e1593dcf03e1c1bc650fe6707069a952
https://github.com/Perl/perl5/commit/a1cc11c9e1593dcf03e1c1bc650fe6707069a952
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 5b42e0ae0b4efc5dbcec13c9461425325ada8034
https://github.com/Perl/perl5/commit/5b42e0ae0b4efc5dbcec13c9461425325ada8034
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 47d58ebd3e0f04756873da7fa49f8ab43490fb76
https://github.com/Perl/perl5/commit/47d58ebd3e0f04756873da7fa49f8ab43490fb76
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: efd89c5b580d257761c875a7c84ce8c970ad6d5f
https://github.com/Perl/perl5/commit/efd89c5b580d257761c875a7c84ce8c970ad6d5f
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: c6573ca68669d286b74293362647afe490201248
https://github.com/Perl/perl5/commit/c6573ca68669d286b74293362647afe490201248
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: c80069d61ae951e9a896cac4491000cb968a8e02
https://github.com/Perl/perl5/commit/c80069d61ae951e9a896cac4491000cb968a8e02
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 9f279077e8a5cb214735e14d6dea522ccd6bdccf
https://github.com/Perl/perl5/commit/9f279077e8a5cb214735e14d6dea522ccd6bdccf
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 3e2a61bbc4c46bb3119cb34767a27d2ac92cd79f
https://github.com/Perl/perl5/commit/3e2a61bbc4c46bb3119cb34767a27d2ac92cd79f
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: d3e7108f3aa62db1cdd644e7596845f24f8ecee8
https://github.com/Perl/perl5/commit/d3e7108f3aa62db1cdd644e7596845f24f8ecee8
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: e32e42651fd1af838c39ed0c94e4f3db8217f344
https://github.com/Perl/perl5/commit/e32e42651fd1af838c39ed0c94e4f3db8217f344
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: e8f6420d98fb1535767e469719b6e3951e7bf48b
https://github.com/Perl/perl5/commit/e8f6420d98fb1535767e469719b6e3951e7bf48b
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 5b529a9903656fa74f3729451a113d2769ee7698
https://github.com/Perl/perl5/commit/5b529a9903656fa74f3729451a113d2769ee7698
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 6bab887e8956d238955950b79b5fd7d489540f6a
https://github.com/Perl/perl5/commit/6bab887e8956d238955950b79b5fd7d489540f6a
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: adb82b1152b1988ba91a3aa9891d15135f46d34d
https://github.com/Perl/perl5/commit/adb82b1152b1988ba91a3aa9891d15135f46d34d
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 17708a7e1f8ec7a4f956b3bb3742fa9ba4808e59
https://github.com/Perl/perl5/commit/17708a7e1f8ec7a4f956b3bb3742fa9ba4808e59
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: b4fd7a6fecc9c697b0aed601e07ea346feb60a07
https://github.com/Perl/perl5/commit/b4fd7a6fecc9c697b0aed601e07ea346feb60a07
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 93a1dbcf70f97cf83f91b67e6756ab1c6d94fe2c
https://github.com/Perl/perl5/commit/93a1dbcf70f97cf83f91b67e6756ab1c6d94fe2c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: edbf0a37946f3f4e3916455b53f61a4237c63833
https://github.com/Perl/perl5/commit/edbf0a37946f3f4e3916455b53f61a4237c63833
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 84baa48d8a4a57c77e85b71b618c72c045e2a448
https://github.com/Perl/perl5/commit/84baa48d8a4a57c77e85b71b618c72c045e2a448
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 8feb3193ee93183979d840b1ea99a5a078da7072
https://github.com/Perl/perl5/commit/8feb3193ee93183979d840b1ea99a5a078da7072
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 7f381068be77273bc376ae2ec49aa2d74666bc67
https://github.com/Perl/perl5/commit/7f381068be77273bc376ae2ec49aa2d74666bc67
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 6d732b1bdb244cd031d3e06a9072b0478b3e88f6
https://github.com/Perl/perl5/commit/6d732b1bdb244cd031d3e06a9072b0478b3e88f6
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: bc9036fb615be62f60cde518b94151f54071028e
https://github.com/Perl/perl5/commit/bc9036fb615be62f60cde518b94151f54071028e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 260ad7b07afdd4f8f61e1975a3728ae0ab7af6f6
https://github.com/Perl/perl5/commit/260ad7b07afdd4f8f61e1975a3728ae0ab7af6f6
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 66dae6e96783dadc25cc2b24f1dfac74c4144371
https://github.com/Perl/perl5/commit/66dae6e96783dadc25cc2b24f1dfac74c4144371
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: e72798b589b57cc8c571c404484f983848e42002
https://github.com/Perl/perl5/commit/e72798b589b57cc8c571c404484f983848e42002
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: cf96d19d02e311768d7aacd3b59bed8132dd3bba
https://github.com/Perl/perl5/commit/cf96d19d02e311768d7aacd3b59bed8132dd3bba
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 662b230a67a07c6a4b828008eb4c7d0c57c040f6
https://github.com/Perl/perl5/commit/662b230a67a07c6a4b828008eb4c7d0c57c040f6
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: f31b90d468aedd6513bc20c9e2fa497fa1835739
https://github.com/Perl/perl5/commit/f31b90d468aedd6513bc20c9e2fa497fa1835739
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 35452023c0b397dc5c5daf2b68e36d632591b0a3
https://github.com/Perl/perl5/commit/35452023c0b397dc5c5daf2b68e36d632591b0a3
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 4d957ed94730d405d5cba2468a1e2da57f0f7555
https://github.com/Perl/perl5/commit/4d957ed94730d405d5cba2468a1e2da57f0f7555
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 02356b317ee2e3aff2e1dfbdf639f1378c64745d
https://github.com/Perl/perl5/commit/02356b317ee2e3aff2e1dfbdf639f1378c64745d
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 71e8eafe5e091213dab0fa14b2c6b732ae2448b9
https://github.com/Perl/perl5/commit/71e8eafe5e091213dab0fa14b2c6b732ae2448b9
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 9ec78240687f8ad41cde65a6052ad6af7a933814
https://github.com/Perl/perl5/commit/9ec78240687f8ad41cde65a6052ad6af7a933814
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 5ea2343ba756f45da40b6b66c96fe875eb85867a
https://github.com/Perl/perl5/commit/5ea2343ba756f45da40b6b66c96fe875eb85867a
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 62098764098412ed4178e201b6d14c25c2a71eff
https://github.com/Perl/perl5/commit/62098764098412ed4178e201b6d14c25c2a71eff
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 2b35c427ccb8fd7ea5cf374865d22654713212a2
https://github.com/Perl/perl5/commit/2b35c427ccb8fd7ea5cf374865d22654713212a2
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 80dc4d588ad177e7142b529f0fe1c4998b18f42a
https://github.com/Perl/perl5/commit/80dc4d588ad177e7142b529f0fe1c4998b18f42a
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 8295ba6bf36be510e0ec9c8c0530f14bd71e1a56
https://github.com/Perl/perl5/commit/8295ba6bf36be510e0ec9c8c0530f14bd71e1a56
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 9cad15d2c7eda69e93b6fb892f1ddd181c0f5d1b
https://github.com/Perl/perl5/commit/9cad15d2c7eda69e93b6fb892f1ddd181c0f5d1b
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 0caeb178430fa3d7075c34c51b8927de9e5b10a3
https://github.com/Perl/perl5/commit/0caeb178430fa3d7075c34c51b8927de9e5b10a3
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 9c8fc44de6c61ec891661763dfc9b25c307065f7
https://github.com/Perl/perl5/commit/9c8fc44de6c61ec891661763dfc9b25c307065f7
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 8b6cd5b4a5660b439b1fbad9038ab0bb346a80d2
https://github.com/Perl/perl5/commit/8b6cd5b4a5660b439b1fbad9038ab0bb346a80d2
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: b012de2d7ce990c1f3f95edd27eec12c136ff2cd
https://github.com/Perl/perl5/commit/b012de2d7ce990c1f3f95edd27eec12c136ff2cd
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 7a1c4580c06130e2f458f5a01cfa2635fa606037
https://github.com/Perl/perl5/commit/7a1c4580c06130e2f458f5a01cfa2635fa606037
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 17de817398a73aef8ae29da8302a1fbda1f0db41
https://github.com/Perl/perl5/commit/17de817398a73aef8ae29da8302a1fbda1f0db41
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 0d0a425ef448c9a73e09d2dff74624f513334f6e
https://github.com/Perl/perl5/commit/0d0a425ef448c9a73e09d2dff74624f513334f6e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: e11674bbb0abd04f59506a44f5c4ebaf2d9448a7
https://github.com/Perl/perl5/commit/e11674bbb0abd04f59506a44f5c4ebaf2d9448a7
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 5e03b9a318482ade5b122ee962a2877c6b0359c5
https://github.com/Perl/perl5/commit/5e03b9a318482ade5b122ee962a2877c6b0359c5
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 665a2c5c8111dbd51666a8abf2a10b248c5cf5d9
https://github.com/Perl/perl5/commit/665a2c5c8111dbd51666a8abf2a10b248c5cf5d9
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: a5abb8531ff869e0129ec933c9eaf43ce5690116
https://github.com/Perl/perl5/commit/a5abb8531ff869e0129ec933c9eaf43ce5690116
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 91df1b4f6d89b07a7fe83730f8b4e7fc939a6f37
https://github.com/Perl/perl5/commit/91df1b4f6d89b07a7fe83730f8b4e7fc939a6f37
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: d5e67f218dab2d90a32553d9b2c4f7fe7811b23c
https://github.com/Perl/perl5/commit/d5e67f218dab2d90a32553d9b2c4f7fe7811b23c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: b67864cc5970709106685f09ce1c6cc90378aa92
https://github.com/Perl/perl5/commit/b67864cc5970709106685f09ce1c6cc90378aa92
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: d3d878239196b08ca725ed06f53e39f417d8714d
https://github.com/Perl/perl5/commit/d3d878239196b08ca725ed06f53e39f417d8714d
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: aa1a86b2c49d7d3a25afe3c9e3fe283b809481f5
https://github.com/Perl/perl5/commit/aa1a86b2c49d7d3a25afe3c9e3fe283b809481f5
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 8de4de732c40868ddb511bbd1820813819f4d8b2
https://github.com/Perl/perl5/commit/8de4de732c40868ddb511bbd1820813819f4d8b2
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: fa7fa94fe7229f2115255dc3a64165d7df309158
https://github.com/Perl/perl5/commit/fa7fa94fe7229f2115255dc3a64165d7df309158
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 9c0f747ac2fd91dc7749fe4eb68bce5fc995459c
https://github.com/Perl/perl5/commit/9c0f747ac2fd91dc7749fe4eb68bce5fc995459c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: ab9acaf4e81a6b8ff6e47eb217a5857582f88499
https://github.com/Perl/perl5/commit/ab9acaf4e81a6b8ff6e47eb217a5857582f88499
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 33ef67a308cdc8393bf2283851364fd36751d77d
https://github.com/Perl/perl5/commit/33ef67a308cdc8393bf2283851364fd36751d77d
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: f64efffec2244b7d40c7606f3abedbe1015686c5
https://github.com/Perl/perl5/commit/f64efffec2244b7d40c7606f3abedbe1015686c5
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 26c06290ceee76205731388ef419fb62bd953f91
https://github.com/Perl/perl5/commit/26c06290ceee76205731388ef419fb62bd953f91
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 148c90f981b18baaaab867f921a8b9ca6d4e8556
https://github.com/Perl/perl5/commit/148c90f981b18baaaab867f921a8b9ca6d4e8556
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 9cde8eeb29fa91e2ce8f4b39fd27bd7c3eaf8427
https://github.com/Perl/perl5/commit/9cde8eeb29fa91e2ce8f4b39fd27bd7c3eaf8427
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 55186fc244a2af63c6f9dced2462a893e2b419ec
https://github.com/Perl/perl5/commit/55186fc244a2af63c6f9dced2462a893e2b419ec
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 21f96958540eff2d807d51b268f6b61ea021296b
https://github.com/Perl/perl5/commit/21f96958540eff2d807d51b268f6b61ea021296b
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 3e4f2152db48603aa49cdc8b214f2fefa8f917ff
https://github.com/Perl/perl5/commit/3e4f2152db48603aa49cdc8b214f2fefa8f917ff
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: cf2cbd00435a879a5653489f79c6d15ed1f6f1a4
https://github.com/Perl/perl5/commit/cf2cbd00435a879a5653489f79c6d15ed1f6f1a4
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 46b9823d803393abd34265cba191b70e15cab51c
https://github.com/Perl/perl5/commit/46b9823d803393abd34265cba191b70e15cab51c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 381b8d610f61f856c735b37859647f61f5c29f2e
https://github.com/Perl/perl5/commit/381b8d610f61f856c735b37859647f61f5c29f2e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 800a4c7c85b63ee3379f3d948d71335a3f40f123
https://github.com/Perl/perl5/commit/800a4c7c85b63ee3379f3d948d71335a3f40f123
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 074d65fc007f81001d02e49503c12f7a569ed0cf
https://github.com/Perl/perl5/commit/074d65fc007f81001d02e49503c12f7a569ed0cf
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 8549501309e43899478820184fbf8f7b0cc3dc39
https://github.com/Perl/perl5/commit/8549501309e43899478820184fbf8f7b0cc3dc39
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: f9e4dfd76173e3ccb9ad0765ee21215a51e9c7d8
https://github.com/Perl/perl5/commit/f9e4dfd76173e3ccb9ad0765ee21215a51e9c7d8
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 34c38e6a489fce6c745616f5c348a751a452e7b6
https://github.com/Perl/perl5/commit/34c38e6a489fce6c745616f5c348a751a452e7b6
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: bdd8c5c4b1d1bb1fdcf68662dc8c2702f4b131e4
https://github.com/Perl/perl5/commit/bdd8c5c4b1d1bb1fdcf68662dc8c2702f4b131e4
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: a11628dc84202abd872be167e28f056f9bba8a77
https://github.com/Perl/perl5/commit/a11628dc84202abd872be167e28f056f9bba8a77
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 5d5366535ed4373d4de0d61ff70260e38459e8b4
https://github.com/Perl/perl5/commit/5d5366535ed4373d4de0d61ff70260e38459e8b4
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 6a7ba56ce48d382fdc8a472328fac46701e95f3b
https://github.com/Perl/perl5/commit/6a7ba56ce48d382fdc8a472328fac46701e95f3b
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 6899e484b7bd172ccc860e5274392e651606cfd9
https://github.com/Perl/perl5/commit/6899e484b7bd172ccc860e5274392e651606cfd9
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: be74a114f26d7dfc53a2b9932822ac90c786f753
https://github.com/Perl/perl5/commit/be74a114f26d7dfc53a2b9932822ac90c786f753
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: dbd4c26716ef7402bb1179fedb037c880cfcfd6e
https://github.com/Perl/perl5/commit/dbd4c26716ef7402bb1179fedb037c880cfcfd6e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 41e7aa03955105b7adb6b7198dbe0d435ea78471
https://github.com/Perl/perl5/commit/41e7aa03955105b7adb6b7198dbe0d435ea78471
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c934e3d8383ce6e4c4502b7255868784fccaf30e
https://github.com/Perl/perl5/commit/c934e3d8383ce6e4c4502b7255868784fccaf30e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 23434af7c36f14fb15a0e2ff605570e57ef1fc8d
https://github.com/Perl/perl5/commit/23434af7c36f14fb15a0e2ff605570e57ef1fc8d
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 1092aeac5c9e9358b80d0413704584adb16af191
https://github.com/Perl/perl5/commit/1092aeac5c9e9358b80d0413704584adb16af191
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 7af7481d9938f176e593d71d428fa15b55d05e33
https://github.com/Perl/perl5/commit/7af7481d9938f176e593d71d428fa15b55d05e33
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: a6a22cf2b9a44a302c9e14471294d31fb822adc9
https://github.com/Perl/perl5/commit/a6a22cf2b9a44a302c9e14471294d31fb822adc9
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 9a95c26c57885cc7d0a927e59fc50cb256967e31
https://github.com/Perl/perl5/commit/9a95c26c57885cc7d0a927e59fc50cb256967e31
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: fcb33bc4dc26d6ed3321b63de4568dbc72861a6c
https://github.com/Perl/perl5/commit/fcb33bc4dc26d6ed3321b63de4568dbc72861a6c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 2d60d2d6036ae731a1c55cb3cb05d5471de8e47e
https://github.com/Perl/perl5/commit/2d60d2d6036ae731a1c55cb3cb05d5471de8e47e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 84a8186d068da602107dadc4532a76f5d5d10831
https://github.com/Perl/perl5/commit/84a8186d068da602107dadc4532a76f5d5d10831
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 4f574edad74059d3b415197024bcd4106feda363
https://github.com/Perl/perl5/commit/4f574edad74059d3b415197024bcd4106feda363
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: ee07c64d163a299ca33d718d158bbd30497b71e3
https://github.com/Perl/perl5/commit/ee07c64d163a299ca33d718d158bbd30497b71e3
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: d9e691af4a325467867c4012d778b9546f63e4de
https://github.com/Perl/perl5/commit/d9e691af4a325467867c4012d778b9546f63e4de
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 73b414c0fdb2c0f45328ca4a3edfcee4dd9d8d7e
https://github.com/Perl/perl5/commit/73b414c0fdb2c0f45328ca4a3edfcee4dd9d8d7e
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: a4fb4290d363bea496fe858d9225177e47098d64
https://github.com/Perl/perl5/commit/a4fb4290d363bea496fe858d9225177e47098d64
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 286d6c80a043d91aa457cfc1a5907ed063909062
https://github.com/Perl/perl5/commit/286d6c80a043d91aa457cfc1a5907ed063909062
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 8eb442d10aa60a78fb29bab6afd8d8015d3a1dcd
https://github.com/Perl/perl5/commit/8eb442d10aa60a78fb29bab6afd8d8015d3a1dcd
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 5e055967897e70074f6b5eb31e894fa4012d7c0c
https://github.com/Perl/perl5/commit/5e055967897e70074f6b5eb31e894fa4012d7c0c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: cc83e4a9a7ef560c965837c37b86da0fbd5d9d41
https://github.com/Perl/perl5/commit/cc83e4a9a7ef560c965837c37b86da0fbd5d9d41
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 71b3b398931dfef77516d6f78f718e6b4b31bb7a
https://github.com/Perl/perl5/commit/71b3b398931dfef77516d6f78f718e6b4b31bb7a
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 547b5bc3c27bb4c99d8e9f93696fee00d9cbf9b0
https://github.com/Perl/perl5/commit/547b5bc3c27bb4c99d8e9f93696fee00d9cbf9b0
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: ec47fa0e025b2128bc382ccd1f265db1881b9c46
https://github.com/Perl/perl5/commit/ec47fa0e025b2128bc382ccd1f265db1881b9c46
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 1532add92ed22cae158ab2358d2ff98a3bd2d2f8
https://github.com/Perl/perl5/commit/1532add92ed22cae158ab2358d2ff98a3bd2d2f8
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: bd125328d892b0d5d3a8f7ec002f8d878eddf0ea
https://github.com/Perl/perl5/commit/bd125328d892b0d5d3a8f7ec002f8d878eddf0ea
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 6047bc6330367cc6d377f5ff17bef9eeeb042a21
https://github.com/Perl/perl5/commit/6047bc6330367cc6d377f5ff17bef9eeeb042a21
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 235791f0919cf6f18fb78187c1fc791fb077351c
https://github.com/Perl/perl5/commit/235791f0919cf6f18fb78187c1fc791fb077351c
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 4768cc7e4251cece2d989a66ea4299add5822ee5
https://github.com/Perl/perl5/commit/4768cc7e4251cece2d989a66ea4299add5822ee5
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: afe48071479a45d0c9fd0420485753370b80b2c6
https://github.com/Perl/perl5/commit/afe48071479a45d0c9fd0420485753370b80b2c6
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 40deaaeadbb547d4c9366c46e51096b370b5e487
https://github.com/Perl/perl5/commit/40deaaeadbb547d4c9366c46e51096b370b5e487
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 4a5c7f3288c1c4331a31a413932f6482b9cef995
https://github.com/Perl/perl5/commit/4a5c7f3288c1c4331a31a413932f6482b9cef995
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: b86511eca75c3b9656875de031224fe963d8b861
https://github.com/Perl/perl5/commit/b86511eca75c3b9656875de031224fe963d8b861
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: d68ed442a099bd7f999d95cb8cb28a76ca5b58fd
https://github.com/Perl/perl5/commit/d68ed442a099bd7f999d95cb8cb28a76ca5b58fd
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_COLLATION handled the possibility of
being passed a NULL locale name. But we're not changing things unless
we have a new locale, and know its name.
Commit: 8ee84cfd528950db99e4af84312fdd85a51cce57
https://github.com/Perl/perl5/commit/8ee84cfd528950db99e4af84312fdd85a51cce57
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 9d0f51af216dfa8659e04ced278eaf21c510cb13
https://github.com/Perl/perl5/commit/9d0f51af216dfa8659e04ced278eaf21c510cb13
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: aeba7f3c79996d82d297085d37dff9976775b633
https://github.com/Perl/perl5/commit/aeba7f3c79996d82d297085d37dff9976775b633
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 28b6e9990f00f28067b804e0c359f13520318235
https://github.com/Perl/perl5/commit/28b6e9990f00f28067b804e0c359f13520318235
Author: Karl Williamson <[email protected]>
Date: 2021-03-30 (Tue, 30 Mar 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
Log Message:
-----------
f
Compare: https://github.com/Perl/perl5/compare/8c163ece0c22...28b6e9990f00
