Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 2611c879caf0d95fb4adfec463c7317f5ba2186c
https://github.com/Perl/perl5/commit/2611c879caf0d95fb4adfec463c7317f5ba2186c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 186ad4a52ac35f56c1389b2ecebf46a6c66ecb09
https://github.com/Perl/perl5/commit/186ad4a52ac35f56c1389b2ecebf46a6c66ecb09
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 744e53999b5ddac5f9ff6d51260a992d1761dbde
https://github.com/Perl/perl5/commit/744e53999b5ddac5f9ff6d51260a992d1761dbde
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: ccd2cbdee8efbbd01063c29883d3785cbdd6178b
https://github.com/Perl/perl5/commit/ccd2cbdee8efbbd01063c29883d3785cbdd6178b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: b117270b931da85ffa9346f7e558324a62f9edef
https://github.com/Perl/perl5/commit/b117270b931da85ffa9346f7e558324a62f9edef
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: ed7311569af3dbbe7ec7f3de24fd3990cd6f84b5
https://github.com/Perl/perl5/commit/ed7311569af3dbbe7ec7f3de24fd3990cd6f84b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: bd6566b686c272f63bfc576b3af22921667c9d53
https://github.com/Perl/perl5/commit/bd6566b686c272f63bfc576b3af22921667c9d53
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 8b912ced251e4a8b7cc404494c2d5cf6fe24906c
https://github.com/Perl/perl5/commit/8b912ced251e4a8b7cc404494c2d5cf6fe24906c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 38c134a9655e8837108c4700cc2951059624b666
https://github.com/Perl/perl5/commit/38c134a9655e8837108c4700cc2951059624b666
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 5a1e4fed89243a8022e7b1e0120868500e00e56b
https://github.com/Perl/perl5/commit/5a1e4fed89243a8022e7b1e0120868500e00e56b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: f73ef060523a8f815bde91ff6fd39a84253fdd11
https://github.com/Perl/perl5/commit/f73ef060523a8f815bde91ff6fd39a84253fdd11
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 892299c8c95ad3c83ff3529541175e3fb4c9cd9d
https://github.com/Perl/perl5/commit/892299c8c95ad3c83ff3529541175e3fb4c9cd9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 1cba3faa7352e052be5674048b7bd80618e6de45
https://github.com/Perl/perl5/commit/1cba3faa7352e052be5674048b7bd80618e6de45
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: df5c7a75755a1a0bad7e4ae7daa4efdbd2025432
https://github.com/Perl/perl5/commit/df5c7a75755a1a0bad7e4ae7daa4efdbd2025432
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 6527c9f9a4cc61e1e37d9ffb36d870c8df69dbc9
https://github.com/Perl/perl5/commit/6527c9f9a4cc61e1e37d9ffb36d870c8df69dbc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 769179781ff710ffeea7a75cf06066f616234da4
https://github.com/Perl/perl5/commit/769179781ff710ffeea7a75cf06066f616234da4
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 1dda83eb3797144ead164d77e4f8b55e522f2e16
https://github.com/Perl/perl5/commit/1dda83eb3797144ead164d77e4f8b55e522f2e16
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: d912dedd072afd040285b4f6a2038ce1d6bc667b
https://github.com/Perl/perl5/commit/d912dedd072afd040285b4f6a2038ce1d6bc667b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 524eb6e51442f8c175255676018160d2e4f6d989
https://github.com/Perl/perl5/commit/524eb6e51442f8c175255676018160d2e4f6d989
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: d65d2c267706314864018c9c53474ae7d1753b4e
https://github.com/Perl/perl5/commit/d65d2c267706314864018c9c53474ae7d1753b4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 54a8bd044f6f8afc3d2496687670f24f46d192d4
https://github.com/Perl/perl5/commit/54a8bd044f6f8afc3d2496687670f24f46d192d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 8c6155590763ad5645bebe5058ff7d1ef8bc4379
https://github.com/Perl/perl5/commit/8c6155590763ad5645bebe5058ff7d1ef8bc4379
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 39f793696b97e97d3b40824ad4375433afb8c0de
https://github.com/Perl/perl5/commit/39f793696b97e97d3b40824ad4375433afb8c0de
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 004a31d7586479cc14bab39357e268dff7c9c0f1
https://github.com/Perl/perl5/commit/004a31d7586479cc14bab39357e268dff7c9c0f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: b6f60572c6df0753787d92ee0f874ad00cdbbc67
https://github.com/Perl/perl5/commit/b6f60572c6df0753787d92ee0f874ad00cdbbc67
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: f87c0f3a179796b0851483d15684f577e8f7e1b2
https://github.com/Perl/perl5/commit/f87c0f3a179796b0851483d15684f577e8f7e1b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: e234d1bb0274ec4efa052eeb180476cba7aa4da5
https://github.com/Perl/perl5/commit/e234d1bb0274ec4efa052eeb180476cba7aa4da5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: d36ac27db860a98c4dcf63ec9448a3f51e19aee5
https://github.com/Perl/perl5/commit/d36ac27db860a98c4dcf63ec9448a3f51e19aee5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: b12d20a9a9e7033e10b30f1f3d9f66fa66991038
https://github.com/Perl/perl5/commit/b12d20a9a9e7033e10b30f1f3d9f66fa66991038
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 2d5d615f392358d54ce1dd2ded5e31fa10401027
https://github.com/Perl/perl5/commit/2d5d615f392358d54ce1dd2ded5e31fa10401027
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: cdaff60bd188bd82fe249924d13c990a288dc1fe
https://github.com/Perl/perl5/commit/cdaff60bd188bd82fe249924d13c990a288dc1fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 927825e7d2cf85d9584a1907c1818669edee41c9
https://github.com/Perl/perl5/commit/927825e7d2cf85d9584a1907c1818669edee41c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 30c64afb7092536181d2a59c6bf6ee6e80bdc657
https://github.com/Perl/perl5/commit/30c64afb7092536181d2a59c6bf6ee6e80bdc657
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: d9b3a51aab7ade56f9c2bccdeb1e822f6a306b4c
https://github.com/Perl/perl5/commit/d9b3a51aab7ade56f9c2bccdeb1e822f6a306b4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 43a1c5cb16fecaa56a368369ede01d4f36475993
https://github.com/Perl/perl5/commit/43a1c5cb16fecaa56a368369ede01d4f36475993
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 8f3fe56604d578232812e36c475ce4993f5ed8f9
https://github.com/Perl/perl5/commit/8f3fe56604d578232812e36c475ce4993f5ed8f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: babecda174f1c3bc217ded8f7d2a6b958f1d8f3c
https://github.com/Perl/perl5/commit/babecda174f1c3bc217ded8f7d2a6b958f1d8f3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 809d367c5ca19d07aae7195c8f92fbceb9ab12c0
https://github.com/Perl/perl5/commit/809d367c5ca19d07aae7195c8f92fbceb9ab12c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 584c3443d576fc9190a0d60f314437611704176e
https://github.com/Perl/perl5/commit/584c3443d576fc9190a0d60f314437611704176e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: d0233e2d8240314765d44ca0c6ce7cd268d4c6ce
https://github.com/Perl/perl5/commit/d0233e2d8240314765d44ca0c6ce7cd268d4c6ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 87cbcfe8ca451e736327770df9873348683cf07d
https://github.com/Perl/perl5/commit/87cbcfe8ca451e736327770df9873348683cf07d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 0bf8c922ceac24244478bb5f2b986535aae5df3f
https://github.com/Perl/perl5/commit/0bf8c922ceac24244478bb5f2b986535aae5df3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: ac18374223ffbe02247bacdff29d9feb447ca2f1
https://github.com/Perl/perl5/commit/ac18374223ffbe02247bacdff29d9feb447ca2f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: cf7f3a4f805aed8772aa61f354a1a3af10e082bf
https://github.com/Perl/perl5/commit/cf7f3a4f805aed8772aa61f354a1a3af10e082bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: fdc404a045c27536d070ce826e9931d9eecdaa17
https://github.com/Perl/perl5/commit/fdc404a045c27536d070ce826e9931d9eecdaa17
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: bbf81d2f7dd1f004fc92898703c91c534d7663e9
https://github.com/Perl/perl5/commit/bbf81d2f7dd1f004fc92898703c91c534d7663e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 9d5a59f37c18100f5bd57d2fc7dadc523ee24ae0
https://github.com/Perl/perl5/commit/9d5a59f37c18100f5bd57d2fc7dadc523ee24ae0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: b7e9777cd44f83e55ba36d3bdbf39bb6e846850d
https://github.com/Perl/perl5/commit/b7e9777cd44f83e55ba36d3bdbf39bb6e846850d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: a2bb67922e8ccc0ef6caeb09400944f636f85ed3
https://github.com/Perl/perl5/commit/a2bb67922e8ccc0ef6caeb09400944f636f85ed3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 3bc411fda0723de537e0635b543365506378a967
https://github.com/Perl/perl5/commit/3bc411fda0723de537e0635b543365506378a967
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 5c7331cef0c2a74b5b2d26820c61cbfc3bd1b760
https://github.com/Perl/perl5/commit/5c7331cef0c2a74b5b2d26820c61cbfc3bd1b760
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: d27a44ac4459670d79517a3b512d4f828f30366f
https://github.com/Perl/perl5/commit/d27a44ac4459670d79517a3b512d4f828f30366f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 69a12db88d68afadd9894363fd7bb1184a948a8b
https://github.com/Perl/perl5/commit/69a12db88d68afadd9894363fd7bb1184a948a8b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 1820e50b8e5721356254506297207904370b4804
https://github.com/Perl/perl5/commit/1820e50b8e5721356254506297207904370b4804
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: ed9e84552a275601270fe67a8c7a75ea26ab0d9d
https://github.com/Perl/perl5/commit/ed9e84552a275601270fe67a8c7a75ea26ab0d9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: a133bbaa464e073d07b84ec77ebf48fc78c49429
https://github.com/Perl/perl5/commit/a133bbaa464e073d07b84ec77ebf48fc78c49429
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 9b94f0b2e762b760f268b905427b792d979c04ca
https://github.com/Perl/perl5/commit/9b94f0b2e762b760f268b905427b792d979c04ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 95495a2db207d82fb409bdcf7f8cd28b1c4f0262
https://github.com/Perl/perl5/commit/95495a2db207d82fb409bdcf7f8cd28b1c4f0262
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: f027ddf0be3cc5ef73c801c81cb6fd44edcdcd97
https://github.com/Perl/perl5/commit/f027ddf0be3cc5ef73c801c81cb6fd44edcdcd97
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: edc496a9d5cb9d1a9c9d2e1e889b0aa838d39246
https://github.com/Perl/perl5/commit/edc496a9d5cb9d1a9c9d2e1e889b0aa838d39246
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: f64b4bd5b9483edcf850981a59b1b2a5f28e2332
https://github.com/Perl/perl5/commit/f64b4bd5b9483edcf850981a59b1b2a5f28e2332
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: b710ca2f230ba4158f41a5391ef48c561bdea81d
https://github.com/Perl/perl5/commit/b710ca2f230ba4158f41a5391ef48c561bdea81d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 25093ba7602999210815fc1f8e866f7999278585
https://github.com/Perl/perl5/commit/25093ba7602999210815fc1f8e866f7999278585
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 6f8e8dda992a61a8b5564f68fd8903292d2c220b
https://github.com/Perl/perl5/commit/6f8e8dda992a61a8b5564f68fd8903292d2c220b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 1a52fadf4b2513968dda411b2bc40fce5c61f435
https://github.com/Perl/perl5/commit/1a52fadf4b2513968dda411b2bc40fce5c61f435
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 4ef6d3bc776f13a9ad715820db4cef30b660f07e
https://github.com/Perl/perl5/commit/4ef6d3bc776f13a9ad715820db4cef30b660f07e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: cdc5b28fb82ea773fa6e584cccd5b0c04dcddf85
https://github.com/Perl/perl5/commit/cdc5b28fb82ea773fa6e584cccd5b0c04dcddf85
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 9f8d7d61b5e160de88d1d6b7fffeb4469755a9a0
https://github.com/Perl/perl5/commit/9f8d7d61b5e160de88d1d6b7fffeb4469755a9a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: fd01309ab433afdc0696b7cdf7fe74445e305094
https://github.com/Perl/perl5/commit/fd01309ab433afdc0696b7cdf7fe74445e305094
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 4ad19627d34663480b20c0040b1b99dcdd8154d8
https://github.com/Perl/perl5/commit/4ad19627d34663480b20c0040b1b99dcdd8154d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 9a960d119f7775337efdcdbd8b055d8430a89247
https://github.com/Perl/perl5/commit/9a960d119f7775337efdcdbd8b055d8430a89247
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 6ba64db3ac746bc0ca2b3ebfc7996b89e42b9dae
https://github.com/Perl/perl5/commit/6ba64db3ac746bc0ca2b3ebfc7996b89e42b9dae
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: c1dc6852f3e0bbbf34ed282a733da9d45cfa8c0d
https://github.com/Perl/perl5/commit/c1dc6852f3e0bbbf34ed282a733da9d45cfa8c0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 5b47f55233428c9c0b80ada28b0c18c7b5d82c6b
https://github.com/Perl/perl5/commit/5b47f55233428c9c0b80ada28b0c18c7b5d82c6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: a1e31c089536e859c74f54b54a645e85be0bcb7d
https://github.com/Perl/perl5/commit/a1e31c089536e859c74f54b54a645e85be0bcb7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 1c254e25a5489e0d9379e6e2b15ee94ccad038ea
https://github.com/Perl/perl5/commit/1c254e25a5489e0d9379e6e2b15ee94ccad038ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: e91ff2befcedc299621c9f87e58247a1b330565f
https://github.com/Perl/perl5/commit/e91ff2befcedc299621c9f87e58247a1b330565f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 1b07e7c658a12ce5e1b2cffa36d269b71807ca24
https://github.com/Perl/perl5/commit/1b07e7c658a12ce5e1b2cffa36d269b71807ca24
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 34c66a915ca1423f2400e2d08920aeb6441bea07
https://github.com/Perl/perl5/commit/34c66a915ca1423f2400e2d08920aeb6441bea07
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 26cc3d34f9863d5bf0613b6814bf0da9beb1a875
https://github.com/Perl/perl5/commit/26cc3d34f9863d5bf0613b6814bf0da9beb1a875
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 6ce98686531fe6ea0a9f271fed35265f751ec4a4
https://github.com/Perl/perl5/commit/6ce98686531fe6ea0a9f271fed35265f751ec4a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: a0d6adb5fb1eb7b0a1c6e405725ea01f5127ce89
https://github.com/Perl/perl5/commit/a0d6adb5fb1eb7b0a1c6e405725ea01f5127ce89
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 90429c35485047ac492426d534e3f3743446c3de
https://github.com/Perl/perl5/commit/90429c35485047ac492426d534e3f3743446c3de
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: c7b2974adbb671807c00ab0b13587a218ff62f47
https://github.com/Perl/perl5/commit/c7b2974adbb671807c00ab0b13587a218ff62f47
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 05c565092ae00e72ed77c43cc3f7cc2da4b467c4
https://github.com/Perl/perl5/commit/05c565092ae00e72ed77c43cc3f7cc2da4b467c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: fd792d98636f50bd1108539035ae9fb33117601c
https://github.com/Perl/perl5/commit/fd792d98636f50bd1108539035ae9fb33117601c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 2c6df1502ddaf19621c1d27b89402261f1e080d5
https://github.com/Perl/perl5/commit/2c6df1502ddaf19621c1d27b89402261f1e080d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: bbecf9b849df6e0adc2e7ce92b85770c56900419
https://github.com/Perl/perl5/commit/bbecf9b849df6e0adc2e7ce92b85770c56900419
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: d294ec386c1a4cc3e1fb753f04f7470d976663d9
https://github.com/Perl/perl5/commit/d294ec386c1a4cc3e1fb753f04f7470d976663d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: b478a867dadda8fa041afa14378cab24e24cb5c7
https://github.com/Perl/perl5/commit/b478a867dadda8fa041afa14378cab24e24cb5c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 31f8336e6e1ae2479be565ec0f312b4e6be08e49
https://github.com/Perl/perl5/commit/31f8336e6e1ae2479be565ec0f312b4e6be08e49
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 409fe232a3660b70df625d74ec7d33c64fb3164f
https://github.com/Perl/perl5/commit/409fe232a3660b70df625d74ec7d33c64fb3164f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: ca2dbca511e9f4713215351f11e6d7f49b644f57
https://github.com/Perl/perl5/commit/ca2dbca511e9f4713215351f11e6d7f49b644f57
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 7373bb50ef254be4346dff2e1e1a2ac57560355a
https://github.com/Perl/perl5/commit/7373bb50ef254be4346dff2e1e1a2ac57560355a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 44e46d02452e7337c55ac33b185ec3fb73405779
https://github.com/Perl/perl5/commit/44e46d02452e7337c55ac33b185ec3fb73405779
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 9c00e8f29da5b763d5c887dac94e9024de989cba
https://github.com/Perl/perl5/commit/9c00e8f29da5b763d5c887dac94e9024de989cba
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 1d0158e71c4f12b78f6d6f9aef1998c4bdfc6af7
https://github.com/Perl/perl5/commit/1d0158e71c4f12b78f6d6f9aef1998c4bdfc6af7
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: e63f60c763f107f423798b8e9c4d0c08ccb9580b
https://github.com/Perl/perl5/commit/e63f60c763f107f423798b8e9c4d0c08ccb9580b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: d84b28d18fcb027e6dbafd9aca8355c4405cf604
https://github.com/Perl/perl5/commit/d84b28d18fcb027e6dbafd9aca8355c4405cf604
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 11a2bc6d1d9380102c3eb1b682974358d23d076f
https://github.com/Perl/perl5/commit/11a2bc6d1d9380102c3eb1b682974358d23d076f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 0400c6e1e43968c0fecc02317ac737df510db1ff
https://github.com/Perl/perl5/commit/0400c6e1e43968c0fecc02317ac737df510db1ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 76418642a483e81f3965c4d9e03fb05826e0da65
https://github.com/Perl/perl5/commit/76418642a483e81f3965c4d9e03fb05826e0da65
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 4f44f2db3881669665a5c686e08fc9f4e372b14b
https://github.com/Perl/perl5/commit/4f44f2db3881669665a5c686e08fc9f4e372b14b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: c00ce6cacb70464bed3bf5abb28c069276a690c9
https://github.com/Perl/perl5/commit/c00ce6cacb70464bed3bf5abb28c069276a690c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 0a5e5b946205259860dfd8f845e25cc2eddb3caa
https://github.com/Perl/perl5/commit/0a5e5b946205259860dfd8f845e25cc2eddb3caa
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: b831aeb945e335993f19d1da45aa04477808c590
https://github.com/Perl/perl5/commit/b831aeb945e335993f19d1da45aa04477808c590
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 7ac6c4e9cfccf08bc52325df6d1b5bfa753f7850
https://github.com/Perl/perl5/commit/7ac6c4e9cfccf08bc52325df6d1b5bfa753f7850
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 98ee912782c8856cdefdb8afb82d648b5002f87b
https://github.com/Perl/perl5/commit/98ee912782c8856cdefdb8afb82d648b5002f87b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: f52add4f35b1545f4956c356fd694f29527bd720
https://github.com/Perl/perl5/commit/f52add4f35b1545f4956c356fd694f29527bd720
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 1fa0a8f48117270b2253f5cf9ad2b9fb5ccf5c44
https://github.com/Perl/perl5/commit/1fa0a8f48117270b2253f5cf9ad2b9fb5ccf5c44
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: c2448714252b33bf49dc49c817a5be60e7f99b03
https://github.com/Perl/perl5/commit/c2448714252b33bf49dc49c817a5be60e7f99b03
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 83648bc04584a3b083b7b98708c691a5fc677d74
https://github.com/Perl/perl5/commit/83648bc04584a3b083b7b98708c691a5fc677d74
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 798c03f05f42edc2ead94128c5fdbafc1b9bbbd5
https://github.com/Perl/perl5/commit/798c03f05f42edc2ead94128c5fdbafc1b9bbbd5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: d304bd29201d67ba2bf92051b646528b8a4afe52
https://github.com/Perl/perl5/commit/d304bd29201d67ba2bf92051b646528b8a4afe52
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 43709a5085fd78f2efcff5ac69c24b6ae7c54bb2
https://github.com/Perl/perl5/commit/43709a5085fd78f2efcff5ac69c24b6ae7c54bb2
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: d7b10311b1f04cffa6142e1d7fd6313def8f4f9a
https://github.com/Perl/perl5/commit/d7b10311b1f04cffa6142e1d7fd6313def8f4f9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 7eddb525aa65de0d60ad4c6291e6bc7e1f74ef92
https://github.com/Perl/perl5/commit/7eddb525aa65de0d60ad4c6291e6bc7e1f74ef92
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 5e008a442684d8c94313d7c837aac13139d07906
https://github.com/Perl/perl5/commit/5e008a442684d8c94313d7c837aac13139d07906
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 2680c17c23a2589ff0202000b2f8ffcfa723edaf
https://github.com/Perl/perl5/commit/2680c17c23a2589ff0202000b2f8ffcfa723edaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 16e64d78605bf9d930fe65ab7afa732b50b1a85c
https://github.com/Perl/perl5/commit/16e64d78605bf9d930fe65ab7afa732b50b1a85c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 85d5b9e6e388ff70a0d675a66e87a4b77fe3eb53
https://github.com/Perl/perl5/commit/85d5b9e6e388ff70a0d675a66e87a4b77fe3eb53
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: fe2bf71550d0826a3704f212a0d51f0965aa0ddb
https://github.com/Perl/perl5/commit/fe2bf71550d0826a3704f212a0d51f0965aa0ddb
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: d15dd252f5889261234c86ae8b0111c4b7c6f2aa
https://github.com/Perl/perl5/commit/d15dd252f5889261234c86ae8b0111c4b7c6f2aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 47d9e38e6cc89efc63e6c9f115c250cb27a8e04b
https://github.com/Perl/perl5/commit/47d9e38e6cc89efc63e6c9f115c250cb27a8e04b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: b445867731e41d4231b3e9580f4c3718c4fba056
https://github.com/Perl/perl5/commit/b445867731e41d4231b3e9580f4c3718c4fba056
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 990e64b93fdf0dfc437328dee2ed923463e24849
https://github.com/Perl/perl5/commit/990e64b93fdf0dfc437328dee2ed923463e24849
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 796a52a1dd2fffa48fecdf093bb06836e51fac27
https://github.com/Perl/perl5/commit/796a52a1dd2fffa48fecdf093bb06836e51fac27
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 6950721567eb6e34c1a38e86d721d21ef5eb5710
https://github.com/Perl/perl5/commit/6950721567eb6e34c1a38e86d721d21ef5eb5710
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 631ceca89391421321bfdb501659469929f54310
https://github.com/Perl/perl5/commit/631ceca89391421321bfdb501659469929f54310
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 0bb57ca879c9be4c3d2769108830071c2f6f2123
https://github.com/Perl/perl5/commit/0bb57ca879c9be4c3d2769108830071c2f6f2123
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 759d5ed72d391ac5b81a8e2226009989de168e48
https://github.com/Perl/perl5/commit/759d5ed72d391ac5b81a8e2226009989de168e48
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: af5fc2cc60b6f4a7640f491be9620b227ab50e54
https://github.com/Perl/perl5/commit/af5fc2cc60b6f4a7640f491be9620b227ab50e54
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: f556da123257f5bfd3e950bb851fe58a3e13a2c1
https://github.com/Perl/perl5/commit/f556da123257f5bfd3e950bb851fe58a3e13a2c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 4e1e8d1d8510cbe21105ed78bdb039e8611ac9fa
https://github.com/Perl/perl5/commit/4e1e8d1d8510cbe21105ed78bdb039e8611ac9fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: fdc60960826ff87e026d2c7cba3996f5b448d5df
https://github.com/Perl/perl5/commit/fdc60960826ff87e026d2c7cba3996f5b448d5df
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 8a1933e942048007aeae66df76e35f7afa943993
https://github.com/Perl/perl5/commit/8a1933e942048007aeae66df76e35f7afa943993
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: c6123b82061cca122b9d3ed37193adf2aaa92efd
https://github.com/Perl/perl5/commit/c6123b82061cca122b9d3ed37193adf2aaa92efd
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 172a2fba8431274b4b2e37945f94a3949c0eb9fc
https://github.com/Perl/perl5/commit/172a2fba8431274b4b2e37945f94a3949c0eb9fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 762fd4fbe8470e904969a537ddcf3da21fd0a3e0
https://github.com/Perl/perl5/commit/762fd4fbe8470e904969a537ddcf3da21fd0a3e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 77cacdb1d8a7c30b1cede828df739894f323e551
https://github.com/Perl/perl5/commit/77cacdb1d8a7c30b1cede828df739894f323e551
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: c09c2a6dd8f2016ee2055ff80e252d592ea50aa6
https://github.com/Perl/perl5/commit/c09c2a6dd8f2016ee2055ff80e252d592ea50aa6
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: ad4d119a0cdf4e0583cc6e7cc24044491031955e
https://github.com/Perl/perl5/commit/ad4d119a0cdf4e0583cc6e7cc24044491031955e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: f0b3045818987569f3640dcaaba12b66e595be09
https://github.com/Perl/perl5/commit/f0b3045818987569f3640dcaaba12b66e595be09
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 4005122c7525dfdd95d6a616eb7bc802276db85b
https://github.com/Perl/perl5/commit/4005122c7525dfdd95d6a616eb7bc802276db85b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 69439383b2932f433cad325be832cf019b7d0504
https://github.com/Perl/perl5/commit/69439383b2932f433cad325be832cf019b7d0504
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: a082bf74e10b077246a36cf61721fb25b7594afa
https://github.com/Perl/perl5/commit/a082bf74e10b077246a36cf61721fb25b7594afa
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 626377bc16506542d56f4a6d57d03514e7cefe84
https://github.com/Perl/perl5/commit/626377bc16506542d56f4a6d57d03514e7cefe84
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 7689c645bd5d6921ea77c85779652360a1df4f2c
https://github.com/Perl/perl5/commit/7689c645bd5d6921ea77c85779652360a1df4f2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 38b4731f6fa0618763cc599355a0f35c6ccdaee7
https://github.com/Perl/perl5/commit/38b4731f6fa0618763cc599355a0f35c6ccdaee7
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 49e7f81f5655342fda7d109e94953464adb70232
https://github.com/Perl/perl5/commit/49e7f81f5655342fda7d109e94953464adb70232
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 2b9b79f712959c0c29a69bdcaec767722c727cc5
https://github.com/Perl/perl5/commit/2b9b79f712959c0c29a69bdcaec767722c727cc5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 0187fcd964b6ff120c2db5435adc172bfd2f0875
https://github.com/Perl/perl5/commit/0187fcd964b6ff120c2db5435adc172bfd2f0875
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 53bd51b2eb87927f5e540ec08427e55c6ff9a227
https://github.com/Perl/perl5/commit/53bd51b2eb87927f5e540ec08427e55c6ff9a227
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 3edd5660d769adb566a6c67c6f2c9b4c673a417e
https://github.com/Perl/perl5/commit/3edd5660d769adb566a6c67c6f2c9b4c673a417e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 3fd7d6c91d7ee6f67d14bd0cb9a7f3799ca43d2a
https://github.com/Perl/perl5/commit/3fd7d6c91d7ee6f67d14bd0cb9a7f3799ca43d2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: d64d1084aea3a2e78cd3a0f9d3e5e2ce4bcfd3fb
https://github.com/Perl/perl5/commit/d64d1084aea3a2e78cd3a0f9d3e5e2ce4bcfd3fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: b25778122b1b6dfe82c129bf1bb45ce188ed3eff
https://github.com/Perl/perl5/commit/b25778122b1b6dfe82c129bf1bb45ce188ed3eff
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 48f74823e7533539b0602c45007bf9b958d4ed5c
https://github.com/Perl/perl5/commit/48f74823e7533539b0602c45007bf9b958d4ed5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 33f6fd11401f93bed7a5f348b9312fbe8f121ca7
https://github.com/Perl/perl5/commit/33f6fd11401f93bed7a5f348b9312fbe8f121ca7
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 90415c354d811025f4cfae8c4635d3eb51ccc2b6
https://github.com/Perl/perl5/commit/90415c354d811025f4cfae8c4635d3eb51ccc2b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: f93ab1b5b13f22794c1dd3532f62b14d393158b2
https://github.com/Perl/perl5/commit/f93ab1b5b13f22794c1dd3532f62b14d393158b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: ed5d515bfe3d8c88082fc8eebf89e7e9d7ce6ac1
https://github.com/Perl/perl5/commit/ed5d515bfe3d8c88082fc8eebf89e7e9d7ce6ac1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 1ecb74adfa5d3d7700d5c2d1cc256ab840ac294d
https://github.com/Perl/perl5/commit/1ecb74adfa5d3d7700d5c2d1cc256ab840ac294d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: d351dbf9546c1cdff5e610fba54256606c3e9beb
https://github.com/Perl/perl5/commit/d351dbf9546c1cdff5e610fba54256606c3e9beb
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: e621344369df05faefef17ec4321ad7e551c44e7
https://github.com/Perl/perl5/commit/e621344369df05faefef17ec4321ad7e551c44e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 2d680daaec467b167e5588482d6d83f8c4b6cf09
https://github.com/Perl/perl5/commit/2d680daaec467b167e5588482d6d83f8c4b6cf09
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 39ff3b055f62b19a8f4a885e1f1b2f852fde579d
https://github.com/Perl/perl5/commit/39ff3b055f62b19a8f4a885e1f1b2f852fde579d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: f4eeda385615b6dda67be7fdbab1fe9303ea5f05
https://github.com/Perl/perl5/commit/f4eeda385615b6dda67be7fdbab1fe9303ea5f05
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 524d337d9399d8eee5baecf71789e30a56e83904
https://github.com/Perl/perl5/commit/524d337d9399d8eee5baecf71789e30a56e83904
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 9aad7aad5e3d2e28b1387add315b66d984c6b3d0
https://github.com/Perl/perl5/commit/9aad7aad5e3d2e28b1387add315b66d984c6b3d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: b66d0ae1f56d2f15dfad32885abea11dc8fdb03c
https://github.com/Perl/perl5/commit/b66d0ae1f56d2f15dfad32885abea11dc8fdb03c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 5119eba05521d44e18b115f030670eb0694fa562
https://github.com/Perl/perl5/commit/5119eba05521d44e18b115f030670eb0694fa562
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: c064f2ca6c00f4e920f6f64b20eefe24bfb32ac1
https://github.com/Perl/perl5/commit/c064f2ca6c00f4e920f6f64b20eefe24bfb32ac1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 6ea9650a450d4f11774895e8a58b846a2c19c45e
https://github.com/Perl/perl5/commit/6ea9650a450d4f11774895e8a58b846a2c19c45e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 485d1751bf2e1fc3dfc01e9fc1c25ba8348cc136
https://github.com/Perl/perl5/commit/485d1751bf2e1fc3dfc01e9fc1c25ba8348cc136
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: af3487be6573657b54f52715b6b420527f5a6eff
https://github.com/Perl/perl5/commit/af3487be6573657b54f52715b6b420527f5a6eff
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 56fcc342ef6a9d71994a72b4e2e5a0a0e10faf77
https://github.com/Perl/perl5/commit/56fcc342ef6a9d71994a72b4e2e5a0a0e10faf77
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: dbdd5f1602d0bdd8e273904c2e84d182eb89a2af
https://github.com/Perl/perl5/commit/dbdd5f1602d0bdd8e273904c2e84d182eb89a2af
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 5282c731f44fe9775dc5cc2832a360093807e32c
https://github.com/Perl/perl5/commit/5282c731f44fe9775dc5cc2832a360093807e32c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 2ce4457f64c2f3bf88ad93812db08036654abee3
https://github.com/Perl/perl5/commit/2ce4457f64c2f3bf88ad93812db08036654abee3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 18c21361256e7b511fe6b832fa6dcfae1dafc03a
https://github.com/Perl/perl5/commit/18c21361256e7b511fe6b832fa6dcfae1dafc03a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: f4b7b78495895beadeee08525e577ffbcd6a5a56
https://github.com/Perl/perl5/commit/f4b7b78495895beadeee08525e577ffbcd6a5a56
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: d1389a7b33d40f97c8c9ac251cf10b799a62f1e9
https://github.com/Perl/perl5/commit/d1389a7b33d40f97c8c9ac251cf10b799a62f1e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 43639c8f2a8a9cbda5fd4ac5b2a9774e33f67a7c
https://github.com/Perl/perl5/commit/43639c8f2a8a9cbda5fd4ac5b2a9774e33f67a7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 3b2253df17ff48bb51ad1626bacbd126027f559d
https://github.com/Perl/perl5/commit/3b2253df17ff48bb51ad1626bacbd126027f559d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 2c7da6a4d9c09a8f3bcf55dbb45b9682c8e27712
https://github.com/Perl/perl5/commit/2c7da6a4d9c09a8f3bcf55dbb45b9682c8e27712
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: bf44a8f502e005783c0263192c2dbce7132c5c06
https://github.com/Perl/perl5/commit/bf44a8f502e005783c0263192c2dbce7132c5c06
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: e7fe2cd8de039b34f923d09bb731f0b09b880bcb
https://github.com/Perl/perl5/commit/e7fe2cd8de039b34f923d09bb731f0b09b880bcb
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: e0b6171de7ba7c59761226f1fdee65d732e20464
https://github.com/Perl/perl5/commit/e0b6171de7ba7c59761226f1fdee65d732e20464
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 8055b4fa19710ac81c60ef9a0cd7c13509f93620
https://github.com/Perl/perl5/commit/8055b4fa19710ac81c60ef9a0cd7c13509f93620
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 3ce295e49fd6d86e53e80bc74ba79bfbf484b245
https://github.com/Perl/perl5/commit/3ce295e49fd6d86e53e80bc74ba79bfbf484b245
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: adda6ca578447a8841ef40cd51fbe45d3d36bc5f
https://github.com/Perl/perl5/commit/adda6ca578447a8841ef40cd51fbe45d3d36bc5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 6ee214028806e89ba4f81ee3a0dd3350005fe101
https://github.com/Perl/perl5/commit/6ee214028806e89ba4f81ee3a0dd3350005fe101
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: a48aa31b364a0607a5df2d7fb197d2d95a9ccf2e
https://github.com/Perl/perl5/commit/a48aa31b364a0607a5df2d7fb197d2d95a9ccf2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 4bbaf3f9661a590c0957ad9408cbcc00210eae5b
https://github.com/Perl/perl5/commit/4bbaf3f9661a590c0957ad9408cbcc00210eae5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 669c5829b1418b2a8674b86a88dee624b26b9a02
https://github.com/Perl/perl5/commit/669c5829b1418b2a8674b86a88dee624b26b9a02
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: a4e092d2d7d77d761e2a54f9c9dff2dfe7a57832
https://github.com/Perl/perl5/commit/a4e092d2d7d77d761e2a54f9c9dff2dfe7a57832
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: c002f1c9f7de29044dc87f7e385a3eff867ca358
https://github.com/Perl/perl5/commit/c002f1c9f7de29044dc87f7e385a3eff867ca358
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: bb96386414f2bc0c4d392fe7678aec1e1709b31e
https://github.com/Perl/perl5/commit/bb96386414f2bc0c4d392fe7678aec1e1709b31e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: bd2a6756854b884c760e3c8ffd3201bc870719a9
https://github.com/Perl/perl5/commit/bd2a6756854b884c760e3c8ffd3201bc870719a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 6fcf9cec62b78b14b24669b3a140864e1c3c3959
https://github.com/Perl/perl5/commit/6fcf9cec62b78b14b24669b3a140864e1c3c3959
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 57bf4a40acf12932afeaf9105ddcd365ed211234
https://github.com/Perl/perl5/commit/57bf4a40acf12932afeaf9105ddcd365ed211234
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: ad516ff458546c310e2a89566024dfd506730dda
https://github.com/Perl/perl5/commit/ad516ff458546c310e2a89566024dfd506730dda
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 9156882e915f5d3ec344cdb4f12d8570088ae6d5
https://github.com/Perl/perl5/commit/9156882e915f5d3ec344cdb4f12d8570088ae6d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 3e5e4b45f30c5afd3793326aea017c7dc71f73bd
https://github.com/Perl/perl5/commit/3e5e4b45f30c5afd3793326aea017c7dc71f73bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_COLLATION handled the possibility of
being passed a NULL locale name. But we're not changing things unless
we have a new locale, and know its name.
Commit: a6ca2bec733e01bb80e33b9b4ee67811904df999
https://github.com/Perl/perl5/commit/a6ca2bec733e01bb80e33b9b4ee67811904df999
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 1b7529febf6ea2f8371f3d780ef3ebb635b31995
https://github.com/Perl/perl5/commit/1b7529febf6ea2f8371f3d780ef3ebb635b31995
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 6d6318c0aec68cfc1fbe5dea4afedfa51fa22b75
https://github.com/Perl/perl5/commit/6d6318c0aec68cfc1fbe5dea4afedfa51fa22b75
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 0a7d6a486a36b3c2322b7e208df0186e5408f1bb
https://github.com/Perl/perl5/commit/0a7d6a486a36b3c2322b7e208df0186e5408f1bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
Log Message:
-----------
f
Commit: 1f1bc149a1a3295bb808f1e7622dd36ace70e23a
https://github.com/Perl/perl5/commit/1f1bc149a1a3295bb808f1e7622dd36ace70e23a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Add missing SKIP: label
Commit: b496b06402a0e81ef9576aac296dfb4b5254d8c3
https://github.com/Perl/perl5/commit/b496b06402a0e81ef9576aac296dfb4b5254d8c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Fix tests
This was misleadingly outputting an undef value, instead of just saying
it's undef
Commit: c8be5cc1de889a3dfb00f8c39220c2129aa854ce
https://github.com/Perl/perl5/commit/c8be5cc1de889a3dfb00f8c39220c2129aa854ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M ext/XS-APItest/t/locale.t
M lib/locale.t
M lib/locale_threads.t
M locale.c
M proto.h
Log Message:
-----------
f
Commit: 9b88a349d8c02bed3c765f9de1af2ee0a65224d8
https://github.com/Perl/perl5/commit/9b88a349d8c02bed3c765f9de1af2ee0a65224d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
Log Message:
-----------
f
Commit: 08b24c90dbcb86dbf2467fc6246fa7be99b57969
https://github.com/Perl/perl5/commit/08b24c90dbcb86dbf2467fc6246fa7be99b57969
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale.t
M lib/locale_threads.t
M locale.c
Log Message:
-----------
yet more
Commit: 79ce5b434ebcdd78c44d2f5b02bccfe33c97f26c
https://github.com/Perl/perl5/commit/79ce5b434ebcdd78c44d2f5b02bccfe33c97f26c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale.t
M lib/locale_threads.t
Log Message:
-----------
more2
Commit: fd447e13a05b0984fdc5432ffea3d7e7ce78d17a
https://github.com/Perl/perl5/commit/fd447e13a05b0984fdc5432ffea3d7e7ce78d17a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
M handy.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M regexec.c
Log Message:
-----------
more3
Compare: https://github.com/Perl/perl5/compare/7072e00ea70b...fd447e13a05b
