Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 7d00f8015994f3c8ea172053d6f7c011cfd114ab
https://github.com/Perl/perl5/commit/7d00f8015994f3c8ea172053d6f7c011cfd114ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 2796311b5cd2099ef88551547afc36f8f365bf8e
https://github.com/Perl/perl5/commit/2796311b5cd2099ef88551547afc36f8f365bf8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 2aaa734e0c73822ef801c4330c0ecd683d1d4a66
https://github.com/Perl/perl5/commit/2aaa734e0c73822ef801c4330c0ecd683d1d4a66
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: e615ec84a05f30c2c9d59f38464b4cb4e6e808fd
https://github.com/Perl/perl5/commit/e615ec84a05f30c2c9d59f38464b4cb4e6e808fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 9c72608a7114d4419c47e2f80cb5e3645d1ee46b
https://github.com/Perl/perl5/commit/9c72608a7114d4419c47e2f80cb5e3645d1ee46b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: b57e597052ca145d46fd6ac3dddc8f0f485c338e
https://github.com/Perl/perl5/commit/b57e597052ca145d46fd6ac3dddc8f0f485c338e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: a75dc2058a9af7ecf3829e3e2126ae8129700c97
https://github.com/Perl/perl5/commit/a75dc2058a9af7ecf3829e3e2126ae8129700c97
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 8f9020d6b0165f725bb8a39b4f4fc74e320ba9be
https://github.com/Perl/perl5/commit/8f9020d6b0165f725bb8a39b4f4fc74e320ba9be
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 2e92490e0977da5f3e2c0c1558e84a476e4e28a4
https://github.com/Perl/perl5/commit/2e92490e0977da5f3e2c0c1558e84a476e4e28a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 2846e72051f19cb597e01607477690e3f7cd7080
https://github.com/Perl/perl5/commit/2846e72051f19cb597e01607477690e3f7cd7080
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 77f80bf1613aebc2c43665e6d0dcf7ef5e490907
https://github.com/Perl/perl5/commit/77f80bf1613aebc2c43665e6d0dcf7ef5e490907
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 132d8c695f239598805dadb957825a0a48f2ffd0
https://github.com/Perl/perl5/commit/132d8c695f239598805dadb957825a0a48f2ffd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 6b6909effba8a3dff745960c27ee6d068bccd5f9
https://github.com/Perl/perl5/commit/6b6909effba8a3dff745960c27ee6d068bccd5f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 40a37d65a2f18aeb349349ae2e3d8e2161d95306
https://github.com/Perl/perl5/commit/40a37d65a2f18aeb349349ae2e3d8e2161d95306
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 69cfac889f8c2dc2156be1f1d27e89dced935ffd
https://github.com/Perl/perl5/commit/69cfac889f8c2dc2156be1f1d27e89dced935ffd
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 8a965df0ed0562010ba9d146dd8296e4827a6e4f
https://github.com/Perl/perl5/commit/8a965df0ed0562010ba9d146dd8296e4827a6e4f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 8729a85405aa6a0c352470e343920243e87b4b5f
https://github.com/Perl/perl5/commit/8729a85405aa6a0c352470e343920243e87b4b5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 581836e8438c920231dcfaba6c191d2f28b651d9
https://github.com/Perl/perl5/commit/581836e8438c920231dcfaba6c191d2f28b651d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 7f22034b9fe59a7db00305830b234e425552bf37
https://github.com/Perl/perl5/commit/7f22034b9fe59a7db00305830b234e425552bf37
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: b697c7d89c13875bfee3193f4c3ebaf2be074d3c
https://github.com/Perl/perl5/commit/b697c7d89c13875bfee3193f4c3ebaf2be074d3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: f095d35676e99491bb32487c73f803c60a551722
https://github.com/Perl/perl5/commit/f095d35676e99491bb32487c73f803c60a551722
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: d7a531f6e5c9bd839702b19af42f922bfb173b08
https://github.com/Perl/perl5/commit/d7a531f6e5c9bd839702b19af42f922bfb173b08
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 05a7d2510e9505a4ca8909e7b1ce74ce943cc8f5
https://github.com/Perl/perl5/commit/05a7d2510e9505a4ca8909e7b1ce74ce943cc8f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: b8e1313933af1cd0d6ba4bd52edae88aed20ac10
https://github.com/Perl/perl5/commit/b8e1313933af1cd0d6ba4bd52edae88aed20ac10
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: d4a45efbf810df5feb878ef2e86f125dbd42a0b9
https://github.com/Perl/perl5/commit/d4a45efbf810df5feb878ef2e86f125dbd42a0b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 6db5b0b33f5b333621c20ce4c70c41aa91a26663
https://github.com/Perl/perl5/commit/6db5b0b33f5b333621c20ce4c70c41aa91a26663
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: a6aed8bc03a4728d4dfe625843c18b6d74d4932d
https://github.com/Perl/perl5/commit/a6aed8bc03a4728d4dfe625843c18b6d74d4932d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 08171d1fcea389acd8a8f067b513c7f45a305f95
https://github.com/Perl/perl5/commit/08171d1fcea389acd8a8f067b513c7f45a305f95
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 9d6a4c64eeb6161fcab7d056ed4b02ea201c4d9d
https://github.com/Perl/perl5/commit/9d6a4c64eeb6161fcab7d056ed4b02ea201c4d9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 68112b6a44557e90f60d4a60ce918ef57d4ecd5c
https://github.com/Perl/perl5/commit/68112b6a44557e90f60d4a60ce918ef57d4ecd5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 668685b9a9350e74d7d1ca443c50cbddb4400da9
https://github.com/Perl/perl5/commit/668685b9a9350e74d7d1ca443c50cbddb4400da9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 69c4a84b57e738cdb63f6d53d3640987cb2e0cc9
https://github.com/Perl/perl5/commit/69c4a84b57e738cdb63f6d53d3640987cb2e0cc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 5eb2df20301203c1eb0f25c9c142b82de99f7182
https://github.com/Perl/perl5/commit/5eb2df20301203c1eb0f25c9c142b82de99f7182
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 7f12ee4b44fd324c4c527e61ae3061464cb0737e
https://github.com/Perl/perl5/commit/7f12ee4b44fd324c4c527e61ae3061464cb0737e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: a30578b6c5830615faa2f4f375bb3803fbf36ad8
https://github.com/Perl/perl5/commit/a30578b6c5830615faa2f4f375bb3803fbf36ad8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 13bd8a20d80289ae3ac05454ee27aa97cdd10e6b
https://github.com/Perl/perl5/commit/13bd8a20d80289ae3ac05454ee27aa97cdd10e6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 6c74d6dac4cb783bd254afe8de5828b32f871aa8
https://github.com/Perl/perl5/commit/6c74d6dac4cb783bd254afe8de5828b32f871aa8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: a87f6ddb65ac7dc43d14aa6e11590381871e2a18
https://github.com/Perl/perl5/commit/a87f6ddb65ac7dc43d14aa6e11590381871e2a18
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: b41fdd235b4c478315eede5b14bfb1985a078f81
https://github.com/Perl/perl5/commit/b41fdd235b4c478315eede5b14bfb1985a078f81
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: fd0e04cbd195d3c4366c35f95c2a6626e38cba80
https://github.com/Perl/perl5/commit/fd0e04cbd195d3c4366c35f95c2a6626e38cba80
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 2be384f3285add0a0dcc57060b1d04a95725735d
https://github.com/Perl/perl5/commit/2be384f3285add0a0dcc57060b1d04a95725735d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 211ba8bab238cb6392fd220bce44b9bd1663738b
https://github.com/Perl/perl5/commit/211ba8bab238cb6392fd220bce44b9bd1663738b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: ef8754847c3425bed592e15b70d5a7703a1a97eb
https://github.com/Perl/perl5/commit/ef8754847c3425bed592e15b70d5a7703a1a97eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 6fe215007312dd985d5a0874bec9cf64182ffe98
https://github.com/Perl/perl5/commit/6fe215007312dd985d5a0874bec9cf64182ffe98
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 49557ec039639380f73dec8daabc6acba3c3a803
https://github.com/Perl/perl5/commit/49557ec039639380f73dec8daabc6acba3c3a803
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: b342de36d119a253eb4713244114cce5da96df9a
https://github.com/Perl/perl5/commit/b342de36d119a253eb4713244114cce5da96df9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: a5f4a484fd781ce98802a3a8216bec99e78a18d5
https://github.com/Perl/perl5/commit/a5f4a484fd781ce98802a3a8216bec99e78a18d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 5ee1168fcaa1861ecb8939b6be7f63f07b08ce92
https://github.com/Perl/perl5/commit/5ee1168fcaa1861ecb8939b6be7f63f07b08ce92
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 8722457b0ac8eef56cccbaeec06adac02f9e11df
https://github.com/Perl/perl5/commit/8722457b0ac8eef56cccbaeec06adac02f9e11df
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: c9b586df8b4abcc20c6e8d782365233125e08b72
https://github.com/Perl/perl5/commit/c9b586df8b4abcc20c6e8d782365233125e08b72
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 75cae8d3181237d25329f51a0d87616d893114a9
https://github.com/Perl/perl5/commit/75cae8d3181237d25329f51a0d87616d893114a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: a07741a84c1d9276a4997acd31ba7500c3336b45
https://github.com/Perl/perl5/commit/a07741a84c1d9276a4997acd31ba7500c3336b45
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: d8defddc5801da4c1ae9082ec8afbc989c8a2e05
https://github.com/Perl/perl5/commit/d8defddc5801da4c1ae9082ec8afbc989c8a2e05
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: c5581eea8475c098a11d3765dd50d6dfaa449841
https://github.com/Perl/perl5/commit/c5581eea8475c098a11d3765dd50d6dfaa449841
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 13576bfe08b000b44fd570c2a276da7961d04996
https://github.com/Perl/perl5/commit/13576bfe08b000b44fd570c2a276da7961d04996
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: de4afb4a01664f47d56a2c98cbd70aa57b7f7761
https://github.com/Perl/perl5/commit/de4afb4a01664f47d56a2c98cbd70aa57b7f7761
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 2883d25c95541859ded9123b8385ed5dd49851cc
https://github.com/Perl/perl5/commit/2883d25c95541859ded9123b8385ed5dd49851cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 03fd66fe57baeef60a1a953840cd6f9c81c3d921
https://github.com/Perl/perl5/commit/03fd66fe57baeef60a1a953840cd6f9c81c3d921
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: fbb65b232f0c90538228a0246596582c6983218b
https://github.com/Perl/perl5/commit/fbb65b232f0c90538228a0246596582c6983218b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: c6054d7494f82a9b9b7f287d5c6d50799c0f49e8
https://github.com/Perl/perl5/commit/c6054d7494f82a9b9b7f287d5c6d50799c0f49e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 4e879bd400d2819a6329f5d2400cebc37ec1312c
https://github.com/Perl/perl5/commit/4e879bd400d2819a6329f5d2400cebc37ec1312c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: b928889ff3ac7fb709351a1f06f7c5b2490aaa2f
https://github.com/Perl/perl5/commit/b928889ff3ac7fb709351a1f06f7c5b2490aaa2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: e53b6d838dc48eeba76238045d77ed4f3926efdf
https://github.com/Perl/perl5/commit/e53b6d838dc48eeba76238045d77ed4f3926efdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: fdf974d2f508e5539bf38582b0bbc95662845ff1
https://github.com/Perl/perl5/commit/fdf974d2f508e5539bf38582b0bbc95662845ff1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: bc2674577b290ff3fc26f5cc42bd70ea2c9c1e7c
https://github.com/Perl/perl5/commit/bc2674577b290ff3fc26f5cc42bd70ea2c9c1e7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 808cf5385c68d2ee1987ff41b8cebc0d26657241
https://github.com/Perl/perl5/commit/808cf5385c68d2ee1987ff41b8cebc0d26657241
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 13cbdfbb9239b528a787f1a55276e03604769b39
https://github.com/Perl/perl5/commit/13cbdfbb9239b528a787f1a55276e03604769b39
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 19bdce8f0f5e72025e4fd7df663b2346db20cced
https://github.com/Perl/perl5/commit/19bdce8f0f5e72025e4fd7df663b2346db20cced
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: ec570bb5822a27632f1889e15fd4bc4d41d91b96
https://github.com/Perl/perl5/commit/ec570bb5822a27632f1889e15fd4bc4d41d91b96
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 47c87fe2bb182265da4d964df143779cec76f7c5
https://github.com/Perl/perl5/commit/47c87fe2bb182265da4d964df143779cec76f7c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 120771409b089c2606954dd16ab76d1998c9c31c
https://github.com/Perl/perl5/commit/120771409b089c2606954dd16ab76d1998c9c31c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: dba48bc2a12faceda3b72a8b77ba51aee02b071e
https://github.com/Perl/perl5/commit/dba48bc2a12faceda3b72a8b77ba51aee02b071e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: e6db9e549afad54d0efee420e540ead09cdb86b7
https://github.com/Perl/perl5/commit/e6db9e549afad54d0efee420e540ead09cdb86b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 9d453309687ee23a6a50e2ef0961f547416a2564
https://github.com/Perl/perl5/commit/9d453309687ee23a6a50e2ef0961f547416a2564
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: e51e948cf07efb4a741e6924929070dd8338cb39
https://github.com/Perl/perl5/commit/e51e948cf07efb4a741e6924929070dd8338cb39
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 3ae9bc2c015b629852af37bfc16455e2829e689b
https://github.com/Perl/perl5/commit/3ae9bc2c015b629852af37bfc16455e2829e689b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: d082baae63942150b8bc6ed66ffb83b4d989c48a
https://github.com/Perl/perl5/commit/d082baae63942150b8bc6ed66ffb83b4d989c48a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: cfc2d7a9c08ebb0761ae72a7a3cb5a435cc84bd7
https://github.com/Perl/perl5/commit/cfc2d7a9c08ebb0761ae72a7a3cb5a435cc84bd7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 8b30753cb5b53c666e9dcdc4cda3228befe3b445
https://github.com/Perl/perl5/commit/8b30753cb5b53c666e9dcdc4cda3228befe3b445
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 2b868c8da7283e0de6e673b9f9764ec9d664e1a6
https://github.com/Perl/perl5/commit/2b868c8da7283e0de6e673b9f9764ec9d664e1a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 949288e9a534542b718bc5ef33e796380c51a900
https://github.com/Perl/perl5/commit/949288e9a534542b718bc5ef33e796380c51a900
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 27b3c504e008301417422c410befff8a66e13de0
https://github.com/Perl/perl5/commit/27b3c504e008301417422c410befff8a66e13de0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: e722824fec816d7dfa17bd93c331a6436640a825
https://github.com/Perl/perl5/commit/e722824fec816d7dfa17bd93c331a6436640a825
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 7c6e78312fd3b0454c59560309d7d1750b7350dc
https://github.com/Perl/perl5/commit/7c6e78312fd3b0454c59560309d7d1750b7350dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: c65e614857585c9b8e855ecd1fda333b6d443653
https://github.com/Perl/perl5/commit/c65e614857585c9b8e855ecd1fda333b6d443653
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: ee62e3e9e716abb28b07c51e7f78eba2f7dcf9b8
https://github.com/Perl/perl5/commit/ee62e3e9e716abb28b07c51e7f78eba2f7dcf9b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 980a88c398bdd4d327480ce86f97f6341b46e856
https://github.com/Perl/perl5/commit/980a88c398bdd4d327480ce86f97f6341b46e856
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: d13b5764ba29413fcc92153b4358ce5e01ea2eb5
https://github.com/Perl/perl5/commit/d13b5764ba29413fcc92153b4358ce5e01ea2eb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 672954b1b7e6e3381eee76342c7fae6a64f8880a
https://github.com/Perl/perl5/commit/672954b1b7e6e3381eee76342c7fae6a64f8880a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 68cd9e09a961fef93991829d68076333e21c199e
https://github.com/Perl/perl5/commit/68cd9e09a961fef93991829d68076333e21c199e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 5daff5536dc80df853ab267dc52c398f9e3b3ca0
https://github.com/Perl/perl5/commit/5daff5536dc80df853ab267dc52c398f9e3b3ca0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 53d162313764244ff5d82b28ecc58bafa6276559
https://github.com/Perl/perl5/commit/53d162313764244ff5d82b28ecc58bafa6276559
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 47180130f3b7085d27af705bb3a31774c4e7541f
https://github.com/Perl/perl5/commit/47180130f3b7085d27af705bb3a31774c4e7541f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 5761e16205f477b3bf71882a4eba236fdc6374d6
https://github.com/Perl/perl5/commit/5761e16205f477b3bf71882a4eba236fdc6374d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 4febfccfcee12d14e7a225e6cae874ef49066463
https://github.com/Perl/perl5/commit/4febfccfcee12d14e7a225e6cae874ef49066463
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 9ee83c5e30b117b0a605020179589096aa158245
https://github.com/Perl/perl5/commit/9ee83c5e30b117b0a605020179589096aa158245
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: eca6d11c5319152087342bc33fe30fc7d6af300f
https://github.com/Perl/perl5/commit/eca6d11c5319152087342bc33fe30fc7d6af300f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 25d20c95282dfede4444817dfb3893b9a415e855
https://github.com/Perl/perl5/commit/25d20c95282dfede4444817dfb3893b9a415e855
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 8c026fb6b3d4e58c4513218d00b265d75d71e133
https://github.com/Perl/perl5/commit/8c026fb6b3d4e58c4513218d00b265d75d71e133
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: eb623379d24abd91b89b3499bf59790ddb4f684f
https://github.com/Perl/perl5/commit/eb623379d24abd91b89b3499bf59790ddb4f684f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 1b5d7fa7aea915b77d679dd6b867a33295c744d9
https://github.com/Perl/perl5/commit/1b5d7fa7aea915b77d679dd6b867a33295c744d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: b8386d387a6a11ce449bb1857809f10edb8d1066
https://github.com/Perl/perl5/commit/b8386d387a6a11ce449bb1857809f10edb8d1066
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: f090226b8697c11f2d713b13b93e801aa2a8b6a1
https://github.com/Perl/perl5/commit/f090226b8697c11f2d713b13b93e801aa2a8b6a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: fd98ec7558acf051c9642e9a8a4ea3993992b3d4
https://github.com/Perl/perl5/commit/fd98ec7558acf051c9642e9a8a4ea3993992b3d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: dd3e02446b8b1c8f7df4e8ef51ed9f0caa13c738
https://github.com/Perl/perl5/commit/dd3e02446b8b1c8f7df4e8ef51ed9f0caa13c738
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 27dbb64b89cd9a98c1b10c97e165e734aaab7b67
https://github.com/Perl/perl5/commit/27dbb64b89cd9a98c1b10c97e165e734aaab7b67
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 2bd241f6fddce5517d061d27b9cdca5631b2d0fe
https://github.com/Perl/perl5/commit/2bd241f6fddce5517d061d27b9cdca5631b2d0fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 700803883509e33ef1083b64ebbaa624a8323132
https://github.com/Perl/perl5/commit/700803883509e33ef1083b64ebbaa624a8323132
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: e28c67e18de39be42b49bdb237d6821350122654
https://github.com/Perl/perl5/commit/e28c67e18de39be42b49bdb237d6821350122654
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 0bf001e53eeddf68f2c0698364dedf38a6c88a41
https://github.com/Perl/perl5/commit/0bf001e53eeddf68f2c0698364dedf38a6c88a41
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 154bff5e720aeb137092ce3629ca1bc16d77c34a
https://github.com/Perl/perl5/commit/154bff5e720aeb137092ce3629ca1bc16d77c34a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 5066b5cf0ea53e7a06e1af6d3fa900fc02e5ae22
https://github.com/Perl/perl5/commit/5066b5cf0ea53e7a06e1af6d3fa900fc02e5ae22
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 28a8ce8ab2841cd5716f06e2aaea637cb0f354e7
https://github.com/Perl/perl5/commit/28a8ce8ab2841cd5716f06e2aaea637cb0f354e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 142d1390230ee43cdb35825c5512ffbe3e25265e
https://github.com/Perl/perl5/commit/142d1390230ee43cdb35825c5512ffbe3e25265e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 6139fff07b3f67fc0b4d92caeadcb7374dbabbca
https://github.com/Perl/perl5/commit/6139fff07b3f67fc0b4d92caeadcb7374dbabbca
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: d20c1a01c7ea68580f09e29c1cd2745cee402627
https://github.com/Perl/perl5/commit/d20c1a01c7ea68580f09e29c1cd2745cee402627
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: d4208b486687099fc96af47084def5dba86caf6c
https://github.com/Perl/perl5/commit/d4208b486687099fc96af47084def5dba86caf6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: ca66695cfaa231c117bf6a00e341247dbe912569
https://github.com/Perl/perl5/commit/ca66695cfaa231c117bf6a00e341247dbe912569
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: d7501db6725661e6e46f639e431517cb2162d428
https://github.com/Perl/perl5/commit/d7501db6725661e6e46f639e431517cb2162d428
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 86b074076bc7511fe963226b3f6a0f5b0a08afde
https://github.com/Perl/perl5/commit/86b074076bc7511fe963226b3f6a0f5b0a08afde
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 67e5c297fb5b5b55fe7250c54b88a50c490a6081
https://github.com/Perl/perl5/commit/67e5c297fb5b5b55fe7250c54b88a50c490a6081
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 71ce066758f86d3172722a7fb28191484c24c9a0
https://github.com/Perl/perl5/commit/71ce066758f86d3172722a7fb28191484c24c9a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 9e707fa07c82e933d57eb1253ec4e28f48b0c8f4
https://github.com/Perl/perl5/commit/9e707fa07c82e933d57eb1253ec4e28f48b0c8f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 99ba73e3b49095ecf116ee50d8bb66927ab47077
https://github.com/Perl/perl5/commit/99ba73e3b49095ecf116ee50d8bb66927ab47077
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: af25327fa657572b900d3e01f15dd3da064ded7a
https://github.com/Perl/perl5/commit/af25327fa657572b900d3e01f15dd3da064ded7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: d4c5365e0ad68349dcdec8d7932e28b271eca69f
https://github.com/Perl/perl5/commit/d4c5365e0ad68349dcdec8d7932e28b271eca69f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 3537ea648b2c6f1572f9192ef6dbf84526010e82
https://github.com/Perl/perl5/commit/3537ea648b2c6f1572f9192ef6dbf84526010e82
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 1b4ced874cc36283ee680fd36e888692764e46d6
https://github.com/Perl/perl5/commit/1b4ced874cc36283ee680fd36e888692764e46d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: dae789b677fec8c41da4cf675b168ffe4ed8e636
https://github.com/Perl/perl5/commit/dae789b677fec8c41da4cf675b168ffe4ed8e636
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 4bd0d1a394884eb77590996b7672616157ed54ca
https://github.com/Perl/perl5/commit/4bd0d1a394884eb77590996b7672616157ed54ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 6c7e774159ca71ffbd219b1b2ba0dbd8a4c98afc
https://github.com/Perl/perl5/commit/6c7e774159ca71ffbd219b1b2ba0dbd8a4c98afc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: c7abbfa6e3cee3b9919ab9643e80bda84622ed09
https://github.com/Perl/perl5/commit/c7abbfa6e3cee3b9919ab9643e80bda84622ed09
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 4f6906312a408088fbbd55b7919aee9ad2b2b297
https://github.com/Perl/perl5/commit/4f6906312a408088fbbd55b7919aee9ad2b2b297
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 1a78506d4eabf00431ae9359f2338b494fc0112e
https://github.com/Perl/perl5/commit/1a78506d4eabf00431ae9359f2338b494fc0112e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 633640e787813ebdb39e9cce8bd2a179380d077f
https://github.com/Perl/perl5/commit/633640e787813ebdb39e9cce8bd2a179380d077f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 55f707e93328c5628eb846a80a1a00b24a1c875b
https://github.com/Perl/perl5/commit/55f707e93328c5628eb846a80a1a00b24a1c875b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 12087c84be9f2aefd364b960edad0fafbfc33048
https://github.com/Perl/perl5/commit/12087c84be9f2aefd364b960edad0fafbfc33048
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 4feef9a07702c6a364b2feacd172201521cfa6aa
https://github.com/Perl/perl5/commit/4feef9a07702c6a364b2feacd172201521cfa6aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: b8a32119538728c3f83ab558a164040d2c84c689
https://github.com/Perl/perl5/commit/b8a32119538728c3f83ab558a164040d2c84c689
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 3b43ce038eafb62e1c100c688a562dd24e125bb0
https://github.com/Perl/perl5/commit/3b43ce038eafb62e1c100c688a562dd24e125bb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 6332bb60075aaf847ed4b7c288a92d303cec6390
https://github.com/Perl/perl5/commit/6332bb60075aaf847ed4b7c288a92d303cec6390
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 5aa0f0f3ca30a542f34f78f101740f5c7ae6a86f
https://github.com/Perl/perl5/commit/5aa0f0f3ca30a542f34f78f101740f5c7ae6a86f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: a618d0415d4fb895c7df58825c162ea09f692d4c
https://github.com/Perl/perl5/commit/a618d0415d4fb895c7df58825c162ea09f692d4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: fb9b68be9c36fa605b8497c9fad0ddd219ca77be
https://github.com/Perl/perl5/commit/fb9b68be9c36fa605b8497c9fad0ddd219ca77be
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 72379cc03da0d66e63d8b0e1e0449d9749e84486
https://github.com/Perl/perl5/commit/72379cc03da0d66e63d8b0e1e0449d9749e84486
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 9144640e66a8fcb5b0f9556203d3cfe0f65c3e6f
https://github.com/Perl/perl5/commit/9144640e66a8fcb5b0f9556203d3cfe0f65c3e6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 21dc82711f51c4479b311dae114bbb5f2293fa57
https://github.com/Perl/perl5/commit/21dc82711f51c4479b311dae114bbb5f2293fa57
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: e1ec52090acb8612be83f2eae6398754de3f760f
https://github.com/Perl/perl5/commit/e1ec52090acb8612be83f2eae6398754de3f760f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 58e423ea7d3869156199af28722aa070b10f7b35
https://github.com/Perl/perl5/commit/58e423ea7d3869156199af28722aa070b10f7b35
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: f746b95b1147a8487da8ea71befe6c3b7eacf78a
https://github.com/Perl/perl5/commit/f746b95b1147a8487da8ea71befe6c3b7eacf78a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 651a595ddf3942b5c825f0f122607e109e7b83ab
https://github.com/Perl/perl5/commit/651a595ddf3942b5c825f0f122607e109e7b83ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: c1c99af1b3f11746389e1c524576a0bed5ffce94
https://github.com/Perl/perl5/commit/c1c99af1b3f11746389e1c524576a0bed5ffce94
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 91ba0659a0ef4ec59d8e7dde4f5ed20cb8687a7e
https://github.com/Perl/perl5/commit/91ba0659a0ef4ec59d8e7dde4f5ed20cb8687a7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 7c8803dbaa18fd41d3907996775507529e62c69d
https://github.com/Perl/perl5/commit/7c8803dbaa18fd41d3907996775507529e62c69d
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: ad04b7fccdbedca839ea43d05c59a25ce72afabc
https://github.com/Perl/perl5/commit/ad04b7fccdbedca839ea43d05c59a25ce72afabc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 423d326e26eb274d0912433206ddba8d7e9ec3eb
https://github.com/Perl/perl5/commit/423d326e26eb274d0912433206ddba8d7e9ec3eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: c215158e3f869ac93206e2a6362e729a3f441f16
https://github.com/Perl/perl5/commit/c215158e3f869ac93206e2a6362e729a3f441f16
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: e3ba9b55dc8175732a5bff83867d733e34ea6648
https://github.com/Perl/perl5/commit/e3ba9b55dc8175732a5bff83867d733e34ea6648
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 4d3fa7315a0473248b095090f50669497291f9dc
https://github.com/Perl/perl5/commit/4d3fa7315a0473248b095090f50669497291f9dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: bec917fa7f305c3cece615a35077dea3bc99ff34
https://github.com/Perl/perl5/commit/bec917fa7f305c3cece615a35077dea3bc99ff34
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 2289902d17501888e474bc73df2530396c3d9e54
https://github.com/Perl/perl5/commit/2289902d17501888e474bc73df2530396c3d9e54
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: eb0fda9cdefeedb344bcda7cba8390de3f626a67
https://github.com/Perl/perl5/commit/eb0fda9cdefeedb344bcda7cba8390de3f626a67
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 15e14af0a9fd631b465ec9d1b2276f32b061eb72
https://github.com/Perl/perl5/commit/15e14af0a9fd631b465ec9d1b2276f32b061eb72
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: f469372039603dbd398f2d1e7b7cbe3cd73716b8
https://github.com/Perl/perl5/commit/f469372039603dbd398f2d1e7b7cbe3cd73716b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: e820163ebca767748b2866f66df0f974d7d8a612
https://github.com/Perl/perl5/commit/e820163ebca767748b2866f66df0f974d7d8a612
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 09e6dc0e71ab483eeaf68cdb7434bfe89c00b93a
https://github.com/Perl/perl5/commit/09e6dc0e71ab483eeaf68cdb7434bfe89c00b93a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 901312319bb88920fe72ce81675fd7e4118bcd98
https://github.com/Perl/perl5/commit/901312319bb88920fe72ce81675fd7e4118bcd98
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: aef4666d12048a1e5d228656150a59e590a718a9
https://github.com/Perl/perl5/commit/aef4666d12048a1e5d228656150a59e590a718a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: a8665ceff28daffd59626b714e8c15c803c96ec6
https://github.com/Perl/perl5/commit/a8665ceff28daffd59626b714e8c15c803c96ec6
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 9b4c468f56213ad96839432817d9d79f43227679
https://github.com/Perl/perl5/commit/9b4c468f56213ad96839432817d9d79f43227679
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: e5ac5f27d87bb971ed7638c6338ac4a27c3414b4
https://github.com/Perl/perl5/commit/e5ac5f27d87bb971ed7638c6338ac4a27c3414b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 9a04d3cc61d9adfeb90a4e1ed0f17e80251e3688
https://github.com/Perl/perl5/commit/9a04d3cc61d9adfeb90a4e1ed0f17e80251e3688
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: fdc8b26c04aae90a598b984e9b5caf6c98c70704
https://github.com/Perl/perl5/commit/fdc8b26c04aae90a598b984e9b5caf6c98c70704
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 096c655a890020a979c103e5e50fa8fab33a4350
https://github.com/Perl/perl5/commit/096c655a890020a979c103e5e50fa8fab33a4350
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 84ad6d9e9573f4215d24e2b874396819f6bee8e1
https://github.com/Perl/perl5/commit/84ad6d9e9573f4215d24e2b874396819f6bee8e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: ad5600c6123419357b57309a945fb8ff44f6ac6f
https://github.com/Perl/perl5/commit/ad5600c6123419357b57309a945fb8ff44f6ac6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 92170119d9a39a4c9e512a8e95352fb230cc97ec
https://github.com/Perl/perl5/commit/92170119d9a39a4c9e512a8e95352fb230cc97ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: e4c94ab5743587cff6c4688cb0c6986ecf43eca9
https://github.com/Perl/perl5/commit/e4c94ab5743587cff6c4688cb0c6986ecf43eca9
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 182ae5a9a7e470f8a362e6363ff089e5641a2ab1
https://github.com/Perl/perl5/commit/182ae5a9a7e470f8a362e6363ff089e5641a2ab1
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 7fb3cfebc61d2e6591f15e335718351bcc5c9169
https://github.com/Perl/perl5/commit/7fb3cfebc61d2e6591f15e335718351bcc5c9169
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: e401a3d048deb6665ce5617184b9b066e328321a
https://github.com/Perl/perl5/commit/e401a3d048deb6665ce5617184b9b066e328321a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 464d8131885a784841bf82e925a5526efe76f0ff
https://github.com/Perl/perl5/commit/464d8131885a784841bf82e925a5526efe76f0ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 89ab5852986fa06991e4aef7cb8d8aca76a8e888
https://github.com/Perl/perl5/commit/89ab5852986fa06991e4aef7cb8d8aca76a8e888
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 05a72c98609ebf5b22719f6a6bd5d615dc5d3457
https://github.com/Perl/perl5/commit/05a72c98609ebf5b22719f6a6bd5d615dc5d3457
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 6e37f64c3134cc04caeb1b30e94ce2ec627ae38b
https://github.com/Perl/perl5/commit/6e37f64c3134cc04caeb1b30e94ce2ec627ae38b
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 97a708c84dc46789d66c32a6b197387bdec2c575
https://github.com/Perl/perl5/commit/97a708c84dc46789d66c32a6b197387bdec2c575
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 6cfaaffc6d173f583fa70b064972411fc2e246ba
https://github.com/Perl/perl5/commit/6cfaaffc6d173f583fa70b064972411fc2e246ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 329ce61832ea6484ba123c63e502f649039eb509
https://github.com/Perl/perl5/commit/329ce61832ea6484ba123c63e502f649039eb509
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: b79c31fb9122d89f7c20490389fc5f7ee836abf0
https://github.com/Perl/perl5/commit/b79c31fb9122d89f7c20490389fc5f7ee836abf0
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 3e2b77f04503ceca468e009d254994bd180f91d2
https://github.com/Perl/perl5/commit/3e2b77f04503ceca468e009d254994bd180f91d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: be0459740ea300ddf31696c850132b9a5f240ee4
https://github.com/Perl/perl5/commit/be0459740ea300ddf31696c850132b9a5f240ee4
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 7a3f77b839095a5207764fb26d5392b12ceb782f
https://github.com/Perl/perl5/commit/7a3f77b839095a5207764fb26d5392b12ceb782f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 5afc390801d64f56647c531539ed4d5b27451027
https://github.com/Perl/perl5/commit/5afc390801d64f56647c531539ed4d5b27451027
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 5ec70f665e24ff6e12bd6b6039c499a2257e2d34
https://github.com/Perl/perl5/commit/5ec70f665e24ff6e12bd6b6039c499a2257e2d34
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 2da97f7df7a21d30fbe9c2392d9596fc742744c3
https://github.com/Perl/perl5/commit/2da97f7df7a21d30fbe9c2392d9596fc742744c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 344b9a852f408b2a63b5748cec95534991abc790
https://github.com/Perl/perl5/commit/344b9a852f408b2a63b5748cec95534991abc790
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 20b1ebedf251098c07dd7dbff1539f061eafc148
https://github.com/Perl/perl5/commit/20b1ebedf251098c07dd7dbff1539f061eafc148
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: e78e97420a17257ae183f3b883db467c9f0f3374
https://github.com/Perl/perl5/commit/e78e97420a17257ae183f3b883db467c9f0f3374
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 6bfdf6e73286ca32fe49ba7c6f903ead396f837c
https://github.com/Perl/perl5/commit/6bfdf6e73286ca32fe49ba7c6f903ead396f837c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 4657971b2de9441396b1a10fcb6764af17dd791c
https://github.com/Perl/perl5/commit/4657971b2de9441396b1a10fcb6764af17dd791c
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 53d6745024944e80af0f9f6a48e0b5d492a65a5f
https://github.com/Perl/perl5/commit/53d6745024944e80af0f9f6a48e0b5d492a65a5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: c11a40ffda40ec09ef41245d7e3f1f1d77245376
https://github.com/Perl/perl5/commit/c11a40ffda40ec09ef41245d7e3f1f1d77245376
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: b361461689fc598d4fd24d2a3aeb99b89d90d859
https://github.com/Perl/perl5/commit/b361461689fc598d4fd24d2a3aeb99b89d90d859
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: d9fd9a9c5e1896e79b8c5dd3c16f494a63521797
https://github.com/Perl/perl5/commit/d9fd9a9c5e1896e79b8c5dd3c16f494a63521797
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: ff88a42a33b51073fc8b2734c2b34d1654ff0a24
https://github.com/Perl/perl5/commit/ff88a42a33b51073fc8b2734c2b34d1654ff0a24
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_COLLATION handled the possibility of
being passed a NULL locale name. But we're not changing things unless
we have a new locale, and know its name.
Commit: 6b4ae576d02537038789b31271733e7a3074336e
https://github.com/Perl/perl5/commit/6b4ae576d02537038789b31271733e7a3074336e
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 155f47d05562f71b29c2d98bd8a0761abb1a2638
https://github.com/Perl/perl5/commit/155f47d05562f71b29c2d98bd8a0761abb1a2638
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 8bf79151a70201bcf85c1071e7f9af3acc5f8461
https://github.com/Perl/perl5/commit/8bf79151a70201bcf85c1071e7f9af3acc5f8461
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 19063afda77a8ad645f5ed1c7fe96ff2c4bf949a
https://github.com/Perl/perl5/commit/19063afda77a8ad645f5ed1c7fe96ff2c4bf949a
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
Log Message:
-----------
f
Commit: 4fbd47c4f8399f06008807f1e082a8702a7d6659
https://github.com/Perl/perl5/commit/4fbd47c4f8399f06008807f1e082a8702a7d6659
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Add missing SKIP: label
Commit: 0cada7cfdced81a4f4e1811bd53babad5b5b2983
https://github.com/Perl/perl5/commit/0cada7cfdced81a4f4e1811bd53babad5b5b2983
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Fix tests
This was misleadingly outputting an undef value, instead of just saying
it's undef
Commit: dbdd0e1d9309836445776829e34b66a33cd90920
https://github.com/Perl/perl5/commit/dbdd0e1d9309836445776829e34b66a33cd90920
Author: Karl Williamson <[email protected]>
Date: 2021-04-03 (Sat, 03 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M ext/XS-APItest/t/locale.t
M handy.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M proto.h
M t/loc_tools.pl
Log Message:
-----------
more7
Compare: https://github.com/Perl/perl5/compare/8bfe8a74a90e...dbdd0e1d9309
