Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 4980555903da634e443177a22896ae07872e7504
https://github.com/Perl/perl5/commit/4980555903da634e443177a22896ae07872e7504
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 18345f332a93165e3113209600a3ee2bc84d144d
https://github.com/Perl/perl5/commit/18345f332a93165e3113209600a3ee2bc84d144d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: a8236f8f87a6f751f7e1d9af29d4686f66348c96
https://github.com/Perl/perl5/commit/a8236f8f87a6f751f7e1d9af29d4686f66348c96
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 13aef402325e7d313bf255b8862722c2e8e2cd6f
https://github.com/Perl/perl5/commit/13aef402325e7d313bf255b8862722c2e8e2cd6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 212c8ea8e3d2175c0b87b14707493d508e25abdf
https://github.com/Perl/perl5/commit/212c8ea8e3d2175c0b87b14707493d508e25abdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: e3c2dc55f9118e20288f6463a0151a6887abf2a3
https://github.com/Perl/perl5/commit/e3c2dc55f9118e20288f6463a0151a6887abf2a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: bc0773de0969432db47763a73fc0cd534a1eecb8
https://github.com/Perl/perl5/commit/bc0773de0969432db47763a73fc0cd534a1eecb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 5593aa60298f1697478b45465691e37a343c3e82
https://github.com/Perl/perl5/commit/5593aa60298f1697478b45465691e37a343c3e82
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 8cbaedaffbcc547869d326b2af311441089f4ab0
https://github.com/Perl/perl5/commit/8cbaedaffbcc547869d326b2af311441089f4ab0
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: fae7a39ce26a32a5ed6fdce0aff96df400d0ca49
https://github.com/Perl/perl5/commit/fae7a39ce26a32a5ed6fdce0aff96df400d0ca49
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: b190a7789692758e9e35c35cafdac653944c9bb1
https://github.com/Perl/perl5/commit/b190a7789692758e9e35c35cafdac653944c9bb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 46b790ac0abe966635db1d957004702c071175f0
https://github.com/Perl/perl5/commit/46b790ac0abe966635db1d957004702c071175f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: d5f4887eae6d296db3145345397d63e0ca88dba7
https://github.com/Perl/perl5/commit/d5f4887eae6d296db3145345397d63e0ca88dba7
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: d5100dbd17b143ba79ecebb7455fd45d7425fda4
https://github.com/Perl/perl5/commit/d5100dbd17b143ba79ecebb7455fd45d7425fda4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 7d9fbc365e601dad016609e018fac1c54ae43dd9
https://github.com/Perl/perl5/commit/7d9fbc365e601dad016609e018fac1c54ae43dd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 1525e8382d205df50440fbbd82f27933daa67d13
https://github.com/Perl/perl5/commit/1525e8382d205df50440fbbd82f27933daa67d13
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: e182f203759d0ba4c9c037544bae7375888c1542
https://github.com/Perl/perl5/commit/e182f203759d0ba4c9c037544bae7375888c1542
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 1e5200dca23f46b38d42c33e316f7ef48de3b238
https://github.com/Perl/perl5/commit/1e5200dca23f46b38d42c33e316f7ef48de3b238
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 720adfe1ed98d3b78c8bd64a2a77038ed603de54
https://github.com/Perl/perl5/commit/720adfe1ed98d3b78c8bd64a2a77038ed603de54
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 40401f0f727582185a0e80f9e868242083898009
https://github.com/Perl/perl5/commit/40401f0f727582185a0e80f9e868242083898009
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 025682ae8893bdae71d1024f2f10b6b0b416d3fe
https://github.com/Perl/perl5/commit/025682ae8893bdae71d1024f2f10b6b0b416d3fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: b624ef4e45d499027f03aed050cd3715795f13c7
https://github.com/Perl/perl5/commit/b624ef4e45d499027f03aed050cd3715795f13c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 51b03bc7c90c4ef2abe540b3b2eea18f958eeefa
https://github.com/Perl/perl5/commit/51b03bc7c90c4ef2abe540b3b2eea18f958eeefa
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 8e7beef402324b65d55030a4ab5f32f45019690e
https://github.com/Perl/perl5/commit/8e7beef402324b65d55030a4ab5f32f45019690e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 774ade5150c26caae87f4549467cb4252fcbebe4
https://github.com/Perl/perl5/commit/774ade5150c26caae87f4549467cb4252fcbebe4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: ded37c3745f0ff755b57aa1a9759f17b6a0c0363
https://github.com/Perl/perl5/commit/ded37c3745f0ff755b57aa1a9759f17b6a0c0363
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 290e606cc851ad78a9fa8d3d1909a20b8f656a11
https://github.com/Perl/perl5/commit/290e606cc851ad78a9fa8d3d1909a20b8f656a11
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 3231e49db7ad6679ff97d11bcf033588e0ce5c12
https://github.com/Perl/perl5/commit/3231e49db7ad6679ff97d11bcf033588e0ce5c12
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 48f3d1cc28408f29733b84e5da4dfa1d9b9f320f
https://github.com/Perl/perl5/commit/48f3d1cc28408f29733b84e5da4dfa1d9b9f320f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: fe5d3c93adc553a436f92ecc82ec0138789d977a
https://github.com/Perl/perl5/commit/fe5d3c93adc553a436f92ecc82ec0138789d977a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 43e4d17aa42dd944c833eb2274e32aad9607fc3d
https://github.com/Perl/perl5/commit/43e4d17aa42dd944c833eb2274e32aad9607fc3d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: ce4bd2517ac8cabba8394ddf0a8099414ea8a01a
https://github.com/Perl/perl5/commit/ce4bd2517ac8cabba8394ddf0a8099414ea8a01a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: f9a7a8364cec31e453802e7cc48ba7c6af57109f
https://github.com/Perl/perl5/commit/f9a7a8364cec31e453802e7cc48ba7c6af57109f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 01442d50e0b0d155cb37249eb376f0c2f41375db
https://github.com/Perl/perl5/commit/01442d50e0b0d155cb37249eb376f0c2f41375db
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: d10685de5f4784ca2c828613dea21ca3b9ab5987
https://github.com/Perl/perl5/commit/d10685de5f4784ca2c828613dea21ca3b9ab5987
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 1f80204419fabd617f7e0154ffe6533744033791
https://github.com/Perl/perl5/commit/1f80204419fabd617f7e0154ffe6533744033791
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: bbad752c4c3befbd8cf86761ecf7f43d73e4d5e6
https://github.com/Perl/perl5/commit/bbad752c4c3befbd8cf86761ecf7f43d73e4d5e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 280e9744a66ec10cc02655b78c77b8d0c6b9140c
https://github.com/Perl/perl5/commit/280e9744a66ec10cc02655b78c77b8d0c6b9140c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 24e0c1972df584f1cc1bbb784ee011a4c511c32a
https://github.com/Perl/perl5/commit/24e0c1972df584f1cc1bbb784ee011a4c511c32a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: ddf8deb1737b97e524a0b6ac52731f34746ff5e5
https://github.com/Perl/perl5/commit/ddf8deb1737b97e524a0b6ac52731f34746ff5e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 3987dfe0f09d64ad84f4f7f95cd1f52db104ddd5
https://github.com/Perl/perl5/commit/3987dfe0f09d64ad84f4f7f95cd1f52db104ddd5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: b2bfd03c115f6a55307d3a174052f0665359f825
https://github.com/Perl/perl5/commit/b2bfd03c115f6a55307d3a174052f0665359f825
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: acd383aa48c4f463335a4119b9e7e47fbb192f6d
https://github.com/Perl/perl5/commit/acd383aa48c4f463335a4119b9e7e47fbb192f6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: a2d95594802723e0c5dfad40195e7646563b6b00
https://github.com/Perl/perl5/commit/a2d95594802723e0c5dfad40195e7646563b6b00
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 0723f060c1673b386ed983025e032674021f8af3
https://github.com/Perl/perl5/commit/0723f060c1673b386ed983025e032674021f8af3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 39843020bbb04718eac27a710b211f99687988f3
https://github.com/Perl/perl5/commit/39843020bbb04718eac27a710b211f99687988f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 427c04ac78201aa4152da7ea52d60f770058af0d
https://github.com/Perl/perl5/commit/427c04ac78201aa4152da7ea52d60f770058af0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 62ef2ce79cb8eaa857ce4ccad75e979389a3d4a3
https://github.com/Perl/perl5/commit/62ef2ce79cb8eaa857ce4ccad75e979389a3d4a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 0101c099527c761233a24958761893012eb16b8e
https://github.com/Perl/perl5/commit/0101c099527c761233a24958761893012eb16b8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 6458296a38946c715f95ea30a25972f9e8761cc5
https://github.com/Perl/perl5/commit/6458296a38946c715f95ea30a25972f9e8761cc5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 0e4f657677be72dbc4a2e37106df9164258dcf97
https://github.com/Perl/perl5/commit/0e4f657677be72dbc4a2e37106df9164258dcf97
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 9288d959e46c4a6152d76fd0b606d24b8e37a1cb
https://github.com/Perl/perl5/commit/9288d959e46c4a6152d76fd0b606d24b8e37a1cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 370829c9f7bdf7f180deacca119e28b00fce9a1a
https://github.com/Perl/perl5/commit/370829c9f7bdf7f180deacca119e28b00fce9a1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: cd4e8166634958f4b41ed2c1e365955f8f689d52
https://github.com/Perl/perl5/commit/cd4e8166634958f4b41ed2c1e365955f8f689d52
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: a203a53cbb54deb1369df99a89b7950b7a54963f
https://github.com/Perl/perl5/commit/a203a53cbb54deb1369df99a89b7950b7a54963f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 9024a445dd49092794b34b9e9d287eebff12566f
https://github.com/Perl/perl5/commit/9024a445dd49092794b34b9e9d287eebff12566f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: c3cffacfc5ef952592df5962254d02bfbfb5cd43
https://github.com/Perl/perl5/commit/c3cffacfc5ef952592df5962254d02bfbfb5cd43
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 54a1b46a9a6a39e23bf44f62bbd4dcbbb09679c4
https://github.com/Perl/perl5/commit/54a1b46a9a6a39e23bf44f62bbd4dcbbb09679c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 3857bd920f1577b562f0b61920c5155cc2b5a4a6
https://github.com/Perl/perl5/commit/3857bd920f1577b562f0b61920c5155cc2b5a4a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 4f907453386f1b726b9ac304d5525bc248d04290
https://github.com/Perl/perl5/commit/4f907453386f1b726b9ac304d5525bc248d04290
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: b04e3391eff9331e0426e4265bf2b51b99933fa9
https://github.com/Perl/perl5/commit/b04e3391eff9331e0426e4265bf2b51b99933fa9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 3c7004274455fa76e008d38beb5e7324f7809a08
https://github.com/Perl/perl5/commit/3c7004274455fa76e008d38beb5e7324f7809a08
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 38d62a1ef7a6ff0b5ba555e7630e7c8e45b5420f
https://github.com/Perl/perl5/commit/38d62a1ef7a6ff0b5ba555e7630e7c8e45b5420f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: a0b57852c2aad91ad47e3ec7c2d39430afe34c8d
https://github.com/Perl/perl5/commit/a0b57852c2aad91ad47e3ec7c2d39430afe34c8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 2a7024a048737ded531a02f69feeea85f2e38590
https://github.com/Perl/perl5/commit/2a7024a048737ded531a02f69feeea85f2e38590
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 0b1e3df1798010c9af6567e64a615242bc318d22
https://github.com/Perl/perl5/commit/0b1e3df1798010c9af6567e64a615242bc318d22
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 98062b1a902f7a4e73f468a0c736606412e82fc4
https://github.com/Perl/perl5/commit/98062b1a902f7a4e73f468a0c736606412e82fc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 50a6248099bab219c0ca506e95acfcac4b6f1387
https://github.com/Perl/perl5/commit/50a6248099bab219c0ca506e95acfcac4b6f1387
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: add2ec4e1f2df55b465f1e1c716e4b7276c7c602
https://github.com/Perl/perl5/commit/add2ec4e1f2df55b465f1e1c716e4b7276c7c602
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 4967a8c6e94a2caf64b9c78a826d518e1fd78377
https://github.com/Perl/perl5/commit/4967a8c6e94a2caf64b9c78a826d518e1fd78377
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 644b8980101bb43c7e72ed1dac2ef82ba299a3fa
https://github.com/Perl/perl5/commit/644b8980101bb43c7e72ed1dac2ef82ba299a3fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: f2e396378876bba1eb360f1487f99a8e33a9af61
https://github.com/Perl/perl5/commit/f2e396378876bba1eb360f1487f99a8e33a9af61
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 04fb322ee8bcde4daa1cfc8bc284e11effa94ae1
https://github.com/Perl/perl5/commit/04fb322ee8bcde4daa1cfc8bc284e11effa94ae1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: c9798f3565266118e4022d2a2b969c39dc348c9b
https://github.com/Perl/perl5/commit/c9798f3565266118e4022d2a2b969c39dc348c9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: bdc8a9d1d2d30cfeffebdb43a9b4ffb48a82c96c
https://github.com/Perl/perl5/commit/bdc8a9d1d2d30cfeffebdb43a9b4ffb48a82c96c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: f8ec57298faa8c714aea4a31d887071143e734a5
https://github.com/Perl/perl5/commit/f8ec57298faa8c714aea4a31d887071143e734a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: eccf56d02a8c93b112210d0465beff42350f0b03
https://github.com/Perl/perl5/commit/eccf56d02a8c93b112210d0465beff42350f0b03
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: b8202d3a401c1ae7f8c1b71cb2f9c5befd736e78
https://github.com/Perl/perl5/commit/b8202d3a401c1ae7f8c1b71cb2f9c5befd736e78
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 9fbe0ebfaab1f49d8331f6d842055c0311c6215e
https://github.com/Perl/perl5/commit/9fbe0ebfaab1f49d8331f6d842055c0311c6215e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 84809af2606c2804c6714d510a84d67eacb25146
https://github.com/Perl/perl5/commit/84809af2606c2804c6714d510a84d67eacb25146
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 1ec982980923048d967b15685274f5cce195ac16
https://github.com/Perl/perl5/commit/1ec982980923048d967b15685274f5cce195ac16
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 3d0ea256e01b30b7cdbdb970639e7ad2e44e1167
https://github.com/Perl/perl5/commit/3d0ea256e01b30b7cdbdb970639e7ad2e44e1167
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 4e1c5fc2ab4ee4a5bda4dc3a792682e090ed204a
https://github.com/Perl/perl5/commit/4e1c5fc2ab4ee4a5bda4dc3a792682e090ed204a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: e0e03e5da55b72dbb5a043903845477478b8d3de
https://github.com/Perl/perl5/commit/e0e03e5da55b72dbb5a043903845477478b8d3de
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: fbcb3918f4c14608dcff939c44f15985d77644fd
https://github.com/Perl/perl5/commit/fbcb3918f4c14608dcff939c44f15985d77644fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: ebe2b61b9205591efeb3046b98634d8e88e2ac9f
https://github.com/Perl/perl5/commit/ebe2b61b9205591efeb3046b98634d8e88e2ac9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: a669ce2298b02a02edc2a14868fb1fb849a45d91
https://github.com/Perl/perl5/commit/a669ce2298b02a02edc2a14868fb1fb849a45d91
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 8d878f1f242f9ec51d3616fa63c4d0464b343d83
https://github.com/Perl/perl5/commit/8d878f1f242f9ec51d3616fa63c4d0464b343d83
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 19ed74fedf25c8d7ad01b2ffe162921f236a3cf0
https://github.com/Perl/perl5/commit/19ed74fedf25c8d7ad01b2ffe162921f236a3cf0
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: e3dc0b28d073766884c9a71cd9ce99d42569c0c3
https://github.com/Perl/perl5/commit/e3dc0b28d073766884c9a71cd9ce99d42569c0c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 4ce2cec77cdd4e9e2dfede0dce2dee97fcf9e564
https://github.com/Perl/perl5/commit/4ce2cec77cdd4e9e2dfede0dce2dee97fcf9e564
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: bed5f37d40b8cb533394e6ae5634d8b604f096e2
https://github.com/Perl/perl5/commit/bed5f37d40b8cb533394e6ae5634d8b604f096e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: d630425c0351c9d03c519bde9009334eb6fdfefd
https://github.com/Perl/perl5/commit/d630425c0351c9d03c519bde9009334eb6fdfefd
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 06a0188b57b7178bce7927fe54a53b363585ec9c
https://github.com/Perl/perl5/commit/06a0188b57b7178bce7927fe54a53b363585ec9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 66d47a214ba9df41ae1ce6ffc15b1fb3f627a263
https://github.com/Perl/perl5/commit/66d47a214ba9df41ae1ce6ffc15b1fb3f627a263
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 978c89c05b5ad3784e1fb0c102656a49503e2ccc
https://github.com/Perl/perl5/commit/978c89c05b5ad3784e1fb0c102656a49503e2ccc
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: acb9218c264a297012a2a092daa762388041027c
https://github.com/Perl/perl5/commit/acb9218c264a297012a2a092daa762388041027c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: d981cb601050b7d5bee76a2c918c66bc8aa366bb
https://github.com/Perl/perl5/commit/d981cb601050b7d5bee76a2c918c66bc8aa366bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: ecb7e7fc5ea468cf6209497e1e198a328ec443f0
https://github.com/Perl/perl5/commit/ecb7e7fc5ea468cf6209497e1e198a328ec443f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 46d67836f0ec25c9aa5e0563b612a991d8c6d163
https://github.com/Perl/perl5/commit/46d67836f0ec25c9aa5e0563b612a991d8c6d163
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 827ea8bee70477b6c3b139e5a0b89f8f5bd8ba2f
https://github.com/Perl/perl5/commit/827ea8bee70477b6c3b139e5a0b89f8f5bd8ba2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 22d35d5bcfc67feb5aa5f0c9c529beed2e600375
https://github.com/Perl/perl5/commit/22d35d5bcfc67feb5aa5f0c9c529beed2e600375
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: cb50e4037dffd500def1be2a537198277b47c981
https://github.com/Perl/perl5/commit/cb50e4037dffd500def1be2a537198277b47c981
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 2dc6d4f0d36bb89e1e7af03806aa88b4b1a980fd
https://github.com/Perl/perl5/commit/2dc6d4f0d36bb89e1e7af03806aa88b4b1a980fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 688098b5d38600f84ef670989dee8709bdecf6c8
https://github.com/Perl/perl5/commit/688098b5d38600f84ef670989dee8709bdecf6c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 69744be467d3bba2c09b38322fca3a422a231c11
https://github.com/Perl/perl5/commit/69744be467d3bba2c09b38322fca3a422a231c11
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 69bf28551eef9e1d6704c05f7971bef082d6c04d
https://github.com/Perl/perl5/commit/69bf28551eef9e1d6704c05f7971bef082d6c04d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: ef25fb42d85fb55b1ae755482459b062fec903c3
https://github.com/Perl/perl5/commit/ef25fb42d85fb55b1ae755482459b062fec903c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 93e43a233d6aac2952db8c8c92d8f6f5fd2792e8
https://github.com/Perl/perl5/commit/93e43a233d6aac2952db8c8c92d8f6f5fd2792e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: f4b70b41f0e975f040e8bd98467c48e654de162a
https://github.com/Perl/perl5/commit/f4b70b41f0e975f040e8bd98467c48e654de162a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: be870f394245868d1394fa6fdfb12bfc585f183d
https://github.com/Perl/perl5/commit/be870f394245868d1394fa6fdfb12bfc585f183d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 3989c6ef0bf9d105bac30dc279eae273e4507162
https://github.com/Perl/perl5/commit/3989c6ef0bf9d105bac30dc279eae273e4507162
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 4d393ed1ce689ac271b8127bf7f455605a79578f
https://github.com/Perl/perl5/commit/4d393ed1ce689ac271b8127bf7f455605a79578f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 8cdae34112b5ec2761eb12728022d972b8c3ef1c
https://github.com/Perl/perl5/commit/8cdae34112b5ec2761eb12728022d972b8c3ef1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 9fd0083e40d6b90543f82289073d33477a21ea14
https://github.com/Perl/perl5/commit/9fd0083e40d6b90543f82289073d33477a21ea14
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 398a15784c73626069c7d90b489d40c87786f188
https://github.com/Perl/perl5/commit/398a15784c73626069c7d90b489d40c87786f188
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 1b6facce252e1524608fd15520e4d3a90c4522ec
https://github.com/Perl/perl5/commit/1b6facce252e1524608fd15520e4d3a90c4522ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 9224916d727c180eb53c856f81d9505585a47131
https://github.com/Perl/perl5/commit/9224916d727c180eb53c856f81d9505585a47131
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 71cfffc073cb336e2ea95f4c392f038abf35dd29
https://github.com/Perl/perl5/commit/71cfffc073cb336e2ea95f4c392f038abf35dd29
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 4a8a3155a82138a22b71b2a91bdc519b6916797b
https://github.com/Perl/perl5/commit/4a8a3155a82138a22b71b2a91bdc519b6916797b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: ce03a060db87195a9ff0b4cbf6979eac7292119e
https://github.com/Perl/perl5/commit/ce03a060db87195a9ff0b4cbf6979eac7292119e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: c4e2471cde79676ba04ce4fa8466f3dfd49a584f
https://github.com/Perl/perl5/commit/c4e2471cde79676ba04ce4fa8466f3dfd49a584f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: f43f43ebca2f45084cec54d523fa591981cae87e
https://github.com/Perl/perl5/commit/f43f43ebca2f45084cec54d523fa591981cae87e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 72a52f127a688cf27005701a598d60aa1bdc3ca9
https://github.com/Perl/perl5/commit/72a52f127a688cf27005701a598d60aa1bdc3ca9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: f74eea5bebb979607d7867cad9e803da88b39185
https://github.com/Perl/perl5/commit/f74eea5bebb979607d7867cad9e803da88b39185
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 4e0f4eb0f34d962d8b7ba3caa44690cf6a5469a7
https://github.com/Perl/perl5/commit/4e0f4eb0f34d962d8b7ba3caa44690cf6a5469a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 0d3bb9c75aeb316c1744493b30d71cc7947aecfe
https://github.com/Perl/perl5/commit/0d3bb9c75aeb316c1744493b30d71cc7947aecfe
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 16441780693f5cbdc2e1cdd972905e2504ac0615
https://github.com/Perl/perl5/commit/16441780693f5cbdc2e1cdd972905e2504ac0615
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 85f7db8a3d39415c8f52295e201034a33a337729
https://github.com/Perl/perl5/commit/85f7db8a3d39415c8f52295e201034a33a337729
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 6ef6fa84b7495ae18300ed4a61e92b448af0c25f
https://github.com/Perl/perl5/commit/6ef6fa84b7495ae18300ed4a61e92b448af0c25f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: ec2935863ddecaa1bcba421a21f466ee57d35c0f
https://github.com/Perl/perl5/commit/ec2935863ddecaa1bcba421a21f466ee57d35c0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 9e127cbac2fe82e0ebea22ab88fa19f297a7b365
https://github.com/Perl/perl5/commit/9e127cbac2fe82e0ebea22ab88fa19f297a7b365
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 455bd20e12ad4335a176ebc5b687751ab8cee38d
https://github.com/Perl/perl5/commit/455bd20e12ad4335a176ebc5b687751ab8cee38d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 948343d38eb8ef48abf4c1caa7f7e7ca3c3a9094
https://github.com/Perl/perl5/commit/948343d38eb8ef48abf4c1caa7f7e7ca3c3a9094
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 0f43c1bf0abed47809f24c1ab58610f85ef71507
https://github.com/Perl/perl5/commit/0f43c1bf0abed47809f24c1ab58610f85ef71507
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 085be736c483b62eeb699cce483ee8b71040a0ff
https://github.com/Perl/perl5/commit/085be736c483b62eeb699cce483ee8b71040a0ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 3581b6ab72209b62dc4c579bb28177ab2f757d7f
https://github.com/Perl/perl5/commit/3581b6ab72209b62dc4c579bb28177ab2f757d7f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 6e8933eb207c83e2069f6d86cda243f8b20c5df4
https://github.com/Perl/perl5/commit/6e8933eb207c83e2069f6d86cda243f8b20c5df4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 31946a39a6e34e8485b8c367c45c9c666c3810f2
https://github.com/Perl/perl5/commit/31946a39a6e34e8485b8c367c45c9c666c3810f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 04ecd3c54544d43115e9d6ac7233c8e3cf0eac1f
https://github.com/Perl/perl5/commit/04ecd3c54544d43115e9d6ac7233c8e3cf0eac1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: a1fcd42c4465a48cd7c7c4be301ea7d05583ba45
https://github.com/Perl/perl5/commit/a1fcd42c4465a48cd7c7c4be301ea7d05583ba45
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: a3eb15287edd996fafa018f7eb2f5aee13860d91
https://github.com/Perl/perl5/commit/a3eb15287edd996fafa018f7eb2f5aee13860d91
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: b039a4a7a57f6ce56870f094c2da667c3afa790a
https://github.com/Perl/perl5/commit/b039a4a7a57f6ce56870f094c2da667c3afa790a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 73c92c808c5225f93f14b609cf2d5bd3a1f777a5
https://github.com/Perl/perl5/commit/73c92c808c5225f93f14b609cf2d5bd3a1f777a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 56567c470a56783b1f0856e976b80ed828db0aec
https://github.com/Perl/perl5/commit/56567c470a56783b1f0856e976b80ed828db0aec
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 9ae4a4ffce67187857759bbd696c1358ed58089e
https://github.com/Perl/perl5/commit/9ae4a4ffce67187857759bbd696c1358ed58089e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: b80bb247ae2cca82fe5fd456bb24e90397b07d3e
https://github.com/Perl/perl5/commit/b80bb247ae2cca82fe5fd456bb24e90397b07d3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 7c41874faa113f2183d5c1d350c19d25a0326025
https://github.com/Perl/perl5/commit/7c41874faa113f2183d5c1d350c19d25a0326025
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 294b19c071a02cb749ffa0ecd6fceec21ff43ded
https://github.com/Perl/perl5/commit/294b19c071a02cb749ffa0ecd6fceec21ff43ded
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: b898ff26d88389b73dfdb82a5e1288a76ed9703c
https://github.com/Perl/perl5/commit/b898ff26d88389b73dfdb82a5e1288a76ed9703c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 883c8d99f4c4f894e436452f74d44a0359c90e03
https://github.com/Perl/perl5/commit/883c8d99f4c4f894e436452f74d44a0359c90e03
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 659f59e20275fe53bf25495e2f7da1e6465737dc
https://github.com/Perl/perl5/commit/659f59e20275fe53bf25495e2f7da1e6465737dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: d94962983690d6bb46b700d9ff7b24d286e00c15
https://github.com/Perl/perl5/commit/d94962983690d6bb46b700d9ff7b24d286e00c15
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 0f1123fc4dfa76e489b0967fb9c2717dfa914490
https://github.com/Perl/perl5/commit/0f1123fc4dfa76e489b0967fb9c2717dfa914490
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: b5cb0e38755226ac7b83c06b08b0e5d31bc10523
https://github.com/Perl/perl5/commit/b5cb0e38755226ac7b83c06b08b0e5d31bc10523
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: eb2fc48301737eec404dde2aa7867396db090d9d
https://github.com/Perl/perl5/commit/eb2fc48301737eec404dde2aa7867396db090d9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: d5eee3c34f32bc96b5f2a36e63ea1581d3cc82ff
https://github.com/Perl/perl5/commit/d5eee3c34f32bc96b5f2a36e63ea1581d3cc82ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 47c556e2cb18ef2ffd6d0f9516a888f81a093aff
https://github.com/Perl/perl5/commit/47c556e2cb18ef2ffd6d0f9516a888f81a093aff
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 575fb1bc5eac9c59a38bc4e6d279350e9cae5fc4
https://github.com/Perl/perl5/commit/575fb1bc5eac9c59a38bc4e6d279350e9cae5fc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: e5b433742ae67e0599d465be208d3af9f24deef6
https://github.com/Perl/perl5/commit/e5b433742ae67e0599d465be208d3af9f24deef6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: f43916688a4536f94cecae4fc36ab317a81a32b7
https://github.com/Perl/perl5/commit/f43916688a4536f94cecae4fc36ab317a81a32b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 0f5b0f5cf698bfa39438bf7390da5069cd55f4dc
https://github.com/Perl/perl5/commit/0f5b0f5cf698bfa39438bf7390da5069cd55f4dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 1efc26a6beb5e9116112ece14f554886789152ea
https://github.com/Perl/perl5/commit/1efc26a6beb5e9116112ece14f554886789152ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 3651ececf35981db011e9b920d896b51fd05072a
https://github.com/Perl/perl5/commit/3651ececf35981db011e9b920d896b51fd05072a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 5135a058f4c1fc1910f2e3990655d3d6eeb7d97d
https://github.com/Perl/perl5/commit/5135a058f4c1fc1910f2e3990655d3d6eeb7d97d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 9b22095286055d5a0de0afb7bf6a73d7684a57af
https://github.com/Perl/perl5/commit/9b22095286055d5a0de0afb7bf6a73d7684a57af
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 68261288444c9a70aeb6876d93a98fdab4dcdfc9
https://github.com/Perl/perl5/commit/68261288444c9a70aeb6876d93a98fdab4dcdfc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 1460c6cb21ef2418c720e702e690409ffde17db6
https://github.com/Perl/perl5/commit/1460c6cb21ef2418c720e702e690409ffde17db6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 0cd1bafeee5102dd904955ea438b01e9a63a1575
https://github.com/Perl/perl5/commit/0cd1bafeee5102dd904955ea438b01e9a63a1575
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: b6412145f4e04a22df908119977398e196d2f693
https://github.com/Perl/perl5/commit/b6412145f4e04a22df908119977398e196d2f693
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 052bf94bdb3565775131cca15392bfa1a610b595
https://github.com/Perl/perl5/commit/052bf94bdb3565775131cca15392bfa1a610b595
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: d6b5eda234cb043c7d6283550a24536cb7b0002f
https://github.com/Perl/perl5/commit/d6b5eda234cb043c7d6283550a24536cb7b0002f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 70757f8802dd50ffff0aaf5b2af344003349ce9e
https://github.com/Perl/perl5/commit/70757f8802dd50ffff0aaf5b2af344003349ce9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 36e621c9f5d261e28416324fd16b069353127dd4
https://github.com/Perl/perl5/commit/36e621c9f5d261e28416324fd16b069353127dd4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: cd5e1e7234f558cb4ba344d95e60f731f885e0de
https://github.com/Perl/perl5/commit/cd5e1e7234f558cb4ba344d95e60f731f885e0de
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 18e5ae1854fceb7ef46faef6fa34e0f37be83f86
https://github.com/Perl/perl5/commit/18e5ae1854fceb7ef46faef6fa34e0f37be83f86
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 9c364865fe7306117bd2154b2b24f5f1ff201f25
https://github.com/Perl/perl5/commit/9c364865fe7306117bd2154b2b24f5f1ff201f25
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 5cda202aa6d0e1963b165f02fc0ddf1210d4d670
https://github.com/Perl/perl5/commit/5cda202aa6d0e1963b165f02fc0ddf1210d4d670
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: bed16553f28d1188b57572289416e4d8830d36ad
https://github.com/Perl/perl5/commit/bed16553f28d1188b57572289416e4d8830d36ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 4e94aaab8a7548ff893f6f29ea55e2f28efeba05
https://github.com/Perl/perl5/commit/4e94aaab8a7548ff893f6f29ea55e2f28efeba05
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 41e687cf41342820aa8f1077dc8e416b8a6cc232
https://github.com/Perl/perl5/commit/41e687cf41342820aa8f1077dc8e416b8a6cc232
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 2e9fce3cacb9f6a1f262d9889c7072009cd5f233
https://github.com/Perl/perl5/commit/2e9fce3cacb9f6a1f262d9889c7072009cd5f233
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: cf4e3476ded80aaea0017db3bbfb49833cd70ad5
https://github.com/Perl/perl5/commit/cf4e3476ded80aaea0017db3bbfb49833cd70ad5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 59c065f792a051928acfcb8625b84b417fda62b1
https://github.com/Perl/perl5/commit/59c065f792a051928acfcb8625b84b417fda62b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 205483cc1757c96ee69cf359ee3e2a537824b41a
https://github.com/Perl/perl5/commit/205483cc1757c96ee69cf359ee3e2a537824b41a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 28768368b55ed5d3dabef48866a23e225da83372
https://github.com/Perl/perl5/commit/28768368b55ed5d3dabef48866a23e225da83372
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 20c925347cfd7eeb6b175b78018d5904b740cd47
https://github.com/Perl/perl5/commit/20c925347cfd7eeb6b175b78018d5904b740cd47
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 0079bf1ec2065a8cabd7b82d6eccd6dd15e0705b
https://github.com/Perl/perl5/commit/0079bf1ec2065a8cabd7b82d6eccd6dd15e0705b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 716e49ec2ffd89c8fe053497b1dea3f3beca829a
https://github.com/Perl/perl5/commit/716e49ec2ffd89c8fe053497b1dea3f3beca829a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 9276e0bf07429440d840cbcbc5811c8dc7485468
https://github.com/Perl/perl5/commit/9276e0bf07429440d840cbcbc5811c8dc7485468
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 255acef2da58755b8500504bfe2de6a1a8d56c67
https://github.com/Perl/perl5/commit/255acef2da58755b8500504bfe2de6a1a8d56c67
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 6cd814eea38bcad7a0314fc9e93220f66790b12e
https://github.com/Perl/perl5/commit/6cd814eea38bcad7a0314fc9e93220f66790b12e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 81f2a2b1db7e068226894d5e7195f74faa47f0d0
https://github.com/Perl/perl5/commit/81f2a2b1db7e068226894d5e7195f74faa47f0d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: fe0dd19b75fcd35a2cfd99d97c4042848da592b0
https://github.com/Perl/perl5/commit/fe0dd19b75fcd35a2cfd99d97c4042848da592b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 483abad675743d42feed0469bd1c757e9a4595e8
https://github.com/Perl/perl5/commit/483abad675743d42feed0469bd1c757e9a4595e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: a34fb8f368b385102c586be328a5eb0303fe3fc2
https://github.com/Perl/perl5/commit/a34fb8f368b385102c586be328a5eb0303fe3fc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 433b14605a0c21f5d3b3f4fbebf197889a66f35b
https://github.com/Perl/perl5/commit/433b14605a0c21f5d3b3f4fbebf197889a66f35b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 01aed4282f756c98ed9c8506649edcf78e66845f
https://github.com/Perl/perl5/commit/01aed4282f756c98ed9c8506649edcf78e66845f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 246737c8fe6d391cf924064d853362579798d088
https://github.com/Perl/perl5/commit/246737c8fe6d391cf924064d853362579798d088
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: d6910c6a2f977788fa83c2ce43f53d0ce2dedc6f
https://github.com/Perl/perl5/commit/d6910c6a2f977788fa83c2ce43f53d0ce2dedc6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: c1656f305ad374d2d2fc7517425c90ce28b2c0b6
https://github.com/Perl/perl5/commit/c1656f305ad374d2d2fc7517425c90ce28b2c0b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 2c317f45e3fee27a02807189188d8a9199acb79c
https://github.com/Perl/perl5/commit/2c317f45e3fee27a02807189188d8a9199acb79c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 84f40e0a521c9e2e63cc67e9ce08915bfd29717e
https://github.com/Perl/perl5/commit/84f40e0a521c9e2e63cc67e9ce08915bfd29717e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: b12c5e6f3e9a70f0ac31c76000a66b1deb9914d9
https://github.com/Perl/perl5/commit/b12c5e6f3e9a70f0ac31c76000a66b1deb9914d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 2b03113d7dae896c07d324020b20032c46a423de
https://github.com/Perl/perl5/commit/2b03113d7dae896c07d324020b20032c46a423de
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 701e8f9027758af025bffbc9d13cc484af6f79dc
https://github.com/Perl/perl5/commit/701e8f9027758af025bffbc9d13cc484af6f79dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 83bc841a7bcba00c65d5f47780b6335af871fbc2
https://github.com/Perl/perl5/commit/83bc841a7bcba00c65d5f47780b6335af871fbc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: cf1aeea03b18f53fdbc50bdea0c464358adaf4ac
https://github.com/Perl/perl5/commit/cf1aeea03b18f53fdbc50bdea0c464358adaf4ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: f90700f974488960aa3b518dba4472349f52dee8
https://github.com/Perl/perl5/commit/f90700f974488960aa3b518dba4472349f52dee8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 234af087a5152301451a4221f98ff2ae6e51b37f
https://github.com/Perl/perl5/commit/234af087a5152301451a4221f98ff2ae6e51b37f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 0825542eca82204b480a1747909fe73af64f282e
https://github.com/Perl/perl5/commit/0825542eca82204b480a1747909fe73af64f282e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: b9d6bec2046a1dad61367336a29ac25dfa76ac6d
https://github.com/Perl/perl5/commit/b9d6bec2046a1dad61367336a29ac25dfa76ac6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 68e7414e29e0adbdafe67a53fb96660bda0a7c2d
https://github.com/Perl/perl5/commit/68e7414e29e0adbdafe67a53fb96660bda0a7c2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more13
Compare: https://github.com/Perl/perl5/compare/010faf5ea032...68e7414e29e0
