Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 781e6a0d4604c4943405a5f4f30d0098f6e7bb0f
https://github.com/Perl/perl5/commit/781e6a0d4604c4943405a5f4f30d0098f6e7bb0f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
perlapi: Rmv repeated word
Commit: 4d6ea4a1c5d8fdbb27601a655672c08c55abae9e
https://github.com/Perl/perl5/commit/4d6ea4a1c5d8fdbb27601a655672c08c55abae9e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 233cc07109e5ebd33ce157c94a6921be39fbad24
https://github.com/Perl/perl5/commit/233cc07109e5ebd33ce157c94a6921be39fbad24
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 1f1663adffffc48233fca4f2187c1e465e3b6eaa
https://github.com/Perl/perl5/commit/1f1663adffffc48233fca4f2187c1e465e3b6eaa
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: e5400ebebc329f54b2e38bf4fff8b3a8df7ce9f1
https://github.com/Perl/perl5/commit/e5400ebebc329f54b2e38bf4fff8b3a8df7ce9f1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 08ee3f747c5d9d2cbd03597dc91b6ee50f63d777
https://github.com/Perl/perl5/commit/08ee3f747c5d9d2cbd03597dc91b6ee50f63d777
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: c799ac25d63d9eb53b1a2f64482f4a3b41b71876
https://github.com/Perl/perl5/commit/c799ac25d63d9eb53b1a2f64482f4a3b41b71876
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 4be539b1e9b062773155139e36f0c02e8c82296d
https://github.com/Perl/perl5/commit/4be539b1e9b062773155139e36f0c02e8c82296d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 67afc268d5a20985015de35c8c817d9312dec707
https://github.com/Perl/perl5/commit/67afc268d5a20985015de35c8c817d9312dec707
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: f3dbccf05f9c0df53023c6442b09e4b109171b84
https://github.com/Perl/perl5/commit/f3dbccf05f9c0df53023c6442b09e4b109171b84
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: dcd8d18573d333a5917367f21a4f29d0150d4d84
https://github.com/Perl/perl5/commit/dcd8d18573d333a5917367f21a4f29d0150d4d84
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: b71a0312e41db294739255a107832818481823e5
https://github.com/Perl/perl5/commit/b71a0312e41db294739255a107832818481823e5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 582b557eb645c9f150c486a6e152446e6ce15574
https://github.com/Perl/perl5/commit/582b557eb645c9f150c486a6e152446e6ce15574
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 4ffc80e027822ea82834684b3338d9bd561c1ca0
https://github.com/Perl/perl5/commit/4ffc80e027822ea82834684b3338d9bd561c1ca0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 9b466a39dbd22349ad311f2f103f43c6fed64d85
https://github.com/Perl/perl5/commit/9b466a39dbd22349ad311f2f103f43c6fed64d85
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 471c45f508e870afd7e08dbffa40d64fafbdac75
https://github.com/Perl/perl5/commit/471c45f508e870afd7e08dbffa40d64fafbdac75
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: af804fad4cabb91c9201b9d87c143727a009633b
https://github.com/Perl/perl5/commit/af804fad4cabb91c9201b9d87c143727a009633b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: b6e0393ea3490ea3164156c9a3ab7700bc71d069
https://github.com/Perl/perl5/commit/b6e0393ea3490ea3164156c9a3ab7700bc71d069
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: f1252bd6008153f69fa6f0f74fe5d42fe28a1f95
https://github.com/Perl/perl5/commit/f1252bd6008153f69fa6f0f74fe5d42fe28a1f95
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 3a687832e0cb331bcd0a9edfa2ab3af3a6c50713
https://github.com/Perl/perl5/commit/3a687832e0cb331bcd0a9edfa2ab3af3a6c50713
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 973f6090869ed269613650cf42c615586e402cd6
https://github.com/Perl/perl5/commit/973f6090869ed269613650cf42c615586e402cd6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 75421953033a8010a283de2dab2a468ce76a77f7
https://github.com/Perl/perl5/commit/75421953033a8010a283de2dab2a468ce76a77f7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: d275c00dd5c2e0a1cb557bc3cbbc909e16e55f8d
https://github.com/Perl/perl5/commit/d275c00dd5c2e0a1cb557bc3cbbc909e16e55f8d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 6c8c35a1bdefaeff3ad08da65149d420d570201c
https://github.com/Perl/perl5/commit/6c8c35a1bdefaeff3ad08da65149d420d570201c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 2c46736c4b2da85901c4c4b0139e66df056b8b6e
https://github.com/Perl/perl5/commit/2c46736c4b2da85901c4c4b0139e66df056b8b6e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 8b723d2c847d89418e16c9dd9c5a59c8265c8aa9
https://github.com/Perl/perl5/commit/8b723d2c847d89418e16c9dd9c5a59c8265c8aa9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 5fbcc770f7f208557769eb5de930a957199a6ab3
https://github.com/Perl/perl5/commit/5fbcc770f7f208557769eb5de930a957199a6ab3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: d700fb758744d07d41740f895368f3b9467d4bfe
https://github.com/Perl/perl5/commit/d700fb758744d07d41740f895368f3b9467d4bfe
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 958876d8b183b396b0fdc2c41f66ab60495704f4
https://github.com/Perl/perl5/commit/958876d8b183b396b0fdc2c41f66ab60495704f4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 84e8c2cb6c87f3d1538e9a4223b801fce3db49e5
https://github.com/Perl/perl5/commit/84e8c2cb6c87f3d1538e9a4223b801fce3db49e5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 7648f628235e56cdf20dc75e059d5fbd1fa81f9c
https://github.com/Perl/perl5/commit/7648f628235e56cdf20dc75e059d5fbd1fa81f9c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 4d03ced1cc2ecc5d2f7c04d766930c78999622e5
https://github.com/Perl/perl5/commit/4d03ced1cc2ecc5d2f7c04d766930c78999622e5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 29f96bcc91d1fb4a67ceab8fff9ab3ac42f00d5e
https://github.com/Perl/perl5/commit/29f96bcc91d1fb4a67ceab8fff9ab3ac42f00d5e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 0d190930885c9a06abc2727cc115e70d921c22b8
https://github.com/Perl/perl5/commit/0d190930885c9a06abc2727cc115e70d921c22b8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: b198baa6ed04702d6d9b7b308b56dc2bf547bc70
https://github.com/Perl/perl5/commit/b198baa6ed04702d6d9b7b308b56dc2bf547bc70
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 367ef27bb28c2ef50439b23c26d2c32762bce5ac
https://github.com/Perl/perl5/commit/367ef27bb28c2ef50439b23c26d2c32762bce5ac
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 4b09a9455e57b570f60b29f80348363dc37ce34f
https://github.com/Perl/perl5/commit/4b09a9455e57b570f60b29f80348363dc37ce34f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: ddc1b9eabfc439b5b35eb796d732a541cf776711
https://github.com/Perl/perl5/commit/ddc1b9eabfc439b5b35eb796d732a541cf776711
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: efb7c51395190267fa95056e50b712a1bc5fe020
https://github.com/Perl/perl5/commit/efb7c51395190267fa95056e50b712a1bc5fe020
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 7bfe5614669879684607dc3aff8ab24ca3b2d69c
https://github.com/Perl/perl5/commit/7bfe5614669879684607dc3aff8ab24ca3b2d69c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: ee37f3ad776998b631362f01320099e195e3a032
https://github.com/Perl/perl5/commit/ee37f3ad776998b631362f01320099e195e3a032
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: a25f9fad97775ba06110e1495e16f9927ceccf17
https://github.com/Perl/perl5/commit/a25f9fad97775ba06110e1495e16f9927ceccf17
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 3364139c0a738b46efb994980347918f7b6e7d58
https://github.com/Perl/perl5/commit/3364139c0a738b46efb994980347918f7b6e7d58
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 8b2e6902b8422f946f44ed05249c0d9850d5ed38
https://github.com/Perl/perl5/commit/8b2e6902b8422f946f44ed05249c0d9850d5ed38
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: cff9d91d8ff6bb25a171fe178d35dd7dc735392d
https://github.com/Perl/perl5/commit/cff9d91d8ff6bb25a171fe178d35dd7dc735392d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 338b52e71d40fb57d1c3f0d33aaf34ebf85a08a0
https://github.com/Perl/perl5/commit/338b52e71d40fb57d1c3f0d33aaf34ebf85a08a0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: c05a1f868d00e3a12d79268bb6cdd2a5eb9fdd0f
https://github.com/Perl/perl5/commit/c05a1f868d00e3a12d79268bb6cdd2a5eb9fdd0f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 73d341ae1a7c287b836eec2651421e9d2b414b60
https://github.com/Perl/perl5/commit/73d341ae1a7c287b836eec2651421e9d2b414b60
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 48b939f6ba99d65e8c3b67c4ff35d20cb30dbda0
https://github.com/Perl/perl5/commit/48b939f6ba99d65e8c3b67c4ff35d20cb30dbda0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: a322ebac727370ebd4e0cdb890e85b2d130c59f7
https://github.com/Perl/perl5/commit/a322ebac727370ebd4e0cdb890e85b2d130c59f7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: d5e4fde610cb2a4e6b8958b03f314fcf88f37466
https://github.com/Perl/perl5/commit/d5e4fde610cb2a4e6b8958b03f314fcf88f37466
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 17a005be2cf8f6534136ff0225e9079a5fc5a393
https://github.com/Perl/perl5/commit/17a005be2cf8f6534136ff0225e9079a5fc5a393
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 99b5bd81c507c0ed7c1919e53c4324d41b724f6d
https://github.com/Perl/perl5/commit/99b5bd81c507c0ed7c1919e53c4324d41b724f6d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: d031f5316edbaf6448b8478e80bad01fe7705f43
https://github.com/Perl/perl5/commit/d031f5316edbaf6448b8478e80bad01fe7705f43
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 55951fd316f32ab25e7724332a01c209d23fcf5c
https://github.com/Perl/perl5/commit/55951fd316f32ab25e7724332a01c209d23fcf5c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 790dac574616ecb2e7ae3ce253d8715bb0ce5f37
https://github.com/Perl/perl5/commit/790dac574616ecb2e7ae3ce253d8715bb0ce5f37
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 71cfe1edf920cc8f36813832b69c31de6f0bf92f
https://github.com/Perl/perl5/commit/71cfe1edf920cc8f36813832b69c31de6f0bf92f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 8a2d40f36593c8c1c75185b99a3bdb5ee8ebcc7f
https://github.com/Perl/perl5/commit/8a2d40f36593c8c1c75185b99a3bdb5ee8ebcc7f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: f0fb528abea28589a4310e2472b46a57ce065356
https://github.com/Perl/perl5/commit/f0fb528abea28589a4310e2472b46a57ce065356
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 8e2847345c58cd112a8c1ca81c67e150d8cd81a2
https://github.com/Perl/perl5/commit/8e2847345c58cd112a8c1ca81c67e150d8cd81a2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 36025cbccd514076227d208e0008beddea230a78
https://github.com/Perl/perl5/commit/36025cbccd514076227d208e0008beddea230a78
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: ddfb2e66275744c96175cb48d171b0c851831671
https://github.com/Perl/perl5/commit/ddfb2e66275744c96175cb48d171b0c851831671
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: b346df36a9387e9db21c7c919e7d69e3774b78d4
https://github.com/Perl/perl5/commit/b346df36a9387e9db21c7c919e7d69e3774b78d4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: b2b99d9f530b5a20b752c34c293aabe9ec1ee241
https://github.com/Perl/perl5/commit/b2b99d9f530b5a20b752c34c293aabe9ec1ee241
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 7f0018b22b01f103a4a272ad9e0948f85a8c93f8
https://github.com/Perl/perl5/commit/7f0018b22b01f103a4a272ad9e0948f85a8c93f8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: d3d02e54813d8489f821f35346ef233024a89319
https://github.com/Perl/perl5/commit/d3d02e54813d8489f821f35346ef233024a89319
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 4922ba396bef23c36be5e0d0b7a6678ed3571ea9
https://github.com/Perl/perl5/commit/4922ba396bef23c36be5e0d0b7a6678ed3571ea9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 7f835b22914a38e35a92aba562d8bd70eb47ef75
https://github.com/Perl/perl5/commit/7f835b22914a38e35a92aba562d8bd70eb47ef75
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: e954c75b1e3883cb5507a0dd290cc9c40885ac83
https://github.com/Perl/perl5/commit/e954c75b1e3883cb5507a0dd290cc9c40885ac83
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 0e70cc78233d4f3694f981da5bfdea1a3c605bc5
https://github.com/Perl/perl5/commit/0e70cc78233d4f3694f981da5bfdea1a3c605bc5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 48230944a41928f8af1bd20d7a4a3f4a25c3586b
https://github.com/Perl/perl5/commit/48230944a41928f8af1bd20d7a4a3f4a25c3586b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 6524795f7d1a5f5d5f6f07a5ecc9732d41639996
https://github.com/Perl/perl5/commit/6524795f7d1a5f5d5f6f07a5ecc9732d41639996
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 0c749792509253b1d7896f56d480f9d3e727bcf1
https://github.com/Perl/perl5/commit/0c749792509253b1d7896f56d480f9d3e727bcf1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 6321633b1785ee25e49712d6d13431b3316efc2c
https://github.com/Perl/perl5/commit/6321633b1785ee25e49712d6d13431b3316efc2c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 23f2d6559ede600f5ee529df53bc6319e1d43ec6
https://github.com/Perl/perl5/commit/23f2d6559ede600f5ee529df53bc6319e1d43ec6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 7802e426f938946775e869230961ece284ac649b
https://github.com/Perl/perl5/commit/7802e426f938946775e869230961ece284ac649b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 1a9a7166c124f7fb36915e41f98437537010ca2f
https://github.com/Perl/perl5/commit/1a9a7166c124f7fb36915e41f98437537010ca2f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 9ea6dd2f81ae5b0a7331e1b46bf765db9c2b6e27
https://github.com/Perl/perl5/commit/9ea6dd2f81ae5b0a7331e1b46bf765db9c2b6e27
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 7008781fad55eb9be058fe5f68aab84a1735ed9b
https://github.com/Perl/perl5/commit/7008781fad55eb9be058fe5f68aab84a1735ed9b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 1e7aa02d0a013c8ec9d642f4890270797a1bbb36
https://github.com/Perl/perl5/commit/1e7aa02d0a013c8ec9d642f4890270797a1bbb36
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: f06b2a0af9b038146089beb509a6eb45fd6dab4b
https://github.com/Perl/perl5/commit/f06b2a0af9b038146089beb509a6eb45fd6dab4b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: f07eb15a14528037ddff28f33fe78b9712fe29ec
https://github.com/Perl/perl5/commit/f07eb15a14528037ddff28f33fe78b9712fe29ec
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 5006e83958bb3526011cb1061232d8aabbda961c
https://github.com/Perl/perl5/commit/5006e83958bb3526011cb1061232d8aabbda961c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: fdf63aaabaabc3b4cacf91ad88f2bd6b43df3123
https://github.com/Perl/perl5/commit/fdf63aaabaabc3b4cacf91ad88f2bd6b43df3123
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: be9f21d6c085115aa6ceed2b895377723922183a
https://github.com/Perl/perl5/commit/be9f21d6c085115aa6ceed2b895377723922183a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: d888b6cc8bad0f92ed9bfc863b36d75e1129e16a
https://github.com/Perl/perl5/commit/d888b6cc8bad0f92ed9bfc863b36d75e1129e16a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: b2a50e00309c840008e1f1e69f9b7934e488dc4a
https://github.com/Perl/perl5/commit/b2a50e00309c840008e1f1e69f9b7934e488dc4a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 5b4f5b8b1f7122d234e286e722f90930e1319ba4
https://github.com/Perl/perl5/commit/5b4f5b8b1f7122d234e286e722f90930e1319ba4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: e9e7c5c0f1bdd8481aa4dcd7fb90b79b64fafc28
https://github.com/Perl/perl5/commit/e9e7c5c0f1bdd8481aa4dcd7fb90b79b64fafc28
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: af7e9fab285ef2ed8ea004c453be932455624621
https://github.com/Perl/perl5/commit/af7e9fab285ef2ed8ea004c453be932455624621
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 6fdf8ee310ef3c3214e16f7a134a16da49b4a312
https://github.com/Perl/perl5/commit/6fdf8ee310ef3c3214e16f7a134a16da49b4a312
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: f294be078381f953069fc4c341250637b4a6d271
https://github.com/Perl/perl5/commit/f294be078381f953069fc4c341250637b4a6d271
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 9b6a6d878d63f450c5dff33c9cd465bb004ff37c
https://github.com/Perl/perl5/commit/9b6a6d878d63f450c5dff33c9cd465bb004ff37c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: ca1367123a3d2a7b102d8fee6347e746dfda1c54
https://github.com/Perl/perl5/commit/ca1367123a3d2a7b102d8fee6347e746dfda1c54
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 5ad7d59fd38aec34b38acb33a46fbb6842e0b513
https://github.com/Perl/perl5/commit/5ad7d59fd38aec34b38acb33a46fbb6842e0b513
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: e4e80ff48e623abd1c303a78f412975c739d9783
https://github.com/Perl/perl5/commit/e4e80ff48e623abd1c303a78f412975c739d9783
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 6dbb760670e0bbcc1c0046c0a864454f4db3b399
https://github.com/Perl/perl5/commit/6dbb760670e0bbcc1c0046c0a864454f4db3b399
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: e347306609da9051301609154bb89e482c59a867
https://github.com/Perl/perl5/commit/e347306609da9051301609154bb89e482c59a867
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 42fa62f5d83eadca7e88b437a9aba5b89b9f591e
https://github.com/Perl/perl5/commit/42fa62f5d83eadca7e88b437a9aba5b89b9f591e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 615fd2906973d566511b70760beb9357d510a7b1
https://github.com/Perl/perl5/commit/615fd2906973d566511b70760beb9357d510a7b1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 49301bed754cdcb421004f02796e99f6633aa126
https://github.com/Perl/perl5/commit/49301bed754cdcb421004f02796e99f6633aa126
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: 51f905d1c0ffc80ec6298f74fe3495ac9095956f
https://github.com/Perl/perl5/commit/51f905d1c0ffc80ec6298f74fe3495ac9095956f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 81302dc31cf34e8666376ca5c71b89e8843f97ce
https://github.com/Perl/perl5/commit/81302dc31cf34e8666376ca5c71b89e8843f97ce
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 59f5e54defdc7672022cc6a55e54a29ede978f60
https://github.com/Perl/perl5/commit/59f5e54defdc7672022cc6a55e54a29ede978f60
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: b21ad97d597f1386e2faab58f9d81e1bb31dd209
https://github.com/Perl/perl5/commit/b21ad97d597f1386e2faab58f9d81e1bb31dd209
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 9996a6da54fba5a986c7d173fc27928d33fa3c08
https://github.com/Perl/perl5/commit/9996a6da54fba5a986c7d173fc27928d33fa3c08
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 662cac795bf65fbfe50e3c04f136768a45bca386
https://github.com/Perl/perl5/commit/662cac795bf65fbfe50e3c04f136768a45bca386
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 659e49d0b93efd870ac214420623d458fbdadc58
https://github.com/Perl/perl5/commit/659e49d0b93efd870ac214420623d458fbdadc58
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: bae1169a29baf24a0b9f60926a8e3684143e96cc
https://github.com/Perl/perl5/commit/bae1169a29baf24a0b9f60926a8e3684143e96cc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: c4723e0a2f8f530881b9e0e677f6b93dcad046a3
https://github.com/Perl/perl5/commit/c4723e0a2f8f530881b9e0e677f6b93dcad046a3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: a26cb78cb6b17d2d5d1bca7cd50e1e43fc6a6c4b
https://github.com/Perl/perl5/commit/a26cb78cb6b17d2d5d1bca7cd50e1e43fc6a6c4b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 40097d9a86b3f1657aa972e6a53c941022349591
https://github.com/Perl/perl5/commit/40097d9a86b3f1657aa972e6a53c941022349591
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: eadf0989423e5d5d05ca149515c42596ee663b2d
https://github.com/Perl/perl5/commit/eadf0989423e5d5d05ca149515c42596ee663b2d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: a43aa9102c65c7604e57dfbe0ab2eb2ffbfa7d47
https://github.com/Perl/perl5/commit/a43aa9102c65c7604e57dfbe0ab2eb2ffbfa7d47
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 0dcec769909429705ce1b5eea76e5490669ee82f
https://github.com/Perl/perl5/commit/0dcec769909429705ce1b5eea76e5490669ee82f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: f1f672d00361a5c04556aa708a681c90152e0824
https://github.com/Perl/perl5/commit/f1f672d00361a5c04556aa708a681c90152e0824
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: d8a4347c1b73e6bedc8e070e4fc06b9528354225
https://github.com/Perl/perl5/commit/d8a4347c1b73e6bedc8e070e4fc06b9528354225
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 52852e676fba79c7ee18aafafab9d40d083eb92e
https://github.com/Perl/perl5/commit/52852e676fba79c7ee18aafafab9d40d083eb92e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 595af70a09397c1101e7994f77465200fd49d3bf
https://github.com/Perl/perl5/commit/595af70a09397c1101e7994f77465200fd49d3bf
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 3077367b1c0a88e7d72076752bc763ff88f17c84
https://github.com/Perl/perl5/commit/3077367b1c0a88e7d72076752bc763ff88f17c84
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: f62791e3e05071372e0366cc0b58a7654503b6ca
https://github.com/Perl/perl5/commit/f62791e3e05071372e0366cc0b58a7654503b6ca
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 9f368864a999e0bf15345f1ef6ede4b5b3391e8f
https://github.com/Perl/perl5/commit/9f368864a999e0bf15345f1ef6ede4b5b3391e8f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: ea031e2a6837bcd0a9f8429166131267edf2bd4c
https://github.com/Perl/perl5/commit/ea031e2a6837bcd0a9f8429166131267edf2bd4c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 4a6390b07e4d15d417725a9a1b5d8098f07375f1
https://github.com/Perl/perl5/commit/4a6390b07e4d15d417725a9a1b5d8098f07375f1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 1758e44a81fde4756c8f4201623bbac5da328ff8
https://github.com/Perl/perl5/commit/1758e44a81fde4756c8f4201623bbac5da328ff8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 7b66a69b0ed4765089a2c69513076f1ff5c2a11b
https://github.com/Perl/perl5/commit/7b66a69b0ed4765089a2c69513076f1ff5c2a11b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 935d3d3ae395760101bfbaf56a3dbf6b42c6b5a0
https://github.com/Perl/perl5/commit/935d3d3ae395760101bfbaf56a3dbf6b42c6b5a0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 66d56c7df7ec4304be50d5d47c66c49b8ced1d7a
https://github.com/Perl/perl5/commit/66d56c7df7ec4304be50d5d47c66c49b8ced1d7a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 4d0ac664729cd4406b0f74e8805ebd25ec33beb2
https://github.com/Perl/perl5/commit/4d0ac664729cd4406b0f74e8805ebd25ec33beb2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 603f6a36756062ba475d92689e91397b0ee713e7
https://github.com/Perl/perl5/commit/603f6a36756062ba475d92689e91397b0ee713e7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: c0c4017460cd4b3af57a3092f79eb15c94718e7c
https://github.com/Perl/perl5/commit/c0c4017460cd4b3af57a3092f79eb15c94718e7c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: a70466234aaf85db8c76ac43438fdc233c9a18c8
https://github.com/Perl/perl5/commit/a70466234aaf85db8c76ac43438fdc233c9a18c8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 37e24944ca8ea6806a73002972b544a36f42f010
https://github.com/Perl/perl5/commit/37e24944ca8ea6806a73002972b544a36f42f010
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: b5114f6695f18c18e185883533409d06326f190e
https://github.com/Perl/perl5/commit/b5114f6695f18c18e185883533409d06326f190e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 7ca66762a8e1b6850278e3712f0630f72e3b6789
https://github.com/Perl/perl5/commit/7ca66762a8e1b6850278e3712f0630f72e3b6789
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: cfbd6f3e66ac509b799efd1c46b84a931238d1ad
https://github.com/Perl/perl5/commit/cfbd6f3e66ac509b799efd1c46b84a931238d1ad
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 78430479189ff455375f86a855cd171c4e4c9028
https://github.com/Perl/perl5/commit/78430479189ff455375f86a855cd171c4e4c9028
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 80c522b9f6dcf02f9a422280822a96e7884e272b
https://github.com/Perl/perl5/commit/80c522b9f6dcf02f9a422280822a96e7884e272b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 8497ec02c75bb9a6da05ef7b4fd64830bc463465
https://github.com/Perl/perl5/commit/8497ec02c75bb9a6da05ef7b4fd64830bc463465
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 0915c8b813fb7508a432801c92ba3b95a24f668c
https://github.com/Perl/perl5/commit/0915c8b813fb7508a432801c92ba3b95a24f668c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 33a59a6400fa5c8f4f517f20a22bd04a28893d32
https://github.com/Perl/perl5/commit/33a59a6400fa5c8f4f517f20a22bd04a28893d32
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 2f882b10b0ebbe3bbc0efdc6c86d1d74dc44aec3
https://github.com/Perl/perl5/commit/2f882b10b0ebbe3bbc0efdc6c86d1d74dc44aec3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: c25a97262ef6a5880dda8897175fe29326ca7cc6
https://github.com/Perl/perl5/commit/c25a97262ef6a5880dda8897175fe29326ca7cc6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: dd507b05d97f022616f72f42dff1d6396786b87e
https://github.com/Perl/perl5/commit/dd507b05d97f022616f72f42dff1d6396786b87e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: ee667d1f29f6e68b75b2c31d450ef9e597a78538
https://github.com/Perl/perl5/commit/ee667d1f29f6e68b75b2c31d450ef9e597a78538
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: d5d94f7fba5229b13d40ee41e61d5cf73071cfd3
https://github.com/Perl/perl5/commit/d5d94f7fba5229b13d40ee41e61d5cf73071cfd3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: c8a13bfb927a3f6e34db1b2b5bbad9c8eff53d50
https://github.com/Perl/perl5/commit/c8a13bfb927a3f6e34db1b2b5bbad9c8eff53d50
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 0c71ecf4cd3aaaa5dadbad0d2d47ab916aa15eae
https://github.com/Perl/perl5/commit/0c71ecf4cd3aaaa5dadbad0d2d47ab916aa15eae
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 7b2c3f2ae7649f7078d021db3dd5b14d9c7ee90c
https://github.com/Perl/perl5/commit/7b2c3f2ae7649f7078d021db3dd5b14d9c7ee90c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 45b732aefd8f57822fa65b470c00ee54d96d0957
https://github.com/Perl/perl5/commit/45b732aefd8f57822fa65b470c00ee54d96d0957
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 8ac7ebaed844544978f40c6277d3bf75ecf43d97
https://github.com/Perl/perl5/commit/8ac7ebaed844544978f40c6277d3bf75ecf43d97
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 70f7e8f425ce03a3a6744e4fe67b879099bd2964
https://github.com/Perl/perl5/commit/70f7e8f425ce03a3a6744e4fe67b879099bd2964
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 5213cac73976aa52ac8f4a7d6a802077572b222a
https://github.com/Perl/perl5/commit/5213cac73976aa52ac8f4a7d6a802077572b222a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 81456d4755eff02f19e9b9da9a5d3dd638fff933
https://github.com/Perl/perl5/commit/81456d4755eff02f19e9b9da9a5d3dd638fff933
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: ca5e2c4a3555505f245d2746fcc80ac4b4c90fa6
https://github.com/Perl/perl5/commit/ca5e2c4a3555505f245d2746fcc80ac4b4c90fa6
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 17458b032769e389763c9dd9490dc3d60946f74b
https://github.com/Perl/perl5/commit/17458b032769e389763c9dd9490dc3d60946f74b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 021804826c1767d7099d6f8cb23297e4277ced8b
https://github.com/Perl/perl5/commit/021804826c1767d7099d6f8cb23297e4277ced8b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: a0d2076936e3a0927482163c4fdf356413f2dcf7
https://github.com/Perl/perl5/commit/a0d2076936e3a0927482163c4fdf356413f2dcf7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 829cc55ff76de7f33c13650be35cdc130080bfeb
https://github.com/Perl/perl5/commit/829cc55ff76de7f33c13650be35cdc130080bfeb
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: a62140026a0b468411ef88dbe568fb8c859ad8e9
https://github.com/Perl/perl5/commit/a62140026a0b468411ef88dbe568fb8c859ad8e9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: e8a20492d056111673d108dbcd2631cb83eceeb0
https://github.com/Perl/perl5/commit/e8a20492d056111673d108dbcd2631cb83eceeb0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 53d14c2faad95c24381c50b41e5c177f43e778c9
https://github.com/Perl/perl5/commit/53d14c2faad95c24381c50b41e5c177f43e778c9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 7c2fdd9d366720160255bda43354051832dabafc
https://github.com/Perl/perl5/commit/7c2fdd9d366720160255bda43354051832dabafc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 1cd4174de63038968fcf12eb46b9e21f702fb610
https://github.com/Perl/perl5/commit/1cd4174de63038968fcf12eb46b9e21f702fb610
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 556acc46df8411b7b5e155a0b29d17d12ad90285
https://github.com/Perl/perl5/commit/556acc46df8411b7b5e155a0b29d17d12ad90285
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 71d3f92eef6fbc71cbdc7254ddeede2872da44af
https://github.com/Perl/perl5/commit/71d3f92eef6fbc71cbdc7254ddeede2872da44af
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 8f3257362e4d97f4e5c76a72ba70ee6931cf19c8
https://github.com/Perl/perl5/commit/8f3257362e4d97f4e5c76a72ba70ee6931cf19c8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: dd264f6f6560c02014715ed2a78f65db0ca86701
https://github.com/Perl/perl5/commit/dd264f6f6560c02014715ed2a78f65db0ca86701
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: b00788a1155dc9671209c5c8f3726925490f831e
https://github.com/Perl/perl5/commit/b00788a1155dc9671209c5c8f3726925490f831e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: ae93b0ed8f9e15b5b5f878a21772c9a550e6012c
https://github.com/Perl/perl5/commit/ae93b0ed8f9e15b5b5f878a21772c9a550e6012c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: d09e107650eace623fc9e86a275788d7726c533f
https://github.com/Perl/perl5/commit/d09e107650eace623fc9e86a275788d7726c533f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: d5a84e6f9c3445e8a7778733db243f25c98e7409
https://github.com/Perl/perl5/commit/d5a84e6f9c3445e8a7778733db243f25c98e7409
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: d09ae02e06c9faa04e572fde28c23a7eef46f319
https://github.com/Perl/perl5/commit/d09ae02e06c9faa04e572fde28c23a7eef46f319
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: de4afc1a7e409fda9d0b981519e288e536cecd75
https://github.com/Perl/perl5/commit/de4afc1a7e409fda9d0b981519e288e536cecd75
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 6edd7d3595c141e8e36c62e6072d42eae994b486
https://github.com/Perl/perl5/commit/6edd7d3595c141e8e36c62e6072d42eae994b486
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 8bed336af22467d305f9daa880b62ca3cc5089cd
https://github.com/Perl/perl5/commit/8bed336af22467d305f9daa880b62ca3cc5089cd
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 7b7752b2416c643954674c8c9e627b30542b1764
https://github.com/Perl/perl5/commit/7b7752b2416c643954674c8c9e627b30542b1764
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: e49e7ee191bf1ebcc1da17947c4ac4b959b5dba9
https://github.com/Perl/perl5/commit/e49e7ee191bf1ebcc1da17947c4ac4b959b5dba9
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: f5018cf0edec1366d889d1419610cf55540d4531
https://github.com/Perl/perl5/commit/f5018cf0edec1366d889d1419610cf55540d4531
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: c29fc3dee839b07e821bb9a82d53884f30e0868a
https://github.com/Perl/perl5/commit/c29fc3dee839b07e821bb9a82d53884f30e0868a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 48e1adb2229ab8b32c3b15c78ee7dc4fa1f2bf43
https://github.com/Perl/perl5/commit/48e1adb2229ab8b32c3b15c78ee7dc4fa1f2bf43
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 482a85d7d01168c028e4b695149413f4eda4639d
https://github.com/Perl/perl5/commit/482a85d7d01168c028e4b695149413f4eda4639d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 0d8cd0b462363e6e7c457c899c75381273830ba3
https://github.com/Perl/perl5/commit/0d8cd0b462363e6e7c457c899c75381273830ba3
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: f0a247b6cdcf1a702f1afeffa46fb97630461cad
https://github.com/Perl/perl5/commit/f0a247b6cdcf1a702f1afeffa46fb97630461cad
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 0b83e62be610e41855640a6c085b1c619d1fa8db
https://github.com/Perl/perl5/commit/0b83e62be610e41855640a6c085b1c619d1fa8db
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: b916b0709ace3f041cd9785e069d6cf886bf6c6a
https://github.com/Perl/perl5/commit/b916b0709ace3f041cd9785e069d6cf886bf6c6a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: a31c55e6e07baaa9574d31d2c5c95e229c66ed5e
https://github.com/Perl/perl5/commit/a31c55e6e07baaa9574d31d2c5c95e229c66ed5e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: f3fc0b78921d399980b84d01e7d19ed8956298f4
https://github.com/Perl/perl5/commit/f3fc0b78921d399980b84d01e7d19ed8956298f4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 929aee9dd8d13801a27417a22aa12563ab91fbc5
https://github.com/Perl/perl5/commit/929aee9dd8d13801a27417a22aa12563ab91fbc5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 793e8bee909d55b168bd5c1158312ae46a15727c
https://github.com/Perl/perl5/commit/793e8bee909d55b168bd5c1158312ae46a15727c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 94a47a38ce785356d431f7e50cbee327b7415619
https://github.com/Perl/perl5/commit/94a47a38ce785356d431f7e50cbee327b7415619
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: d63671abe60248c8385b15ed75cbc0105e062d4e
https://github.com/Perl/perl5/commit/d63671abe60248c8385b15ed75cbc0105e062d4e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 10c91e3efbd17ad40f3f58f59c000e4b48484f11
https://github.com/Perl/perl5/commit/10c91e3efbd17ad40f3f58f59c000e4b48484f11
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 174ab4e1e9cb4e85b76b97f4916e5a26796d3682
https://github.com/Perl/perl5/commit/174ab4e1e9cb4e85b76b97f4916e5a26796d3682
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 7fc42ace0955482eb6fbdfb6c761f2eccba499d8
https://github.com/Perl/perl5/commit/7fc42ace0955482eb6fbdfb6c761f2eccba499d8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 76ebdc4fae8ac34b0abe91f7ca0935808d66d2ca
https://github.com/Perl/perl5/commit/76ebdc4fae8ac34b0abe91f7ca0935808d66d2ca
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 735971fdebfa498a17151cab1412128f2451b18e
https://github.com/Perl/perl5/commit/735971fdebfa498a17151cab1412128f2451b18e
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: f8b729aace1f6c7d0f2be9a9bbe9da0f68621415
https://github.com/Perl/perl5/commit/f8b729aace1f6c7d0f2be9a9bbe9da0f68621415
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 4df7c0b725b5545809159e0a06a2b383b7ecb25b
https://github.com/Perl/perl5/commit/4df7c0b725b5545809159e0a06a2b383b7ecb25b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 96510bb0033ee64d1d6a6bb74239e16ce2ab5c9a
https://github.com/Perl/perl5/commit/96510bb0033ee64d1d6a6bb74239e16ce2ab5c9a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: af41d9e35bcc675fc3ffa94fd172d6a37403be17
https://github.com/Perl/perl5/commit/af41d9e35bcc675fc3ffa94fd172d6a37403be17
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: fca8fde6d2ec512354e1e34e8af8b36e6adf1e83
https://github.com/Perl/perl5/commit/fca8fde6d2ec512354e1e34e8af8b36e6adf1e83
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: a90b43db11ecdefcef0bedd669f093fc4faa5789
https://github.com/Perl/perl5/commit/a90b43db11ecdefcef0bedd669f093fc4faa5789
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: ddc0afd52430931aba73fcea288790245079a034
https://github.com/Perl/perl5/commit/ddc0afd52430931aba73fcea288790245079a034
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: c4fffa226eb41185d5b702bdb6e35a776abb352b
https://github.com/Perl/perl5/commit/c4fffa226eb41185d5b702bdb6e35a776abb352b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 30abda0d730d12dc63ab0d641bd53db40ae85045
https://github.com/Perl/perl5/commit/30abda0d730d12dc63ab0d641bd53db40ae85045
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 3ded14495f582dfddd11c464784ecaa2b5988c99
https://github.com/Perl/perl5/commit/3ded14495f582dfddd11c464784ecaa2b5988c99
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 1c4e2e152b42ee70441ca7184601340dbda3c5e5
https://github.com/Perl/perl5/commit/1c4e2e152b42ee70441ca7184601340dbda3c5e5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 750b08bdf852929740dc2bd1847ee6cf3da7eae1
https://github.com/Perl/perl5/commit/750b08bdf852929740dc2bd1847ee6cf3da7eae1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 815af098a19a46cf4e9d3eeca473cac3b997fcef
https://github.com/Perl/perl5/commit/815af098a19a46cf4e9d3eeca473cac3b997fcef
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 75dbcbc7be5d2c6ffb44fa663532db974852d06f
https://github.com/Perl/perl5/commit/75dbcbc7be5d2c6ffb44fa663532db974852d06f
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 23cc4d0a7dd67ae41e64addb83ed1e6c8415128d
https://github.com/Perl/perl5/commit/23cc4d0a7dd67ae41e64addb83ed1e6c8415128d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 5bc54642300217f35c1e28da53c0494e852eb613
https://github.com/Perl/perl5/commit/5bc54642300217f35c1e28da53c0494e852eb613
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 19a5587823f2b79122768bd470c5ece06df5a036
https://github.com/Perl/perl5/commit/19a5587823f2b79122768bd470c5ece06df5a036
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 5f35d56b58ce10718172d08e30fdef29bc33f9d7
https://github.com/Perl/perl5/commit/5f35d56b58ce10718172d08e30fdef29bc33f9d7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 6f7dbedcd4d564e27e5d220ac8459dccf09e18d0
https://github.com/Perl/perl5/commit/6f7dbedcd4d564e27e5d220ac8459dccf09e18d0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 3b49f8c120ae7090fd4f67bb24f9de1be994bd62
https://github.com/Perl/perl5/commit/3b49f8c120ae7090fd4f67bb24f9de1be994bd62
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 65b82d8e416a3836d7d27cf40459b854d10d0384
https://github.com/Perl/perl5/commit/65b82d8e416a3836d7d27cf40459b854d10d0384
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 9a64b613c39c71b98725fbaef49f6953f0043c30
https://github.com/Perl/perl5/commit/9a64b613c39c71b98725fbaef49f6953f0043c30
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 2be6514915a1bc4a78f02e62b6ea928c0680ba8b
https://github.com/Perl/perl5/commit/2be6514915a1bc4a78f02e62b6ea928c0680ba8b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 7fde7f3aa7022e22c233b72a8d83c546099ad48a
https://github.com/Perl/perl5/commit/7fde7f3aa7022e22c233b72a8d83c546099ad48a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: b85813853cbdcc5264cf87f30aa6d64f08fc1ab7
https://github.com/Perl/perl5/commit/b85813853cbdcc5264cf87f30aa6d64f08fc1ab7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: d8a1dfddbf48caa07473cb68c266c8afa24fcdb1
https://github.com/Perl/perl5/commit/d8a1dfddbf48caa07473cb68c266c8afa24fcdb1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 9a435d67f2138982a65e17e792feea6db7ff0738
https://github.com/Perl/perl5/commit/9a435d67f2138982a65e17e792feea6db7ff0738
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 33720c5ba47b0b344e1fa49250981b5993ffd310
https://github.com/Perl/perl5/commit/33720c5ba47b0b344e1fa49250981b5993ffd310
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: fa26c2f2ee89754f545f9acb835353eea83edf1b
https://github.com/Perl/perl5/commit/fa26c2f2ee89754f545f9acb835353eea83edf1b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 474dd76cd91b7aeec2b6e2e74ca025e5beb52d11
https://github.com/Perl/perl5/commit/474dd76cd91b7aeec2b6e2e74ca025e5beb52d11
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 2e44e3ab63b885957583791379dca62e8e0496dc
https://github.com/Perl/perl5/commit/2e44e3ab63b885957583791379dca62e8e0496dc
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: bbc52f0bf4dcf529c717abe2106412941d597745
https://github.com/Perl/perl5/commit/bbc52f0bf4dcf529c717abe2106412941d597745
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 398adb108a18755c1510632663fce0dea3c2f477
https://github.com/Perl/perl5/commit/398adb108a18755c1510632663fce0dea3c2f477
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: fa854c9b4a8f76991fe329fdd8f8f3de19713b64
https://github.com/Perl/perl5/commit/fa854c9b4a8f76991fe329fdd8f8f3de19713b64
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: 3691153d8cc38598d1b36e14bb0ae91354dd991a
https://github.com/Perl/perl5/commit/3691153d8cc38598d1b36e14bb0ae91354dd991a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 7df401d341cab83169fb566dc8aba8910ff28150
https://github.com/Perl/perl5/commit/7df401d341cab83169fb566dc8aba8910ff28150
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: c8c0f6262aded7e4561158267d4a8b3f5ae45522
https://github.com/Perl/perl5/commit/c8c0f6262aded7e4561158267d4a8b3f5ae45522
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: f5ff4c848134a408b3d5b2378be25dc61936797c
https://github.com/Perl/perl5/commit/f5ff4c848134a408b3d5b2378be25dc61936797c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 3850dfb50a2f99b8dbb5060c7c95ba391bfbec39
https://github.com/Perl/perl5/commit/3850dfb50a2f99b8dbb5060c7c95ba391bfbec39
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 9ec9972e528c6b62bf39d9078e5756fa0c88c3e8
https://github.com/Perl/perl5/commit/9ec9972e528c6b62bf39d9078e5756fa0c88c3e8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 1ee1b532e50ff7a091fb55b81eb7fb8c5dc6a2a2
https://github.com/Perl/perl5/commit/1ee1b532e50ff7a091fb55b81eb7fb8c5dc6a2a2
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 948ef0924e8c2a9932ac82fff8c98ad6e3af26b4
https://github.com/Perl/perl5/commit/948ef0924e8c2a9932ac82fff8c98ad6e3af26b4
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 879a115c31316eaf5dc7266d940254dcd0c87f82
https://github.com/Perl/perl5/commit/879a115c31316eaf5dc7266d940254dcd0c87f82
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: de7b438031015ca096e252541d10b74f61ff805b
https://github.com/Perl/perl5/commit/de7b438031015ca096e252541d10b74f61ff805b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 9bc6d0852dc84f6da30f79af62c90c887bde7eab
https://github.com/Perl/perl5/commit/9bc6d0852dc84f6da30f79af62c90c887bde7eab
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 210d3121b1430e0955cef3484cc10b2aa41501e0
https://github.com/Perl/perl5/commit/210d3121b1430e0955cef3484cc10b2aa41501e0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 0547f4b9fc713105388371353ba5ba8cd9c2d254
https://github.com/Perl/perl5/commit/0547f4b9fc713105388371353ba5ba8cd9c2d254
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 3b7dd7bf645beba16d461c644f0372e9c4d2cfe8
https://github.com/Perl/perl5/commit/3b7dd7bf645beba16d461c644f0372e9c4d2cfe8
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: 1f229bfeb93c0919c6e2cdc4f4e66c2cb3468e37
https://github.com/Perl/perl5/commit/1f229bfeb93c0919c6e2cdc4f4e66c2cb3468e37
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 615324458663a5a3b4138afcd0925554a8796ea5
https://github.com/Perl/perl5/commit/615324458663a5a3b4138afcd0925554a8796ea5
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 1c43c1e4e1eff687956e50d9cf15d48f013eded7
https://github.com/Perl/perl5/commit/1c43c1e4e1eff687956e50d9cf15d48f013eded7
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 8bf3142ab57144e22fc96819ac358ea7e7764c7c
https://github.com/Perl/perl5/commit/8bf3142ab57144e22fc96819ac358ea7e7764c7c
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: c4c1e226f3beed4ece5dd43b398a0f22a0dbc9a0
https://github.com/Perl/perl5/commit/c4c1e226f3beed4ece5dd43b398a0f22a0dbc9a0
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 22d2b598139fa7c457db487b2b1ce8a678264109
https://github.com/Perl/perl5/commit/22d2b598139fa7c457db487b2b1ce8a678264109
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 49f59457135e97d5fcab9097c3cc5bf7b5640b87
https://github.com/Perl/perl5/commit/49f59457135e97d5fcab9097c3cc5bf7b5640b87
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: facc1051448c84fa0b4f977fe5f3a4dd7f3c471b
https://github.com/Perl/perl5/commit/facc1051448c84fa0b4f977fe5f3a4dd7f3c471b
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 9dbf1d484536774c2deda79b8497aa60bceb329d
https://github.com/Perl/perl5/commit/9dbf1d484536774c2deda79b8497aa60bceb329d
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 7776a1cb284b203899df49a08a47070562182e28
https://github.com/Perl/perl5/commit/7776a1cb284b203899df49a08a47070562182e28
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: cc3b6ada2d1797e54a5459485e71f6030ccae7a1
https://github.com/Perl/perl5/commit/cc3b6ada2d1797e54a5459485e71f6030ccae7a1
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 7c7d1e9d02b351e75ce21e1113be2379fa9b942a
https://github.com/Perl/perl5/commit/7c7d1e9d02b351e75ce21e1113be2379fa9b942a
Author: Karl Williamson <k...@cpan.org>
Date: 2021-05-01 (Sat, 01 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M proto.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
50
Compare: https://github.com/Perl/perl5/compare/4f1941b5b8f0...7c7d1e9d02b3
