Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 8a1f6541b8d94be13ebd06371dcfeaae0921b271
https://github.com/Perl/perl5/commit/8a1f6541b8d94be13ebd06371dcfeaae0921b271
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
perlapi: Rmv repeated word
Commit: 8403352d215cd4a80fcc840edb208b57db8b9137
https://github.com/Perl/perl5/commit/8403352d215cd4a80fcc840edb208b57db8b9137
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 10aa61cb0e6bdc3bebeb3858bcd058fccb41adb6
https://github.com/Perl/perl5/commit/10aa61cb0e6bdc3bebeb3858bcd058fccb41adb6
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: cc7a99ec5f3bd72ecfb77a9a92d0c085a810c6b1
https://github.com/Perl/perl5/commit/cc7a99ec5f3bd72ecfb77a9a92d0c085a810c6b1
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 884e804018f2cbaf83bdb2949b9a9b2c66571e0a
https://github.com/Perl/perl5/commit/884e804018f2cbaf83bdb2949b9a9b2c66571e0a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 5d2fcad3538194467ece1bd7dfa2b0d78a98a148
https://github.com/Perl/perl5/commit/5d2fcad3538194467ece1bd7dfa2b0d78a98a148
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 4dfdfea4eda0aa70cc22fd7f5a048f84686b3c40
https://github.com/Perl/perl5/commit/4dfdfea4eda0aa70cc22fd7f5a048f84686b3c40
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: ffa5d3981e1a1702d8f29e1f6ed3c8fb4713f0d0
https://github.com/Perl/perl5/commit/ffa5d3981e1a1702d8f29e1f6ed3c8fb4713f0d0
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 80f092f8305e733beaf1c5adf8b27c2a7b3c5744
https://github.com/Perl/perl5/commit/80f092f8305e733beaf1c5adf8b27c2a7b3c5744
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: f2e5074bfc6d38cfb1d70b6d8ab3c2a2546c23ce
https://github.com/Perl/perl5/commit/f2e5074bfc6d38cfb1d70b6d8ab3c2a2546c23ce
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 20b6f1eab5216ec46073abfb8b3d4338d24ab919
https://github.com/Perl/perl5/commit/20b6f1eab5216ec46073abfb8b3d4338d24ab919
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: be258d5329ffc18ae9ab26920a99767de33b810a
https://github.com/Perl/perl5/commit/be258d5329ffc18ae9ab26920a99767de33b810a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: d8ff71c2e9e8d870efc95707821d9a01741d22ea
https://github.com/Perl/perl5/commit/d8ff71c2e9e8d870efc95707821d9a01741d22ea
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 7d8b6d1ae11717a19953d9ecf8d1db8849e2e222
https://github.com/Perl/perl5/commit/7d8b6d1ae11717a19953d9ecf8d1db8849e2e222
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: cb44b4b4015ec0829ea754dec18803dd6663799f
https://github.com/Perl/perl5/commit/cb44b4b4015ec0829ea754dec18803dd6663799f
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 97314d2fef14e3e4e4c75fb6ddc7eed537b9f94d
https://github.com/Perl/perl5/commit/97314d2fef14e3e4e4c75fb6ddc7eed537b9f94d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 0e5cd86c1311c17f4d6b087fcfa73c05fe7e7117
https://github.com/Perl/perl5/commit/0e5cd86c1311c17f4d6b087fcfa73c05fe7e7117
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 310fe3240e154bac88881169603974806175da0e
https://github.com/Perl/perl5/commit/310fe3240e154bac88881169603974806175da0e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 771298657e18ddbb1291680165599345a7b5c870
https://github.com/Perl/perl5/commit/771298657e18ddbb1291680165599345a7b5c870
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 0d68ea401abd1dbff0e849eebea5798e298b8aec
https://github.com/Perl/perl5/commit/0d68ea401abd1dbff0e849eebea5798e298b8aec
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 1660880c12d9edb2a2bedaa962c5739750cd45bd
https://github.com/Perl/perl5/commit/1660880c12d9edb2a2bedaa962c5739750cd45bd
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 9998385368d3e3bb1fab4933cf9d033ec707888c
https://github.com/Perl/perl5/commit/9998385368d3e3bb1fab4933cf9d033ec707888c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: ef01cc600caaeeaaf909f04857bc7746bb164bc5
https://github.com/Perl/perl5/commit/ef01cc600caaeeaaf909f04857bc7746bb164bc5
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 1eb4ea1fe3a032e4d3795e3b2ab74ddd2deb3544
https://github.com/Perl/perl5/commit/1eb4ea1fe3a032e4d3795e3b2ab74ddd2deb3544
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 337cd0571c811fcb8241c1a9951ec076c1469b25
https://github.com/Perl/perl5/commit/337cd0571c811fcb8241c1a9951ec076c1469b25
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 7e79aee6cff2c9ea1226cc43725b520742c3ed22
https://github.com/Perl/perl5/commit/7e79aee6cff2c9ea1226cc43725b520742c3ed22
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: ee8c9ab52df7a90bc4ce7a8f4bff8f189a5cf830
https://github.com/Perl/perl5/commit/ee8c9ab52df7a90bc4ce7a8f4bff8f189a5cf830
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 60d2be24356eed9a9c490501145621b19f5b5c05
https://github.com/Perl/perl5/commit/60d2be24356eed9a9c490501145621b19f5b5c05
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 59fae6531b7f15e49260c3fd4c8bbed47bae319d
https://github.com/Perl/perl5/commit/59fae6531b7f15e49260c3fd4c8bbed47bae319d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: cb7db9bea6e15ac876748d975f1518444a90b21d
https://github.com/Perl/perl5/commit/cb7db9bea6e15ac876748d975f1518444a90b21d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 511638477650a5583a0f408bba3469b62ff8793c
https://github.com/Perl/perl5/commit/511638477650a5583a0f408bba3469b62ff8793c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 778e67fee3b41b9a1464f14fc24cca9169ef6cb9
https://github.com/Perl/perl5/commit/778e67fee3b41b9a1464f14fc24cca9169ef6cb9
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 8fe001d4432365de1147823631969e4279075952
https://github.com/Perl/perl5/commit/8fe001d4432365de1147823631969e4279075952
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 3e0c144614d8d7a736c478ea45c07527cd29b285
https://github.com/Perl/perl5/commit/3e0c144614d8d7a736c478ea45c07527cd29b285
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 594c6ef5f083b8bc04fa49eff1a25ac62f949d31
https://github.com/Perl/perl5/commit/594c6ef5f083b8bc04fa49eff1a25ac62f949d31
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 227986c5d59ff4e80d5520c4fe02e1277410a3fd
https://github.com/Perl/perl5/commit/227986c5d59ff4e80d5520c4fe02e1277410a3fd
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 21c0100bdd4113eeb6a344fbb9d8709664c94502
https://github.com/Perl/perl5/commit/21c0100bdd4113eeb6a344fbb9d8709664c94502
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 16d141538525b04942048ef9e4c020888fee2691
https://github.com/Perl/perl5/commit/16d141538525b04942048ef9e4c020888fee2691
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 9043f5b79d8838662e502243a1217fb918f714d4
https://github.com/Perl/perl5/commit/9043f5b79d8838662e502243a1217fb918f714d4
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 003a94ab9dd86ebab7c48b76ca95c52cdc54f2ae
https://github.com/Perl/perl5/commit/003a94ab9dd86ebab7c48b76ca95c52cdc54f2ae
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 2b515599ae12b2a9b353dd872cdbf795cc5d19b0
https://github.com/Perl/perl5/commit/2b515599ae12b2a9b353dd872cdbf795cc5d19b0
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 540e7e5bf2917e8ae344f310dd29190db06d8399
https://github.com/Perl/perl5/commit/540e7e5bf2917e8ae344f310dd29190db06d8399
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 2ec4ca9c53ff27c8b753b992a8d4cc8dd8453389
https://github.com/Perl/perl5/commit/2ec4ca9c53ff27c8b753b992a8d4cc8dd8453389
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: bf1c54c43dcabb5cfabda8c3e86737a2b95a26dc
https://github.com/Perl/perl5/commit/bf1c54c43dcabb5cfabda8c3e86737a2b95a26dc
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: cb72c305c2791d2fdb3168f65459dbb517392a40
https://github.com/Perl/perl5/commit/cb72c305c2791d2fdb3168f65459dbb517392a40
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: cc4bdc142a50a89e747b7debd1296dab50dfe449
https://github.com/Perl/perl5/commit/cc4bdc142a50a89e747b7debd1296dab50dfe449
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 50271fe5c2e91d2a3d7e4a4f1e17617f46945f01
https://github.com/Perl/perl5/commit/50271fe5c2e91d2a3d7e4a4f1e17617f46945f01
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 0ca30fa0550b463fb555d88255cafe925fdff44c
https://github.com/Perl/perl5/commit/0ca30fa0550b463fb555d88255cafe925fdff44c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: c978f712d0d0252807d47c04ebaf6a3b2e8075cd
https://github.com/Perl/perl5/commit/c978f712d0d0252807d47c04ebaf6a3b2e8075cd
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: be6ce24b56c8fa28c605bc478c5bda8dcece34d4
https://github.com/Perl/perl5/commit/be6ce24b56c8fa28c605bc478c5bda8dcece34d4
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 65450a49113d9294d5a3586e9147a1c0e7993dd6
https://github.com/Perl/perl5/commit/65450a49113d9294d5a3586e9147a1c0e7993dd6
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 54ccca2f5da18d8ca7b54ef05f2673cd75393ddf
https://github.com/Perl/perl5/commit/54ccca2f5da18d8ca7b54ef05f2673cd75393ddf
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 2c0e62828e95540874423a1a35b33310f8760c9e
https://github.com/Perl/perl5/commit/2c0e62828e95540874423a1a35b33310f8760c9e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: a3479e5c2d7de00c8d91e8a221b5ad50759ce20c
https://github.com/Perl/perl5/commit/a3479e5c2d7de00c8d91e8a221b5ad50759ce20c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 0bea0bcd52764827c935af60b65c99a722acf688
https://github.com/Perl/perl5/commit/0bea0bcd52764827c935af60b65c99a722acf688
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 9b7274911bf7202987328a8bf916e8450b6ae306
https://github.com/Perl/perl5/commit/9b7274911bf7202987328a8bf916e8450b6ae306
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 82fc7ad8972edb21449a888848cc8b4779b6d905
https://github.com/Perl/perl5/commit/82fc7ad8972edb21449a888848cc8b4779b6d905
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 9c32b1e8d12e12ed5d497d4df5aff8e6326137be
https://github.com/Perl/perl5/commit/9c32b1e8d12e12ed5d497d4df5aff8e6326137be
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: f60e82e723ec83b8cf89f95cc03feb46296f5b96
https://github.com/Perl/perl5/commit/f60e82e723ec83b8cf89f95cc03feb46296f5b96
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 7bda631e59f909b26be5da807ec5b5ceff3d4734
https://github.com/Perl/perl5/commit/7bda631e59f909b26be5da807ec5b5ceff3d4734
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 7a22bc90dd7089d2cde0fa9da402abfeec611b61
https://github.com/Perl/perl5/commit/7a22bc90dd7089d2cde0fa9da402abfeec611b61
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: a438772ea1571759ceb432c4a91589ee87a1602a
https://github.com/Perl/perl5/commit/a438772ea1571759ceb432c4a91589ee87a1602a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 820b03fdc132c9619d767c89b53eeff7dc7474e4
https://github.com/Perl/perl5/commit/820b03fdc132c9619d767c89b53eeff7dc7474e4
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 387862b44435820b945e5542ba011d6425b465a2
https://github.com/Perl/perl5/commit/387862b44435820b945e5542ba011d6425b465a2
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 99b11e15ef26d5727683621dd38de946dc91b3a6
https://github.com/Perl/perl5/commit/99b11e15ef26d5727683621dd38de946dc91b3a6
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 5edc437eda3846ec77ca0c87cce7075203a5fc61
https://github.com/Perl/perl5/commit/5edc437eda3846ec77ca0c87cce7075203a5fc61
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: bc08799c8972da5d989fa63fefff9362efc115fb
https://github.com/Perl/perl5/commit/bc08799c8972da5d989fa63fefff9362efc115fb
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 01c679c843b7c4c02fb7fa479aabcce42d69cfff
https://github.com/Perl/perl5/commit/01c679c843b7c4c02fb7fa479aabcce42d69cfff
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: cae7fcaad8d1dc9ed10ff3226c46bd6b5a17a6ec
https://github.com/Perl/perl5/commit/cae7fcaad8d1dc9ed10ff3226c46bd6b5a17a6ec
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: e8a98ef73e6409bc4c0d61431b9275446176610e
https://github.com/Perl/perl5/commit/e8a98ef73e6409bc4c0d61431b9275446176610e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: c0d47447be039876d6531c91f9dc3d168f76b972
https://github.com/Perl/perl5/commit/c0d47447be039876d6531c91f9dc3d168f76b972
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 209a70bd879200007022d35c288ebda3e801fdc2
https://github.com/Perl/perl5/commit/209a70bd879200007022d35c288ebda3e801fdc2
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: e96cb8f7240a10bc6bd9b84c58949f45fcd5cc32
https://github.com/Perl/perl5/commit/e96cb8f7240a10bc6bd9b84c58949f45fcd5cc32
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 8528938242ec05894bced04e6aad5ee436c87745
https://github.com/Perl/perl5/commit/8528938242ec05894bced04e6aad5ee436c87745
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: f237dc2828b30ba1fc8f08b78dc20e4bdc118d22
https://github.com/Perl/perl5/commit/f237dc2828b30ba1fc8f08b78dc20e4bdc118d22
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 4756b96cd1ab87cb3e340b65ffa187119eacd75c
https://github.com/Perl/perl5/commit/4756b96cd1ab87cb3e340b65ffa187119eacd75c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 73040eea35273edeb68f3ff7e8dacac0ccace7a5
https://github.com/Perl/perl5/commit/73040eea35273edeb68f3ff7e8dacac0ccace7a5
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: de16b57d7bdb0e572cdeaf5c238a05359e35fbf7
https://github.com/Perl/perl5/commit/de16b57d7bdb0e572cdeaf5c238a05359e35fbf7
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: c85d2bbfe0bdaa2c87add131015ccbab1eb1831a
https://github.com/Perl/perl5/commit/c85d2bbfe0bdaa2c87add131015ccbab1eb1831a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 04450aa1d82dcf90a75fdb8e38f215e873c321d3
https://github.com/Perl/perl5/commit/04450aa1d82dcf90a75fdb8e38f215e873c321d3
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 1410ff456a290ba1fc9ae926d9c29e15fca41f25
https://github.com/Perl/perl5/commit/1410ff456a290ba1fc9ae926d9c29e15fca41f25
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 66bab8e8f8442bce8c2a535b4522b31cbae9ad34
https://github.com/Perl/perl5/commit/66bab8e8f8442bce8c2a535b4522b31cbae9ad34
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 81d2f3e38678a5abfa57c4ff5a2f4177082dc48c
https://github.com/Perl/perl5/commit/81d2f3e38678a5abfa57c4ff5a2f4177082dc48c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: dd0378da6f10903dba8441f2ad8e11e89113ac49
https://github.com/Perl/perl5/commit/dd0378da6f10903dba8441f2ad8e11e89113ac49
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 7e8764cebbacda73127adeedd3143f634a6a9f69
https://github.com/Perl/perl5/commit/7e8764cebbacda73127adeedd3143f634a6a9f69
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: edef839be1703470e782af4021a470a0be066708
https://github.com/Perl/perl5/commit/edef839be1703470e782af4021a470a0be066708
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 355b771255bbf83210e311e54a2365d3069fffa2
https://github.com/Perl/perl5/commit/355b771255bbf83210e311e54a2365d3069fffa2
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 2e2f13323429553d537b20a3f77870e1990cce83
https://github.com/Perl/perl5/commit/2e2f13323429553d537b20a3f77870e1990cce83
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: cbcd2b132b1f38ef697a00e4bd5434eee3dbe2e7
https://github.com/Perl/perl5/commit/cbcd2b132b1f38ef697a00e4bd5434eee3dbe2e7
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: ed2de9f2ec8adebe17c139e1dd1bb5a786043b1a
https://github.com/Perl/perl5/commit/ed2de9f2ec8adebe17c139e1dd1bb5a786043b1a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: a3994f4db45b64a40f36e5b7a4e1b229097d9f92
https://github.com/Perl/perl5/commit/a3994f4db45b64a40f36e5b7a4e1b229097d9f92
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 94620325c7e3d2a0bf9483bdf73a07a5bc62332a
https://github.com/Perl/perl5/commit/94620325c7e3d2a0bf9483bdf73a07a5bc62332a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: a3f77778a497c02418a83da7a6b46eb1b5727329
https://github.com/Perl/perl5/commit/a3f77778a497c02418a83da7a6b46eb1b5727329
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: c09cdba2ef0046abde51dd1ebf3df695f61bfeee
https://github.com/Perl/perl5/commit/c09cdba2ef0046abde51dd1ebf3df695f61bfeee
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 0572eb14256013a5098872570bd8ec1e1ceb60b9
https://github.com/Perl/perl5/commit/0572eb14256013a5098872570bd8ec1e1ceb60b9
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 0f268d6f0743a345d7a8c80977b412d69eef4fff
https://github.com/Perl/perl5/commit/0f268d6f0743a345d7a8c80977b412d69eef4fff
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 47d2612921f76e05ba37f42d30963d60eafa986d
https://github.com/Perl/perl5/commit/47d2612921f76e05ba37f42d30963d60eafa986d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: fb7208c3cb7686f1a2b282272b75d0b332910d37
https://github.com/Perl/perl5/commit/fb7208c3cb7686f1a2b282272b75d0b332910d37
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: bca6be3c4d98d9a6c1132a6721c5c316cd5819a8
https://github.com/Perl/perl5/commit/bca6be3c4d98d9a6c1132a6721c5c316cd5819a8
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: b5737fca04bd3293e51f17eb8d6963c689036a53
https://github.com/Perl/perl5/commit/b5737fca04bd3293e51f17eb8d6963c689036a53
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 4619fdb6f12785756c808709cafc147bf89add9e
https://github.com/Perl/perl5/commit/4619fdb6f12785756c808709cafc147bf89add9e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: f510f47151462c5cbb230a7b9ec388e75b83d7af
https://github.com/Perl/perl5/commit/f510f47151462c5cbb230a7b9ec388e75b83d7af
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: aba28d604cbef6ea76b30bd2b1200dec523134d3
https://github.com/Perl/perl5/commit/aba28d604cbef6ea76b30bd2b1200dec523134d3
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 7c3790804bf7b404d06d7254a622db415bacbb42
https://github.com/Perl/perl5/commit/7c3790804bf7b404d06d7254a622db415bacbb42
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 16fbef5b962ef2dfb1be4fd3fa6532fc22024422
https://github.com/Perl/perl5/commit/16fbef5b962ef2dfb1be4fd3fa6532fc22024422
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 0b77aac669eb8bdb130cf01155c9834cd627f22d
https://github.com/Perl/perl5/commit/0b77aac669eb8bdb130cf01155c9834cd627f22d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: dfc67f0ac93640aa50af6f7f71abe847355d7a09
https://github.com/Perl/perl5/commit/dfc67f0ac93640aa50af6f7f71abe847355d7a09
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 44a44083dcac862998e8b58d30daff08eecf566a
https://github.com/Perl/perl5/commit/44a44083dcac862998e8b58d30daff08eecf566a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 42d2adf70043453335a98f9f38f262d9b2c28550
https://github.com/Perl/perl5/commit/42d2adf70043453335a98f9f38f262d9b2c28550
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 9b87de0ea3955aa74f63c5924f109f5c87599854
https://github.com/Perl/perl5/commit/9b87de0ea3955aa74f63c5924f109f5c87599854
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 4ab69cfd2ffb2ca7ac44625d060ba4d564568c79
https://github.com/Perl/perl5/commit/4ab69cfd2ffb2ca7ac44625d060ba4d564568c79
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 1f2687e60780cc1beb88b1296aa62273176b6278
https://github.com/Perl/perl5/commit/1f2687e60780cc1beb88b1296aa62273176b6278
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: e77bd931dca785e322c1678d16ee6d0dec89cc78
https://github.com/Perl/perl5/commit/e77bd931dca785e322c1678d16ee6d0dec89cc78
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: aa61dca304a5e8bfc9c9ec9e5e14b5148c939234
https://github.com/Perl/perl5/commit/aa61dca304a5e8bfc9c9ec9e5e14b5148c939234
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: d015b6cbd0453ff2b2c28032fba904fd56738be8
https://github.com/Perl/perl5/commit/d015b6cbd0453ff2b2c28032fba904fd56738be8
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 1d809dd6cf253554b62a29b867b00b91048d8236
https://github.com/Perl/perl5/commit/1d809dd6cf253554b62a29b867b00b91048d8236
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 45194e2414b70c59a659c631aeab7463c081636f
https://github.com/Perl/perl5/commit/45194e2414b70c59a659c631aeab7463c081636f
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: de9c3949a96f98d113e6cef64db69cd0d2f6ac84
https://github.com/Perl/perl5/commit/de9c3949a96f98d113e6cef64db69cd0d2f6ac84
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 5280d9002c4bd5706fd14a2995a4c078c189b67f
https://github.com/Perl/perl5/commit/5280d9002c4bd5706fd14a2995a4c078c189b67f
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 35e99bec2cca03b4e62b89b21934c25dec1d1763
https://github.com/Perl/perl5/commit/35e99bec2cca03b4e62b89b21934c25dec1d1763
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: b4e82f5e6b5e08993bf8393dbdca216bf48a3c5e
https://github.com/Perl/perl5/commit/b4e82f5e6b5e08993bf8393dbdca216bf48a3c5e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 06acdf84836d8c031a9f37f515f1d6c4610d9c69
https://github.com/Perl/perl5/commit/06acdf84836d8c031a9f37f515f1d6c4610d9c69
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 90180a11ef42e830b7b543b030d8d7e338783e63
https://github.com/Perl/perl5/commit/90180a11ef42e830b7b543b030d8d7e338783e63
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: f84c9024cebbf37cc722ba0155ab07f2495a2f05
https://github.com/Perl/perl5/commit/f84c9024cebbf37cc722ba0155ab07f2495a2f05
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: d79ab2db50f1f9b00fdf251ae5d7d381cf3a5545
https://github.com/Perl/perl5/commit/d79ab2db50f1f9b00fdf251ae5d7d381cf3a5545
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 280e567c09ea74ead72a7a7e45e19da8c9380007
https://github.com/Perl/perl5/commit/280e567c09ea74ead72a7a7e45e19da8c9380007
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: b5073b4b3da7e2c2e00084b0d4dbdf5e839f7460
https://github.com/Perl/perl5/commit/b5073b4b3da7e2c2e00084b0d4dbdf5e839f7460
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 9e7619c01a9533186668fcf25f1899e05ef7024d
https://github.com/Perl/perl5/commit/9e7619c01a9533186668fcf25f1899e05ef7024d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 24b133ccac7a882ff577fd7314472026d96e5277
https://github.com/Perl/perl5/commit/24b133ccac7a882ff577fd7314472026d96e5277
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 49147f3e0ae2fde01de3a6f7369470489cdd1ade
https://github.com/Perl/perl5/commit/49147f3e0ae2fde01de3a6f7369470489cdd1ade
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 479465ebd18081d49de1e5005e88d9b76f1fce19
https://github.com/Perl/perl5/commit/479465ebd18081d49de1e5005e88d9b76f1fce19
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: 51065471a307405a830eca9f36cd90fae1b89c65
https://github.com/Perl/perl5/commit/51065471a307405a830eca9f36cd90fae1b89c65
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: c433eed93380dfed7d22dbbf806ae947e22ca1eb
https://github.com/Perl/perl5/commit/c433eed93380dfed7d22dbbf806ae947e22ca1eb
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 86aca98241e8ca1efc09017b329f7214c4b3f452
https://github.com/Perl/perl5/commit/86aca98241e8ca1efc09017b329f7214c4b3f452
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: ed188905769dfe62b44e50ee2b229e0c4ea03749
https://github.com/Perl/perl5/commit/ed188905769dfe62b44e50ee2b229e0c4ea03749
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: db8ea783aab510f8e234f5fb18a7bd28fbcf5b47
https://github.com/Perl/perl5/commit/db8ea783aab510f8e234f5fb18a7bd28fbcf5b47
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 7a25b8b09e8c80cde6a48836e7474b6c1d69d19a
https://github.com/Perl/perl5/commit/7a25b8b09e8c80cde6a48836e7474b6c1d69d19a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 4559076e7a0e9961d881511cbeeb837349e13c25
https://github.com/Perl/perl5/commit/4559076e7a0e9961d881511cbeeb837349e13c25
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 0e4ddb7e067d74818bb66fe5c3fdce780f3b695b
https://github.com/Perl/perl5/commit/0e4ddb7e067d74818bb66fe5c3fdce780f3b695b
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 76c2b5aad28ce2dd1f22d42d23a69645a20e1325
https://github.com/Perl/perl5/commit/76c2b5aad28ce2dd1f22d42d23a69645a20e1325
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 8c819916c792af1d0b38ea9925e0dfcf3abf8be8
https://github.com/Perl/perl5/commit/8c819916c792af1d0b38ea9925e0dfcf3abf8be8
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 82a09dd45ac13043b8b701b2d88539e69bdca9c5
https://github.com/Perl/perl5/commit/82a09dd45ac13043b8b701b2d88539e69bdca9c5
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 816b7aa2342b3a4c8a37bb9fd3a762294010ffbd
https://github.com/Perl/perl5/commit/816b7aa2342b3a4c8a37bb9fd3a762294010ffbd
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 65d851fc2588d75921c9d5404d04c7a79fe933b2
https://github.com/Perl/perl5/commit/65d851fc2588d75921c9d5404d04c7a79fe933b2
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: a979bd1112aaa90ab92ae195c7c33980f7798b4e
https://github.com/Perl/perl5/commit/a979bd1112aaa90ab92ae195c7c33980f7798b4e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 5f30888233b90fed2bf96fc186f6a5679b2aabf8
https://github.com/Perl/perl5/commit/5f30888233b90fed2bf96fc186f6a5679b2aabf8
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 993aed4ba57b02eaf072d5cfc76a4bb3971cb1da
https://github.com/Perl/perl5/commit/993aed4ba57b02eaf072d5cfc76a4bb3971cb1da
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 7f75d09972319e66a2ec8b69920e9adb5100465b
https://github.com/Perl/perl5/commit/7f75d09972319e66a2ec8b69920e9adb5100465b
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 32579a070a434300654d7a33e7be220df345342c
https://github.com/Perl/perl5/commit/32579a070a434300654d7a33e7be220df345342c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: c90a5d8b8fbec74299b6144b09057bade4e246b4
https://github.com/Perl/perl5/commit/c90a5d8b8fbec74299b6144b09057bade4e246b4
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 514a3aebc9f8d99a40b4c5ca46279ecaa4efb2a0
https://github.com/Perl/perl5/commit/514a3aebc9f8d99a40b4c5ca46279ecaa4efb2a0
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 2eeddd6e65a651d418ec3d79db5e1ee25fc151fa
https://github.com/Perl/perl5/commit/2eeddd6e65a651d418ec3d79db5e1ee25fc151fa
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 796ea149a502d29755ba946a80397ffceaec049c
https://github.com/Perl/perl5/commit/796ea149a502d29755ba946a80397ffceaec049c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 7fa0c1888592fbfac45d6defdd692d1e41959bed
https://github.com/Perl/perl5/commit/7fa0c1888592fbfac45d6defdd692d1e41959bed
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 574f2f7dda009aab36aac4d06bbf090c85fb88fd
https://github.com/Perl/perl5/commit/574f2f7dda009aab36aac4d06bbf090c85fb88fd
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: aac2cbd03472d789d6b43999175f9566022a29df
https://github.com/Perl/perl5/commit/aac2cbd03472d789d6b43999175f9566022a29df
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 93c019e5ce799a0cdbe8372674cb08e2b4bc6289
https://github.com/Perl/perl5/commit/93c019e5ce799a0cdbe8372674cb08e2b4bc6289
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: bbeb888894590d4406c71baf7d6982b1ac43118c
https://github.com/Perl/perl5/commit/bbeb888894590d4406c71baf7d6982b1ac43118c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 3fb5893aeadaff5219bb93ffd6403a33d4de198d
https://github.com/Perl/perl5/commit/3fb5893aeadaff5219bb93ffd6403a33d4de198d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 312fb58f212667e6d5364f6b1bd7665bd93cc3d5
https://github.com/Perl/perl5/commit/312fb58f212667e6d5364f6b1bd7665bd93cc3d5
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 0959b751b2c81a4c1f4051fdea1f684920f22d9a
https://github.com/Perl/perl5/commit/0959b751b2c81a4c1f4051fdea1f684920f22d9a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 01379c404b2be910148e3dad0ae1124434954a34
https://github.com/Perl/perl5/commit/01379c404b2be910148e3dad0ae1124434954a34
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 9c92b949f2bc1f7e8833250b4d1f0eb75183aa45
https://github.com/Perl/perl5/commit/9c92b949f2bc1f7e8833250b4d1f0eb75183aa45
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 89488131b8fc77c534113e1a6ae6f1e6e26bad0c
https://github.com/Perl/perl5/commit/89488131b8fc77c534113e1a6ae6f1e6e26bad0c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: c756d252607785a173bb752d7c8db52a49eef610
https://github.com/Perl/perl5/commit/c756d252607785a173bb752d7c8db52a49eef610
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 0f1a3a25656bc81eb6c796e1bb27d2d930c7c50c
https://github.com/Perl/perl5/commit/0f1a3a25656bc81eb6c796e1bb27d2d930c7c50c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 894e2ece6b1428d6a029966de6857e1110c1b8f0
https://github.com/Perl/perl5/commit/894e2ece6b1428d6a029966de6857e1110c1b8f0
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 8e3c227327416a683c86e1668b02aa67dca83602
https://github.com/Perl/perl5/commit/8e3c227327416a683c86e1668b02aa67dca83602
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 24322d0c5fbec209fa4b17d84ea27adfeb59f4ba
https://github.com/Perl/perl5/commit/24322d0c5fbec209fa4b17d84ea27adfeb59f4ba
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 96fdcab5533b26403f1d8565ef439172df3e4fc8
https://github.com/Perl/perl5/commit/96fdcab5533b26403f1d8565ef439172df3e4fc8
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: d2fef3082bbc5efff1350ded4458cb1cd9884e98
https://github.com/Perl/perl5/commit/d2fef3082bbc5efff1350ded4458cb1cd9884e98
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: fc93d95f0df720b640d41bfb91bc68b59a74e111
https://github.com/Perl/perl5/commit/fc93d95f0df720b640d41bfb91bc68b59a74e111
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: a06742b4cf7e9b74e4541971e0ad874eedcb45ce
https://github.com/Perl/perl5/commit/a06742b4cf7e9b74e4541971e0ad874eedcb45ce
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: d43a097b228f47f7c8bb8d9c050aeebaa1e73bf4
https://github.com/Perl/perl5/commit/d43a097b228f47f7c8bb8d9c050aeebaa1e73bf4
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 020f65040acbf38b85baeffcaad805d0d89d7d6d
https://github.com/Perl/perl5/commit/020f65040acbf38b85baeffcaad805d0d89d7d6d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: d91eb06eeaaa8350e8bf8f1eb819f224df66769a
https://github.com/Perl/perl5/commit/d91eb06eeaaa8350e8bf8f1eb819f224df66769a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: dd2a2c1d325c27a8a04c18df4014f53d8c85525a
https://github.com/Perl/perl5/commit/dd2a2c1d325c27a8a04c18df4014f53d8c85525a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: b8c2a70f93873b63017909d58669ca7ce880f685
https://github.com/Perl/perl5/commit/b8c2a70f93873b63017909d58669ca7ce880f685
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: d7bf89261aab7d99a9c795903e93da1985476a26
https://github.com/Perl/perl5/commit/d7bf89261aab7d99a9c795903e93da1985476a26
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 6c45d2895d2f87f6a386c8db28054b79ddd9a298
https://github.com/Perl/perl5/commit/6c45d2895d2f87f6a386c8db28054b79ddd9a298
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 6affdb0cd5d16ca27d3ad2e64bcead6b0330f767
https://github.com/Perl/perl5/commit/6affdb0cd5d16ca27d3ad2e64bcead6b0330f767
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: ab90fff9d42d27b1bd9028d308ebab309fb4d603
https://github.com/Perl/perl5/commit/ab90fff9d42d27b1bd9028d308ebab309fb4d603
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 6fce513c92df80e7e62d0c2c0fa2292e15366d15
https://github.com/Perl/perl5/commit/6fce513c92df80e7e62d0c2c0fa2292e15366d15
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: cba74b2d5ababf56e6bb2744c32c3e08690a175e
https://github.com/Perl/perl5/commit/cba74b2d5ababf56e6bb2744c32c3e08690a175e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 206720f7b00660a34755561461bb4669369ef12b
https://github.com/Perl/perl5/commit/206720f7b00660a34755561461bb4669369ef12b
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: d25da5ade289907e977ab07a86e23914f6b40c54
https://github.com/Perl/perl5/commit/d25da5ade289907e977ab07a86e23914f6b40c54
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: a3ee621d4c83d13c9fb675b66daded2565ae9d31
https://github.com/Perl/perl5/commit/a3ee621d4c83d13c9fb675b66daded2565ae9d31
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: e61356840ee3ad1b585b2dae6b17eb783c4a931e
https://github.com/Perl/perl5/commit/e61356840ee3ad1b585b2dae6b17eb783c4a931e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: b653f91a4484eaf2ccee87421fac04a2825dae3e
https://github.com/Perl/perl5/commit/b653f91a4484eaf2ccee87421fac04a2825dae3e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 231d0e983fafbcc9cd7e907e13e7508274b4fded
https://github.com/Perl/perl5/commit/231d0e983fafbcc9cd7e907e13e7508274b4fded
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: c3332e2c6ac208beee56edbf7b8e1c4700ea4ce9
https://github.com/Perl/perl5/commit/c3332e2c6ac208beee56edbf7b8e1c4700ea4ce9
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 5839568a40ee79f435e853eea05f9c7fdaa41146
https://github.com/Perl/perl5/commit/5839568a40ee79f435e853eea05f9c7fdaa41146
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 9a93efd6416a000835ee3370673444133b05cd56
https://github.com/Perl/perl5/commit/9a93efd6416a000835ee3370673444133b05cd56
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 949b8aa6b69f7f7274ea0ac141496a1cdb97533a
https://github.com/Perl/perl5/commit/949b8aa6b69f7f7274ea0ac141496a1cdb97533a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 0bf9245cbae801f6b6a7022b3ac8bd0442e33fc5
https://github.com/Perl/perl5/commit/0bf9245cbae801f6b6a7022b3ac8bd0442e33fc5
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 2c9c56445670777864a6cdc90ad8baa6f9520220
https://github.com/Perl/perl5/commit/2c9c56445670777864a6cdc90ad8baa6f9520220
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 9969724243e5e3f08eead1b4bd81ace0a1ceebea
https://github.com/Perl/perl5/commit/9969724243e5e3f08eead1b4bd81ace0a1ceebea
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: c0b321be1d9b0f7538fe0b113cb77f4ef8d3f6c1
https://github.com/Perl/perl5/commit/c0b321be1d9b0f7538fe0b113cb77f4ef8d3f6c1
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 109deb10dff3aa54cd791a4b2fe71d9f4d3f56ec
https://github.com/Perl/perl5/commit/109deb10dff3aa54cd791a4b2fe71d9f4d3f56ec
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 57e3e126072b69625eb5d3e5eb2f6680e10c57d7
https://github.com/Perl/perl5/commit/57e3e126072b69625eb5d3e5eb2f6680e10c57d7
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 363f002fe9f364ce191be96c8af2c8b65219c41a
https://github.com/Perl/perl5/commit/363f002fe9f364ce191be96c8af2c8b65219c41a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 70aa68e937d63af4ce063e08248d177519fa68ee
https://github.com/Perl/perl5/commit/70aa68e937d63af4ce063e08248d177519fa68ee
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: a98a6043235d14ec3ca6786a3975fb3fe8eefac8
https://github.com/Perl/perl5/commit/a98a6043235d14ec3ca6786a3975fb3fe8eefac8
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 00f04b85b8ece88da788027f53f71008dd168f7d
https://github.com/Perl/perl5/commit/00f04b85b8ece88da788027f53f71008dd168f7d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 4db86dab641227d45a3017bf1cdc680fc5f34879
https://github.com/Perl/perl5/commit/4db86dab641227d45a3017bf1cdc680fc5f34879
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 27be4bdcd6439a904ff7b132dd5eb68419afd0b0
https://github.com/Perl/perl5/commit/27be4bdcd6439a904ff7b132dd5eb68419afd0b0
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 65b9745c5c2fab9f1afce6dd17596cbf6d167a37
https://github.com/Perl/perl5/commit/65b9745c5c2fab9f1afce6dd17596cbf6d167a37
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 66d2d0eed63be7dd2da4ae87e6a1bcd3afe86122
https://github.com/Perl/perl5/commit/66d2d0eed63be7dd2da4ae87e6a1bcd3afe86122
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 8b2c6c1751d9745ce27c4a420e5478ffe879fe08
https://github.com/Perl/perl5/commit/8b2c6c1751d9745ce27c4a420e5478ffe879fe08
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: eaa5ed2f1f6168daefe2158429e2f178692bd46e
https://github.com/Perl/perl5/commit/eaa5ed2f1f6168daefe2158429e2f178692bd46e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: c86c5747c8b9da331838eb2a3820b9ea0819999f
https://github.com/Perl/perl5/commit/c86c5747c8b9da331838eb2a3820b9ea0819999f
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 12e4c00e00fdd7e29b698efa510810050c47f0db
https://github.com/Perl/perl5/commit/12e4c00e00fdd7e29b698efa510810050c47f0db
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 58717c11dbdd1aed361372de12661ad39aefb8fb
https://github.com/Perl/perl5/commit/58717c11dbdd1aed361372de12661ad39aefb8fb
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: c518c0cd13d96d33b0ad3da4ea7ed4a71749f46b
https://github.com/Perl/perl5/commit/c518c0cd13d96d33b0ad3da4ea7ed4a71749f46b
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: b3c7bac55af1df748a20bc86fd3d0bf5d7acd190
https://github.com/Perl/perl5/commit/b3c7bac55af1df748a20bc86fd3d0bf5d7acd190
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 446cf7196e9934b520b6d359c5ef6a92677372c0
https://github.com/Perl/perl5/commit/446cf7196e9934b520b6d359c5ef6a92677372c0
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: cd3c764f2e855e99660f281195467aac3751108b
https://github.com/Perl/perl5/commit/cd3c764f2e855e99660f281195467aac3751108b
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 5dc6b2c3045551a62c79058db21a6f1682d6cc48
https://github.com/Perl/perl5/commit/5dc6b2c3045551a62c79058db21a6f1682d6cc48
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: b5d69ce01c15c42fdefcee387e67604e2ed14c16
https://github.com/Perl/perl5/commit/b5d69ce01c15c42fdefcee387e67604e2ed14c16
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: fc73ef059575813129169d4ab75976f20dec02d5
https://github.com/Perl/perl5/commit/fc73ef059575813129169d4ab75976f20dec02d5
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 0e38dd715b4b6816590fe2e05b66c528ebdc33d7
https://github.com/Perl/perl5/commit/0e38dd715b4b6816590fe2e05b66c528ebdc33d7
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: a65ac9e63c9e325012dccda6c2ee40fa3706c1ab
https://github.com/Perl/perl5/commit/a65ac9e63c9e325012dccda6c2ee40fa3706c1ab
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: d69e812421d5330b3cad0669ce1984a1d4ffb921
https://github.com/Perl/perl5/commit/d69e812421d5330b3cad0669ce1984a1d4ffb921
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 00b1bee4957c0b23168a7e10333bcbad4aa994a9
https://github.com/Perl/perl5/commit/00b1bee4957c0b23168a7e10333bcbad4aa994a9
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 165cc2490fdcc0716e1df6a9b0e09bbecb6a5b86
https://github.com/Perl/perl5/commit/165cc2490fdcc0716e1df6a9b0e09bbecb6a5b86
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: da98ff7c371d563e09b3a9cc5c35e9df024aebac
https://github.com/Perl/perl5/commit/da98ff7c371d563e09b3a9cc5c35e9df024aebac
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: d07b7e5d39b0a9d890360b306f909655194aa9b3
https://github.com/Perl/perl5/commit/d07b7e5d39b0a9d890360b306f909655194aa9b3
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: e68a47e7a9f7872580a07247220f8a9894888036
https://github.com/Perl/perl5/commit/e68a47e7a9f7872580a07247220f8a9894888036
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 9efcee3c0e5c6a50ca2b36b48d78c50a3a7a8239
https://github.com/Perl/perl5/commit/9efcee3c0e5c6a50ca2b36b48d78c50a3a7a8239
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 36ebe70f2a979d124dbd81c20145ec40b089a410
https://github.com/Perl/perl5/commit/36ebe70f2a979d124dbd81c20145ec40b089a410
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 66585a26dced1b601e043acc79ab002ec0ed8c15
https://github.com/Perl/perl5/commit/66585a26dced1b601e043acc79ab002ec0ed8c15
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: 28ad424605f9cc610242316804a82c0c30fc7b05
https://github.com/Perl/perl5/commit/28ad424605f9cc610242316804a82c0c30fc7b05
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: ced5749dabcfd2d071511c607655191a8758e76b
https://github.com/Perl/perl5/commit/ced5749dabcfd2d071511c607655191a8758e76b
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: b117b401bd8dd852af7a73550e26227054f7d01d
https://github.com/Perl/perl5/commit/b117b401bd8dd852af7a73550e26227054f7d01d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 88d51626f35001f59aee9bd3f7d87f9d21141f53
https://github.com/Perl/perl5/commit/88d51626f35001f59aee9bd3f7d87f9d21141f53
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 5bed704f59e1045c006b7205d965c36c6665bbcf
https://github.com/Perl/perl5/commit/5bed704f59e1045c006b7205d965c36c6665bbcf
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 62bb20f67b69f6499926557bda63e1f533010cc9
https://github.com/Perl/perl5/commit/62bb20f67b69f6499926557bda63e1f533010cc9
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 04bc89db61900a890feaed21625477db7ed20d99
https://github.com/Perl/perl5/commit/04bc89db61900a890feaed21625477db7ed20d99
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 7a7e54b5669ed58d0711e32225a5b0c35b3c1bc6
https://github.com/Perl/perl5/commit/7a7e54b5669ed58d0711e32225a5b0c35b3c1bc6
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: d0e5edae55b8bb678797f94ef97c67fafbf78530
https://github.com/Perl/perl5/commit/d0e5edae55b8bb678797f94ef97c67fafbf78530
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 4a42a7cc00d54d273c4c73b5e5f4a4c1c85e0428
https://github.com/Perl/perl5/commit/4a42a7cc00d54d273c4c73b5e5f4a4c1c85e0428
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 2fc9fcef2e4748babc9b592ebb1d9ce77c1adace
https://github.com/Perl/perl5/commit/2fc9fcef2e4748babc9b592ebb1d9ce77c1adace
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 6cf607fd74c6f36a42929273b77692b4034a4b49
https://github.com/Perl/perl5/commit/6cf607fd74c6f36a42929273b77692b4034a4b49
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 3ee5f78054ad2d668272270a098d527e1d82706f
https://github.com/Perl/perl5/commit/3ee5f78054ad2d668272270a098d527e1d82706f
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 839c5e86080bf623d76ad831d058366ec9e709d9
https://github.com/Perl/perl5/commit/839c5e86080bf623d76ad831d058366ec9e709d9
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: 5527f6fb24dc2ee1b40ecb9bd5ce02d0717dd13a
https://github.com/Perl/perl5/commit/5527f6fb24dc2ee1b40ecb9bd5ce02d0717dd13a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 8c9ee645574c24e49be48c53ef42acf2708f4a9b
https://github.com/Perl/perl5/commit/8c9ee645574c24e49be48c53ef42acf2708f4a9b
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 23a3f4762caa7b4ba90fe669961c039be07b7b49
https://github.com/Perl/perl5/commit/23a3f4762caa7b4ba90fe669961c039be07b7b49
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 5f37d7f54675974314b608d377689bedfc9dfdc4
https://github.com/Perl/perl5/commit/5f37d7f54675974314b608d377689bedfc9dfdc4
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 3dbfea6b754d3b4b28214595f3da1a5ce9ca501c
https://github.com/Perl/perl5/commit/3dbfea6b754d3b4b28214595f3da1a5ce9ca501c
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: be2cbcd625e16513c9516158fb99dd557f3183f8
https://github.com/Perl/perl5/commit/be2cbcd625e16513c9516158fb99dd557f3183f8
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 2a534b392784a31dec203c367e1adf616b078a32
https://github.com/Perl/perl5/commit/2a534b392784a31dec203c367e1adf616b078a32
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: ec903ff3e64b049fd5c4da858ab82217a8cb489a
https://github.com/Perl/perl5/commit/ec903ff3e64b049fd5c4da858ab82217a8cb489a
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: a20dafe4c3d8e850b0c4f34af6d30fa6a885988e
https://github.com/Perl/perl5/commit/a20dafe4c3d8e850b0c4f34af6d30fa6a885988e
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 5fe12f7d2196f12b2430bf9534b50d9e42bda989
https://github.com/Perl/perl5/commit/5fe12f7d2196f12b2430bf9534b50d9e42bda989
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 4b3b4fdb1761d44af775161b501cecaf48e59777
https://github.com/Perl/perl5/commit/4b3b4fdb1761d44af775161b501cecaf48e59777
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 6941985d39dabf041b804e442acc00534ec9e69d
https://github.com/Perl/perl5/commit/6941985d39dabf041b804e442acc00534ec9e69d
Author: Karl Williamson <[email protected]>
Date: 2021-05-03 (Mon, 03 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M makedef.pl
M mg.c
M perl.c
M perl.h
M proto.h
M regexec.c
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
56
Compare: https://github.com/Perl/perl5/compare/6f8c497306a1...6941985d39da
