Branch: refs/heads/yves/tests_for_20161
  Home:   https://github.com/Perl/perl5
  Commit: dcc2422a6520a2f4bab8703bc96ac4776dda7d72
      
https://github.com/Perl/perl5/commit/dcc2422a6520a2f4bab8703bc96ac4776dda7d72
  Author: Yves Orton <demer...@gmail.com>
  Date:   2022-08-27 (Sat, 27 Aug 2022)

  Changed paths:
    M t/comp/retainedlines.t

  Log Message:
  -----------
  comp/retainedlines.t - use a test case that croaks

This is to demonstrate the issue reported in GH Issue #20161,
that we leak debug data from eval statements that croak during
compilation.

We fail test when the parser croaks during compilation, but the old code
did not trigger a croak. With this change the test fails in a large
number of ways, many of which are false positives. A follow up patch
will remove the false positives, but still leave failing tests.


  Commit: 9887f343227eef26a38171bb309331e129c5b346
      
https://github.com/Perl/perl5/commit/9887f343227eef26a38171bb309331e129c5b346
  Author: Yves Orton <demer...@gmail.com>
  Date:   2022-08-27 (Sat, 27 Aug 2022)

  Changed paths:
    M t/comp/retainedlines.t

  Log Message:
  -----------
  retainedlines.t - deterministic results and fixup tests under failure

The existing logic is only "correct" when all the tests pass. When they
fail the tests are revealed to be non-determinstic. The other problem is
that once a single test case fails and leaks an entry in the stash the
following tests are all contaminated and trigger "false failures". The
combination makes things look much more broken than they are.

This patch fixes the tests so that they are deterministic and the
"leaking" between test cases is stopped.


Compare: https://github.com/Perl/perl5/compare/dcc2422a6520%5E...9887f343227e

Reply via email to