Branch: refs/heads/yves/fix_diag_t
  Home:   https://github.com/Perl/perl5
  Commit: e9c0707dfb78db3173378db0df3201192708406b
      
https://github.com/Perl/perl5/commit/e9c0707dfb78db3173378db0df3201192708406b
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M dquote.c
    M op.c
    M os2/os2ish.h
    M perl.h
    M t/porting/diag.t

  Log Message:
  -----------
  porting/diag.t - improved parsing a bit

The "multiline" logic of diag.t was getting confused by define
statements that would define a symbol to call an error function but not
end in ";", this would then slurp potentially many lines errorenously,
potentially absorbing more than one message. The multi-line logic also
would undef $listed_as and lose the diag_listed_as data in some
circumstances.

Fixing those issues revealed some interesting cases. To fix one of them
I defined a new noop macro in perl.h to help: PERL_DIAG_WARN_SYNTAX(),
which helps the diag.t parser identify messages without needing to be
actually part of a specific message line. These macros are noops, they
just return their argument, but they help hint to diag.t what is going
on. Maybe in the future this can be reworked to be more generic, there
are other similar cases that are not covered.

Interestingly fixing this bug meant that at least one message that used
to be erroneously picked up was no longer identified or tested. This was
replaced with a PERL_DIAG_DIE_SYNTAX() wrapper.


  Commit: f7fdeb79eafee7f294e1c2e841fd235894d43648
      
https://github.com/Perl/perl5/commit/f7fdeb79eafee7f294e1c2e841fd235894d43648
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M t/porting/diag.t

  Log Message:
  -----------
  diag.t - show what needs to be removed to un-TODO a test

The old message was a little less than helpful. The new
one shows the file and line to remove.


  Commit: 4e7d9da1a6e76ced2d74afac050f27f5bb83ca57
      
https://github.com/Perl/perl5/commit/4e7d9da1a6e76ced2d74afac050f27f5bb83ca57
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M pod/perldiag.pod
    M t/porting/diag.t

  Log Message:
  -----------
  perldiag.pod - Document "Filehandle .. reopened for input"

I wanted to see why a given diagnostics was not listed in perldiag.pod,
so I documented it. Turns out it was in the TODO list. :-)


Compare: https://github.com/Perl/perl5/compare/4dece40353c6...4e7d9da1a6e7

Reply via email to