Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 2e75d796b38ec046115bbbb9a22c7a966467ade5 https://github.com/Perl/perl5/commit/2e75d796b38ec046115bbbb9a22c7a966467ade5 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023)
Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Use mnemonic instead of repeating expr This expression is repeated in several places; best to name it for clarity and ease of change. Commit: 841a3e1bca89544d115c2d2d3df1c96d27172a15 https://github.com/Perl/perl5/commit/841a3e1bca89544d115c2d2d3df1c96d27172a15 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Remove misleading comments cygwin works on UTF-16, not UCS-2, nor UTF-8 Commit: ac4290d01742ee1228041e7467ed23414ebfbafc https://github.com/Perl/perl5/commit/ac4290d01742ee1228041e7467ed23414ebfbafc Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Remove memory leaks These mallocs weren't getting freed. Commit: a435da2b160255de4884b0d007ef0d9d93ec203b https://github.com/Perl/perl5/commit/a435da2b160255de4884b0d007ef0d9d93ec203b Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Change wide_to_utf8() to call utf16_to_utf8() The latter function is in the core, and doesn't require the locale to be changed, unlike before. Commit: 457ba501e6d4253da0c5acc6c45c96c598b3f605 https://github.com/Perl/perl5/commit/457ba501e6d4253da0c5acc6c45c96c598b3f605 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Call wide_to_utf8() There are two places that do the same thing as wide_to_utf8(), in different ways. Use the single, common function Commit: 73bdb838da96b52da71c9080ff6fdc2e2c88ea23 https://github.com/Perl/perl5/commit/73bdb838da96b52da71c9080ff6fdc2e2c88ea23 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Narrow scope of setlocale The previous commit caused the locale not to have to be changed and locked for as long as before. Narrow the change to the scope needed. Commit: c3be9bd4d181af38c0c9e2ae3c5ee51d49651eff https://github.com/Perl/perl5/commit/c3be9bd4d181af38c0c9e2ae3c5ee51d49651eff Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Change variable names This makes the names consistent in the two parallel functions, in preparation for folding the two into one. This maps win_path => converted_path wbuf => wsrc wpath => wconverted Commit: d7c2c45e0afe114a6fc55207b26d268ec4affea6 https://github.com/Perl/perl5/commit/d7c2c45e0afe114a6fc55207b26d268ec4affea6 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Refactor some expressions These cause the long flag name to only be mentioned once. Commit: bba8d7cfa7a094d55326d7a9cfebd73fb8ab2a35 https://github.com/Perl/perl5/commit/bba8d7cfa7a094d55326d7a9cfebd73fb8ab2a35 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Use SvPVx in both places One function uses this form; the parallel function doesn't. Not having delved into the details, the 'x' form is safer, so should be used in the same situation in both functions. Commit: 03fc59afb4069bd5f569c5c4fb2e7b4293d948a9 https://github.com/Perl/perl5/commit/03fc59afb4069bd5f569c5c4fb2e7b4293d948a9 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M pod/perldiag.pod Log Message: ----------- Add cygwin warning to perldiag Commit: 0880e953fabd23c1207fab60ed2647e122a4e99a https://github.com/Perl/perl5/commit/0880e953fabd23c1207fab60ed2647e122a4e99a Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Change a size_t value from int to STRLEN Commit: ea18e4f378a48b29f06181f2c32101dfc7205ba0 https://github.com/Perl/perl5/commit/ea18e4f378a48b29f06181f2c32101dfc7205ba0 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Fold two nearly identical functions into one These functions are to convert from a windows path to posix, and vice versa. Except for the direction, the process is identical. But the two functions that go in a single direction have diverged slightly over time. The previous few commits were integrating the changes in one version into the opposite one. The two versions are now sufficiently alike, with only white-space, comment, and directionality differences, so the functions can be combined. A new common function is created, and the other two functions merely wrap it, calling it with a parameter to indicate the direction. The result includes the union of all the comments from the two sides. Commit: 5e4b76a1263a3865a4d21af871474e3c6e790362 https://github.com/Perl/perl5/commit/5e4b76a1263a3865a4d21af871474e3c6e790362 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin: Convert to use utf8_to_utf16() This now-core function simplifies things, and removes the need for changing the locale. Commit: a8a9fd0a672789f304a0ecb83240b4e6d34f1d1f https://github.com/Perl/perl5/commit/a8a9fd0a672789f304a0ecb83240b4e6d34f1d1f Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Add utf8_to_wide_extra_len() This function is like utf8_to_wide, but has an additional parameter that reserves extra space. It thus is a superset of utf8_to_wide() which changes to use it with 0 extra space needed. And there is other code that parallels utf8_to_wide() but needs extra space reserved. That code is converted to use this (new, now common) function, thus simplifying things. Commit: 93425aaa4c6367b09eef90a3a7bb2e7c9ab072ff https://github.com/Perl/perl5/commit/93425aaa4c6367b09eef90a3a7bb2e7c9ab072ff Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Add comments, branch prediction Commit: 7dccff44c3ee4d9e1d201c6892ec9c38746975b7 https://github.com/Perl/perl5/commit/7dccff44c3ee4d9e1d201c6892ec9c38746975b7 Author: Karl Williamson <k...@cpan.org> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M cygwin/cygwin.c Log Message: ----------- cygwin.c: Fold two similar code paths into one These differ only in which source they operate on. Compare: https://github.com/Perl/perl5/compare/c05434dd5e12...7dccff44c3ee