Branch: refs/heads/yves/tidy_embed_fnc
Home: https://github.com/Perl/perl5
Commit: add24d8948b1968264236a0cd592a60c969c4866
https://github.com/Perl/perl5/commit/add24d8948b1968264236a0cd592a60c969c4866
Author: Yves Orton <demer...@gmail.com>
Date: 2023-02-17 (Fri, 17 Feb 2023)
Changed paths:
M regen/tidy_embed.pl
Log Message:
-----------
embed.fnc - sort entries alphabetically by function name.
This is actually a library sort (lc with underbars removed), followed by a
lexicographical sort. Comment lines are sticky to the line that follows
them.
Somehow the original version of this patch was missed in my earlier work on
tidy_embed.pl, I think I messed up a rebase somehow. I noticed it was missing
when I realized that new entries werent being sorted into place correctly.
While this patch creates a fair bit of churn in the file right now, long
term it will make it easier to use. Also note that the *output* files
have not changed, which validates that the patch did not break anything.
Commit: 9a93998d485054bc88c4126e13f73dced852528f
https://github.com/Perl/perl5/commit/9a93998d485054bc88c4126e13f73dced852528f
Author: Yves Orton <demer...@gmail.com>
Date: 2023-02-17 (Fri, 17 Feb 2023)
Changed paths:
M embed.fnc
Log Message:
-----------
embed.fnc - updated as per previous commit (squash before committing)
Commit: 1280179a54c501672fadaf025b2a268c669b1f38
https://github.com/Perl/perl5/commit/1280179a54c501672fadaf025b2a268c669b1f38
Author: Yves Orton <demer...@gmail.com>
Date: 2023-02-17 (Fri, 17 Feb 2023)
Changed paths:
M regen/HeaderParser.pm
M regen/embed.pl
Log Message:
-----------
embed.pl - sort and dedupe flags in embef.fnc as part of tidy
This ensures we use a canonical string for each possible flag variant,
which makes it easier to search for flags with a given flag signature.
It also exposed a mutex bug in flag handling which caused
PerlEnv_putenv to be improperly marked as static, when it is in fact
static inline.
To validate there aren't any issues like this remaining in the script
I set it up so the flags were shuffled during processing and ran
embed.pl in a loop for a while and none of the output files changed,
so I assume there are no further such issues.
This patch also includes some basic validation of the flags so that if
someone misses a line continuation the following lines are not treated
as a new definition without any flags. I also ran perltidy on it
according to the rules contained within the file.
Commit: 86344c764f89676ffd11047d28936270cf48eedb
https://github.com/Perl/perl5/commit/86344c764f89676ffd11047d28936270cf48eedb
Author: Yves Orton <demer...@gmail.com>
Date: 2023-02-17 (Fri, 17 Feb 2023)
Changed paths:
M embed.fnc
Log Message:
-----------
embed.fnc - updated as per previous commit (squash before committing)
Compare: https://github.com/Perl/perl5/compare/e78674502645...86344c764f89
