Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 6958877b566164e52ecf4dcfd1dae7929dff6fcd https://github.com/Perl/perl5/commit/6958877b566164e52ecf4dcfd1dae7929dff6fcd Author: Tony Cook <t...@develop-help.com> Date: 2023-09-25 (Mon, 25 Sep 2023)
Changed paths: M locale.c Log Message: ----------- stop coverity complaining about copying uninitialised tm_gmtoff, tm_zone This was reported in the two callers to S_ints_to_tm(): Using uninitialized value mytm.tm_gmtoff when calling S_ints_to_tm. Using uninitialized value mytm.tm_zone when calling S_ints_to_tm. cids 464354, 464357 Commit: cad68b1ca7c2937b13001e8ecd76fb3b2a238b20 https://github.com/Perl/perl5/commit/cad68b1ca7c2937b13001e8ecd76fb3b2a238b20 Author: Tony Cook <t...@develop-help.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M regcomp_debug.c Log Message: ----------- regdump_intflags: there is no PL_reg_intflags_name[REG_INTFLAGS_NAME_SIZE] Yes, this is an old report, from 2014. cid29034 Commit: 53d7a807365401c3df5913bf518050b9d3c45806 https://github.com/Perl/perl5/commit/53d7a807365401c3df5913bf518050b9d3c45806 Author: Tony Cook <t...@develop-help.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M regcomp_debug.c Log Message: ----------- regcomp_debug.c: change a mis-use of ASSUME() to STATIC_ASSERT_STMT() As mauke points out in #21490 the compiler "knows" all of the constants here at compile-time, so the ASSUME()s here do nothing. I suspect the intent here was to ensure that we never overflow the capacity of the flags parameter, which we can check at compile-time with STATIC_ASSERT_STMT(). mauke also suggested using CHAR_BIT instead of 8, but Configure probes for CHARBITS and the perl core generally uses CHARBITS, so use that here too. Compare: https://github.com/Perl/perl5/compare/41d0ddc96a06...53d7a8073654