Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: fadb7dd857c5119808b8e1d8672b3ae37b79ea46
https://github.com/Perl/perl5/commit/fadb7dd857c5119808b8e1d8672b3ae37b79ea46
Author: Karl Williamson <[email protected]>
Date: 2024-11-28 (Thu, 28 Nov 2024)
Changed paths:
M t/porting/podcheck.t
Log Message:
-----------
podcheck.t: Add a couple comments
Commit: ee535f66290810cc42ee4c747239c5b5abfe441c
https://github.com/Perl/perl5/commit/ee535f66290810cc42ee4c747239c5b5abfe441c
Author: Karl Williamson <[email protected]>
Date: 2024-11-28 (Thu, 28 Nov 2024)
Changed paths:
M t/porting/podcheck.t
Log Message:
-----------
podcheck.t: Call proper SUPER methood
end_head1() extends SUPER::end_head1(). So call that. It turns out
that this didn't matter currently, but is bad practice.
Commit: a7fc95f0f1ca95accdb13f2aa78ca498a8d6b99a
https://github.com/Perl/perl5/commit/a7fc95f0f1ca95accdb13f2aa78ca498a8d6b99a
Author: Karl Williamson <[email protected]>
Date: 2024-11-28 (Thu, 28 Nov 2024)
Changed paths:
M t/porting/podcheck.t
Log Message:
-----------
podcheck.t: Do actions for all =head levels
Prior to this commit, the resetting of certain variables was done just
for =head1. But there is nothing special about this level for these
variables, so do it for all.
Commit: 0dfde78ad82d7770dbf4512ee1f35dbb0c238785
https://github.com/Perl/perl5/commit/0dfde78ad82d7770dbf4512ee1f35dbb0c238785
Author: Karl Williamson <[email protected]>
Date: 2024-11-28 (Thu, 28 Nov 2024)
Changed paths:
M t/porting/podcheck.t
Log Message:
-----------
podcheck.t: Any module we find is valid to link to
podcheck looks through the source distribution for pod. It skips
internal checking of ones in /cpan (unless a command line option says
to. If you do this, be prepared for finding gobs of problems in
these!).
But any such module found is fair game to be linked to by modules we do
examine. It is a simple matter to add them to the list of known modules
that can be linked to.
Prior to this commit this was done surreptitiously by extending the
Pod::Checker node() method. But a future commit will take this away.
Commit: 6366047f7f4329ccea2e60a12556051f9729baf1
https://github.com/Perl/perl5/commit/6366047f7f4329ccea2e60a12556051f9729baf1
Author: Karl Williamson <[email protected]>
Date: 2024-11-28 (Thu, 28 Nov 2024)
Changed paths:
M t/porting/podcheck.t
Log Message:
-----------
podcheck.t: Fix multiple link targets bug
podcheck.t would wrongly warn about duplicate link targets. It is
ambiguous if you have, say
=head1 foo
...
=item foo
and then try to create a link to 'foo'. Which 'foo' should it go to?
So podcheck looks for such ambiguous links. However, it was incorrectly
warning on
=head1 foo
...
=item * foo
The latter is a bullet list, which is not an appropriate link target.
The logic was flawed in the node() method, when it encountered the
second foo, it didn't realize it was for a bullet list, and pushed it
onto a list which caused the count to be larger than 1, which caused it
later to think there were two link targets with the same name.
The solution here is to instead note that linkable targets are only in
=headN or definition lists. The acquisition of the names of them are
moved to the methods that get called upon the termination of each of
these by the parsing routines. The count is incremented at that point.
This means the node() method extension no longer does anything useful
and is removed; as well as an auxiliary field, linkable_item. We no
longer need to distinguish between =headN and =item.
Compare: https://github.com/Perl/perl5/compare/aaee595bc251...6366047f7f43
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications
