Branch: refs/heads/smoke-me/tonyc/querylocale-always-thx
Home: https://github.com/Perl/perl5
Commit: 944382fa0eb7613f767c7d5bbfc011825f57fade
https://github.com/Perl/perl5/commit/944382fa0eb7613f767c7d5bbfc011825f57fade
Author: Tony Cook <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale_2024_l always needs THX
It calls savepv() and SAVEFREEPV()
Detected by non-DEBUGGING build failures on Solaris:
locale.c: In function 'const char* S_querylocale_2024_l(int, locale_t, line_t)':
perl.h:262:17: error: 'my_perl' was not declared in this scope
262 | # define aTHX my_perl
| ^~~~~~~
perl.h:267:25: note: in expansion of macro 'aTHX'
267 | # define aTHX_ aTHX,
| ^~~~
embed.h:639:61: note: in expansion of macro 'aTHX_'
639 | # define savepv(a) Perl_savepv(aTHX_ a)
| ^~~~~
locale.c:2088:11: note: in expansion of macro 'savepv'
2088 | ret = savepv(ret);
| ^~~~~~
locale.c:2070:64: warning: unused parameter 'caller_line' [-Wunused-parameter]
2070 | S_querylocale_2024_l(int category, locale_t locale_obj, line_t
caller_line)
|
~~~~~~~^~~~~~~~~~~
make: Fatal error: Command failed for target `locale.o'
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications