Branch: refs/heads/smoke-me/jkeenan/t-harness-revamp-20261008
Home: https://github.com/Perl/perl5
Commit: ea289a5e203c370b4c15df17d617a49c37df7d16
https://github.com/Perl/perl5/commit/ea289a5e203c370b4c15df17d617a49c37df7d16
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/TEST
M t/harness
M t/porting/test_testlist.t
Log Message:
-----------
t/TEST: Change /dump_?tests/ to 'dump_manifested_tests'
Currently, the '-dumptests' switch in t/TEST only reports tests
listed in the MANIFEST. In preparation for the addition/restoration of
tests generated via 'make' to the list of tests run by t/TEST, we need
to name things more precisely.
t/harness: For consistency with t/TEST, rename '@tests' and similar to
'@manifested_tests,' i.e., tests listed in MANIFEST.
Commit: ed41f85c02a07aed0a697223ccb3dfe6d880e85b
https://github.com/Perl/perl5/commit/ed41f85c02a07aed0a697223ccb3dfe6d880e85b
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/TEST
Log Message:
-----------
Rather than work on global @ARGV, clone and rename it
Currently, @ARGV starts out with a mixture of command-line switches and files to
be tested. We then do lots of pushing onto it and re-writing elements.
This means that during debugging saying x \@ARGV doesn't show us what we
originally passed to the program. Instead, assign to a lexically-scoped
variable. Rename some other variables similarly.
Bring other aspects of t/TEST up to at least 2005-level best practices,
e.g., use lexical file and directory handles; use 3-argument 'open'.
Use 3-argument 'open'.
Commit: 0aa1867aef15d2a5b1d1f03b842ab1be3eb1f1ff
https://github.com/Perl/perl5/commit/0aa1867aef15d2a5b1d1f03b842ab1be3eb1f1ff
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/TEST
Log Message:
-----------
Add generated test files to list to be tested
Commit: 52274e5d8b9f0ca3e38b05d46536682d821eff00
https://github.com/Perl/perl5/commit/52274e5d8b9f0ca3e38b05d46536682d821eff00
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/TEST
Log Message:
-----------
Corrections to t/TEST only
Leaving t/harness unchanged.
In t/harness, to change @manifested_tests (back) to @tests (making
similar changes to dump_manifested_tests) causes test failures in
t/porting/test_testlist.t.
So this commit makes changes in t/TEST suggested during code review but,
for the time being, leaves t/harness untouched.
On the one hand, that enables t/porting/test_testlist.t to PASS. It
also keeps the generated tests from running when you are running
t/porting/test_testlist.t
On the other hand, it means that certain identifiers within t/harness
are misleadingly named. As Tony pointed out in code review, the list of
tests accumulated during t/harness are not gleaned from the MANIFEST
and, hence, do not really qualify as "manifested" tests.
During development of GH #24918 I was trying to leave
t/porting/test_testlist.t as untouched as possible. That was because
that test program, introduced in 2023, had as its objective:
# Test that t/TEST and t/harness test the same files, and that all the
# test files (.t files) listed in MANIFEST are tested by both.
To achieve that objective, test_testlist.t relies on the assumption that
each of t/TEST and t/harness have a command-line switch named
`-dumptests` that will produced the same results.
Commit: 0918f0daa1c5a46698f8245f926d16503b81f946
https://github.com/Perl/perl5/commit/0918f0daa1c5a46698f8245f926d16503b81f946
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/harness
M t/porting/test_testlist.t
Log Message:
-----------
test_testlist.t: Temporarily skip all tests
So as to accommodate reversion of 'manifested_tests' in t/harness to
just 'tests' ... and that's so as not to get in our way when
implementing generated tests in t/harness.
Commit: afac117434703c20873c5eb7ef02b9d75bc7e4af
https://github.com/Perl/perl5/commit/afac117434703c20873c5eb7ef02b9d75bc7e4af
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/TEST
Log Message:
-----------
Restore name of dump_manifested_tests() to dump_tests()
There's nothing within this subroutine that is specific to
manifested_tests. If we simply call it dump_tests() we can use it
within t/harness without redefining it.
Commit: 07875ad482e7f706c4b78b0c7644a37ef85156a4
https://github.com/Perl/perl5/commit/07875ad482e7f706c4b78b0c7644a37ef85156a4
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/harness
Log Message:
-----------
Uncuddle some else's
Add inline comments where we're pulling in subroutines defined in
t/TEST.
Some other small tidying.
Commit: 6852a3d1faaa7a8a1b76ebcbcc9780f17ddd8b05
https://github.com/Perl/perl5/commit/6852a3d1faaa7a8a1b76ebcbcc9780f17ddd8b05
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/harness
Log Message:
-----------
Move declaration of variable closer to where used
Commit: 004e18b13172da17c3adec3f042663ee44a4dcf6
https://github.com/Perl/perl5/commit/004e18b13172da17c3adec3f042663ee44a4dcf6
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/harness
M t/porting/test_testlist.t
Log Message:
-----------
Reactivate (simpler) t/porting/test_testlist.t
At this point, we're comparing the manifested tests found by t/TEST to
match all the tests found by t/harness. We have not yet implemented
testing of generated tests in t/harness, so we're not yet concerned with
the number or identity of generated tests found by t/TEST.
Commit: 2922aebbffa3cd10869542e926c8485a3b85d325
https://github.com/Perl/perl5/commit/2922aebbffa3cd10869542e926c8485a3b85d325
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/harness
Log Message:
-----------
t/harness: Locate generated tests and test them
Commit: 94588f7dd0a444de3e918e5e7a5f1b891e8a5114
https://github.com/Perl/perl5/commit/94588f7dd0a444de3e918e5e7a5f1b891e8a5114
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/harness
Log Message:
-----------
Don't mix specific tests with generated tests
Commit: 13759c5cca5ed13d6e6363d9e59feb800b81013a
https://github.com/Perl/perl5/commit/13759c5cca5ed13d6e6363d9e59feb800b81013a
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/porting/test_testlist.t
Log Message:
-----------
Pause test_testlist.t temporarily
Commit: 35e70f3d3e4098b4fd7921fede3311422b922f5f
https://github.com/Perl/perl5/commit/35e70f3d3e4098b4fd7921fede3311422b922f5f
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/TEST
Log Message:
-----------
Reposition identification of generated tests
Commit: fc4e886acfc02e0dae2acb5a4255d05c17cb8713
https://github.com/Perl/perl5/commit/fc4e886acfc02e0dae2acb5a4255d05c17cb8713
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/harness
Log Message:
-----------
_compute_tests_and_ordering: Improve encapsulation
%total_time was used only within _compute_tests_and_ordering() and
sort_by_execution_order. The latter, in turn, was/is only called within
_compute_tests_and_ordering(). Bring declaration of %total_time inside
_compute_tests_and_ordering(). Transform sort_by_execution_order()
into a lexical sub declared within _compute_tests_and_ordering().
Commit: 05c70a405b5655c6d7850776c63c2668c81fcafc
https://github.com/Perl/perl5/commit/05c70a405b5655c6d7850776c63c2668c81fcafc
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/porting/test_testlist.t
Log Message:
-----------
test_testlib.t: Add testing subroutines and use them
Add 3 subroutines which can be used to test a given list of test files
via t/TEST, t/harness and ./runtests choose, respectively.
Add 2 subroutines used to create lookup tables within the 3
aforementioned subroutines.
Rearrange the file so that subroutines are defined beneath the test code
and superseded tests are placed in an END block. (We'll get back to
them later.)
Commit: acee6c60d942cc0a1a42af96303926b5a6b40134
https://github.com/Perl/perl5/commit/acee6c60d942cc0a1a42af96303926b5a6b40134
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/porting/test_testlist.t
Log Message:
-----------
Test generated tests for dist/Devel-PPPort
Using recently developed testing subroutines. Add inline comments;
deleted commented-out code.
Commit: a452150675ad9be3fae0149119ad219e2453776a
https://github.com/Perl/perl5/commit/a452150675ad9be3fae0149119ad219e2453776a
Author: James E Keenan <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M t/porting/test_testlist.t
Log Message:
-----------
test_testlist.t: Restore pre-5.43.4 tests
Suitably tweaked.
Compare: https://github.com/Perl/perl5/compare/ea289a5e203c%5E...a452150675ad
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications