On Wed 17 Dec 2003 15:41, Dorner Thomas <[EMAIL PROTECTED]> wrote:
> Hi Nicholas,
> 
> you're the current integrator now?  (The last patches I sent went to Jarkko,
> but Peter Prymmer forwarded your call for patches to the perl-mvs mailing
> list and so ...)
> 
> OK, I've 4 patches:
> 
> Number 1 is a bit awkward as it's a patch to Configure.  Under BS2000 we
> have the problem that the differen Encode-Module generated for the asian
> languages can't be linked together due to name clashes.  The easiest way to
> solve this for me was this patch (and I don't think there is any use of
> BS2000 in Asia with asian languages supported - BS2000 knows only its EBCDIC
> variants of the various ISO-Latins).
>  <<perl-21911-1>> 

Looking at this, I'd say that you should be able to craft this into
hints/posix-bc.sh
I'm not saying it's wrong, but we'd rather not change Configure if the hints
can do it. If you do, please add the comments you've stated here

> Patch 2 is needed due to floating point limits of the BS2000 machines.  And
> as this is base test, the whole test suite would abort without it.
>  <<perl-21911-2>> 

rgs, this is OK, should go in

> Patch 3 got us in serveral tests, the Bison parser has some limits here
> which can be extended with compilation options.
>  <<perl-21911-3>> 

Looks fine

> Patch 4 is also coming from the Bison parser which writes "parse error"
> instead of "syntax error".
>  <<perl-21911-4>> 

I don't trust myself to this one. Doesn't look wrong, but I leave it up to
others to apply/reject (with reason)
My main restriction is that if you are able to take bison restrictions away in
patch 3 why the would not promote to the tests. If you catch it here in the
test, and some other (non-core module) would expect the `normal' behaviour,
we're in trouble

I cannot apply right now, but if there is no comment, 2 and 3 will go in
tomorrow

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0, & 5.9.x, and 806 on  HP-UX 10.20 & 11.00, 11i,
   AIX 4.3, SuSE 8.2, and Win2k.           http://www.cmve.net/~merijn/
http://archives.develooper.com/[EMAIL PROTECTED]/   [EMAIL PROTECTED]
send smoke reports to: [EMAIL PROTECTED], QA: http://qa.perl.org

Reply via email to