Rafael Garcia-Suarez wrote:
>Steve Hay wrote:
>
>
>>==== //depot/perl/mg.c#316 - C:\p5p\bleadperl\mg.c ====
>>@@ -145,7 +145,7 @@
>> Perl_mg_get(pTHX_ SV *sv)
>> {
>> const I32 mgs_ix = SSNEW(sizeof(MGS));
>>- const bool was_temp = SvTEMP(sv);
>>+ const bool was_temp = (const bool)SvTEMP(sv);
>>
>>
>
>I'd drop the const here.
>
>
>
>>==== //depot/perl/util.c#440 - C:\p5p\bleadperl\util.c ====
>>@@ -2816,7 +2816,7 @@
>> if (strEQ(scriptname, "-"))
>> dosearch = 0;
>> if (dosearch) { /* Look in '.' first. */
>>- char *cur = scriptname;
>>+ char *cur = (char *)scriptname;
>>
>>
>
>I'd rather add a const.
> const char *cur = scriptname;
>
>Otherwise, seems applicable :)
>
Thanks for the comments. I've applied the patch with the changes you
suggested (change #24096).
- Steve
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are
confidential and intended for the addressee(s) only. If you have received this
message in error or there are any problems, please notify the sender
immediately. The unauthorized use, disclosure, copying or alteration of this
message is strictly forbidden. Note that any views or opinions presented in
this email are solely those of the author and do not necessarily represent
those of Radan Computational Ltd. The recipient(s) of this message should
check it and any attached files for viruses: Radan Computational will accept no
liability for any damage caused by any virus transmitted by this email.
