On Wed, Mar 30, 2005 at 11:47:12PM -0700, Murugan K wrote: > Index: ./Artistic > *** ./Artistic Mon Jul 20 06:57:14 1998 > --- ./Artistic Tue Sep 28 13:43:59 2004 > *************** > *** 1,131 ****
You appear to be sending a patch here to change the line endings or whitespace on the Artistic licence. Please be careful not to change the whitespace in files or parts of files that your are not editing. > diff -c /dev/null '/home/kmurugan/workarea/perl_current/NetWare/start.c' > Index: ./NetWare/start.c > *** ./NetWare/start.c Thu Jan 1 05:30:00 1970 > --- ./NetWare/start.c Mon Aug 16 14:35:57 2004 > *************** > *** 0 **** > --- 1,119 ---- > + /* > + +----------------------------------------------------------------------+ > + | PHP Version 5 | > + +----------------------------------------------------------------------+ > + | Copyright (c) 1997-2004 The PHP Group | > + +----------------------------------------------------------------------+ > + | This source file is subject to version 3.0 of the PHP license, | > + | that is bundled with this package in the file LICENSE, and is | > + | available through the world-wide-web at the following url: | > + | http://www.php.net/license/3_0.txt. | > + | If you did not receive a copy of the PHP license and are unable to | > + | obtain it through the world-wide-web, please send a note to | > + | [EMAIL PROTECTED] so we can mail you a copy immediately. > | > + +----------------------------------------------------------------------+ > + | Author: Novell, Inc. | > + +----------------------------------------------------------------------+ > + */ We're not able to accept code under the PHP licence into the core distribution. Could you check to see whether it can be dual licensed GPL/ Artistic consistent with the rest of the Perl core source code? > *** ./Porting/config_H Thu Apr 22 00:26:16 2004 > --- ./Porting/config_H Mon Aug 16 14:35:57 2004 > *************** > *** 7,13 **** > * that running config_h.SH again will wipe out any changes you've made. > * For a more permanent change edit config.sh and rerun config_h.SH. > * > ! * $Id: Config_h.U,v 3.0.1.5 1997/02/28 14:57:43 ram Exp $ > */ > > /* We still have RCS IDs in the perl source. Some of the RCS IDs are actually used and can't be changed - the Perl core incorporates some modules maintained externally by people using CVS, and of them some use the RCS ID to get the module $VERSION. (eg Encode) Please could you trim your patch to avoid including any changes that are to our RCS ids. Removing all of these: > Index: ./ext/Digest/MD5/MD5.xs > Prereq: 1.42 > *** ./ext/Digest/MD5/MD5.xs Mon Dec 8 22:05:44 2003 > --- ./ext/Digest/MD5/MD5.xs Mon Aug 16 14:35:38 2004 > *************** > *** 1,4 **** > ! /* $Id: MD5.xs,v 1.42 2003/12/06 22:35:16 gisle Exp $ */ > > /* > * This library is free software; you can redistribute it and/or > --- 1,4 ---- > ! /* $Id: MD5.xs,v 1.1.1.1 2004/08/16 09:05:38 smscm Exp $ */ > > /* > * This library is free software; you can redistribute it and/or would drastically reduce the size of your patch. (And reduce the amount that I'm having to wade through) > diff -c '/home/kmurugan/perl-5.8.4/ext/File/Glob/Glob.xs' > '/home/kmurugan/workarea/perl_current/ext/File/Glob/Glob.xs' > Index: ./ext/File/Glob/Glob.xs > *** ./ext/File/Glob/Glob.xs Wed Apr 10 06:11:41 2002 > --- ./ext/File/Glob/Glob.xs Fri Aug 27 12:54:51 2004 > *************** > *** 2,8 **** > --- 2,14 ---- > #include "perl.h" > #include "XSUB.h" > > + //#ifdef __NETWARE__ > + //#include "glob.h" > + //#define GLOB_ALPHASORT 0x2000 /* Alphabetic, not ASCII sort, like csh. > */ > + //#define GLOB_NOCASE 0x1000 /* NetWare glob.h doesn't support this */ > + //#else > #include "bsd_glob.h" > + //#endif Please use C89 comments only. (/* */) Perl has to compile on platforms with C89 compilers, so C99-isms such as // aren't going to work. > diff -c '/home/kmurugan/perl-5.8.4/lib/File/Basename.pm' > '/home/kmurugan/workarea/perl_current/lib/File/Basename.pm' > Index: ./lib/File/Basename.pm > *** ./lib/File/Basename.pm Thu Aug 14 11:30:52 2003 > --- ./lib/File/Basename.pm Wed Aug 25 14:02:45 2004 > *************** > *** 1,289 **** > ! package File::Basename; > --- 1,289 ---- > ! package File::Basename; You appear to have sent a patch that changes the entire file for lib/File/Basename.pm Is this because the line endings have changed in your local copy? Likewise lib/File/Copy.pm I think that removing all the patch hunks that just change RCS IDs would cut the size of your patch by 80-90% Nicholas Clark
