Jan Dubois <[EMAIL PROTECTED]> writes: >On Mon, 18 Apr 2005, Steve Hay wrote: >> >The OP in bug#33664 seems to have worked out a solution to this bug >> >already, which I need to look at sometime. >> > >> OK, I've just committed a change (24242) which I believe fixes bug >> #33664, and the test script above. > >One reason this problem hasn't been detected before including it in >the maintenance branch is that the ICMP tests are always skipped >on Windows NT and above. The attached patch only skips the tests >when we don't have admin privs instead. > >Cheers, >-Jan > >Index: lib/Net/Ping/t/110_icmp_inst.t >--- lib/Net/Ping/t/110_icmp_inst.t.~1~ Mon Apr 18 20:09:11 2005 >+++ lib/Net/Ping/t/110_icmp_inst.t Mon Apr 18 20:09:11 2005 >@@ -15,9 +15,11 @@ > # Everything loaded fine > ok 1; > >+require Win32 if $^O eq "MSWin32"; >+ > if (($> and $^O ne 'VMS' and $^O ne 'cygwin') > or ($^O eq 'MSWin32' >- and Win32::IsWinNT()) >+ and !Win32::IsAdminUser())
Did you mean to drop the IsWinNT() test - i.e. does it work on Win9X now?
