On Mon, Feb 14, 2005 at 09:33:17PM -0000, Rafael Garcia-Suarez wrote: > Ton Hospel wrote in perl.perl5.porters : > > Here is a redo of the unpack part of the patches as a result of the > > discussion here. Things of note:
> Thanks, applied to bleadperl as change #23966, with a tweak : This patch has the rather unfortunate effect of causing 3598 lines of Malformed UTF-8 warnings from t/op/pack.t when testing with a UTF-8 locale; 1799 each from lines 135 and 136; $ (cd t; LC_ALL=fr_FR.UTF-8 PERL_UNICODE="" ./perl op/pack.t >/dev/null ) 2>&1 | grep -c 136 1799 $ (cd t; LC_ALL=fr_FR.UTF-8 PERL_UNICODE="" ./perl op/pack.t >/dev/null ) 2>&1 | grep -c 135 1799 Actually, it looks like that number depends on the size of my perl binary... Silenced with a binmode in change 24251. I also added qw(FATAL all) to the use warnings, plus appropriate local disabling, to try to stop things like this getting missed in the future. Nicholas Clark
