On Tue, Apr 19, 2005 at 10:59:14PM +0200, Marcus Holland-Moritz wrote:
> On 2005-03-28, at 23:09:50 +0100, Dave Mitchell wrote:
> > The change I've committed below expands the behaviour of
> >     -DDEBUG_LEAKING_SCALARS
> 
> I just ran the testsuite for one of my modules under valgrind and noticed
> a new error that seems to originate from your patch.

Thanks for spotting this. Fixed by the change below.

-- 
The Enterprise's efficient long-range scanners detect a temporal vortex
distortion in good time, allowing it to be safely avoided via a minor
course correction.
    -- Things That Never Happen in "Star Trek" #21

Change 24255 by [EMAIL PROTECTED] on 2005/04/19 23:31:52

        DEBUG_LEAKING_SCALARS could use the value of a freed PL_op

Affected files ...

... //depot/perl/op.c#665 edit

Differences ...

==== //depot/perl/op.c#665 (text) ====

@@ -313,6 +313,10 @@
 
     op_clear(o);
     FreeOp(o);
+#ifdef DEBUG_LEAKING_SCALARS
+    if (PL_op == o)
+       PL_op = Nullop;
+#endif
 }
 
 void

Reply via email to