On Fri, May 20, 2005 at 08:26:01AM -0500, Craig A. Berry wrote: > --- lib/Carp.t;-0 Mon May 16 10:47:48 2005 > +++ lib/Carp.t Fri May 20 08:14:12 2005 > @@ -157,6 +157,7 @@ > } > > # Check that croak() and confess() don't clobber $! > +$TODO = "VMS exit status semantics don't work this way" if $^O eq 'VMS';
You really ought to localize that. Patch attached. -- Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern Ahh email, my old friend. Do you know that revenge is a dish that is best served cold? And it is very cold on the Internet!
--- lib/Carp.t 2005/05/20 20:07:14 1.1 +++ lib/Carp.t 2005/05/20 20:08:15 @@ -4,6 +4,8 @@ require './test.pl'; } +my $Is_VMS = $^O eq 'VMS'; + use Carp qw(carp cluck croak confess); plan tests => 21; @@ -156,8 +158,18 @@ } } -# Check that croak() and confess() don't clobber $! -runperl(prog => 'use Carp; [EMAIL PROTECTED]; $!=42; croak(q{Dead})', stderr => 1); -is($?>>8, 42, 'croak() doesn\'t clobber $!'); -runperl(prog => 'use Carp; [EMAIL PROTECTED]; $!=42; confess(q{Dead})', stderr => 1); -is($?>>8, 42, 'confess() doesn\'t clobber $!'); + +{ + local $TODO = "VMS exit status semantics don't work this way" if $Is_VMS; + + # Check that croak() and confess() don't clobber $! + runperl(prog => 'use Carp; [EMAIL PROTECTED]; $!=42; croak(q{Dead})', + stderr => 1); + + is($?>>8, 42, 'croak() doesn\'t clobber $!'); + + runperl(prog => 'use Carp; [EMAIL PROTECTED]; $!=42; confess(q{Dead})', + stderr => 1); + + is($?>>8, 42, 'confess() doesn\'t clobber $!'); +}