On Sun, Jun 26, 2005 at 06:35:49PM -0700, Michael G Schwern wrote:
> On Mon, Jun 27, 2005 at 05:10:02AM +0400, Alexey Tourbin wrote:
> > +} or do {
> > +    require DynaLoader;
> > +    local @ISA = qw(DynaLoader);
> > +    bootstrap Storable $VERSION;
> > +};
> >  1;
> >  __END__
> >  #
> > End of patch
> > 
> > Since Storable is also on CPAN, the code is conditinal.  "local @ISA"
> > is tricky, I think I've seen this elsewhere.
> 
> That doesn't seem right.  It means Storable only inherits from DynaLoader
> in the scope of that bootstrap call and I don't see why that's necessary. 
> It wasn't necessary before. 
> 
> "push @ISA, qw(DynaLoader)" is safer and equivalent to what was happening 
> before the patch.

AIUI the only time it needs to be ISA DynaLoader is during the
bootstrap call.

Reply via email to