Andy Lester wrote:
>On Mon, Jun 27, 2005 at 12:52:14PM -0500, Andy Lester ([EMAIL PROTECTED])
>wrote:
>
>
>>>Perhaps you need to resync?
>>>
>>>
>>Oh whoops, yes, I need to send patch.
>>
Thanks. I now see the two PERL_UNUSED_VAR calls at the end of pp_last()
in pp_ctl.c, and the "use before definition" warning that I originally
had has gone away, even without the "optype = 0" initialization,
presumably because the PERL_UNUSED_VAR call comes last.
I'm left with two "use before definition" warnings in pp_leavewrite() in
pp_sys.c -- one for "newsp" and one for "gimme". Moving the
PERL_UNUSED_VAR calls to the end there too also makes them go away, so
I've applied that as change .
Makes me wonder if all PERL_UNUSED_VAR calls should go at the ends of
functions rather than the beginnings.
There is also a new "use before definition" warning regarding "gimme" in
pp_ctl.c line 2825 - the PUSHBLOCK call below:
PL_op = &dummy;
PL_op->op_type = OP_ENTEREVAL;
PL_op->op_flags = 0; /* Avoid uninit warning. */
PUSHBLOCK(cx, CXt_EVAL|(IN_PERL_COMPILETIME ? 0 : CXp_REAL), SP);
PUSHEVAL(cx, 0, Nullgv);
This is caused by the following hunk of change 24997:
@@ -2767,7 +2768,7 @@
dVAR; dSP; /* Make POPBLOCK work. */
PERL_CONTEXT *cx;
SV **newsp;
- I32 gimme = 0; /* SUSPECT - INITIALZE TO WHAT? NI-S */
+ I32 gimme;
I32 optype;
OP dummy;
OP *rop;
Should I put that initialization back to silence the warning, or is
there a better fix?
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are
confidential and intended for the addressee(s) only. If you have received this
message in error or there are any problems, please notify the sender
immediately. The unauthorized use, disclosure, copying or alteration of this
message is strictly forbidden. Note that any views or opinions presented in
this email are solely those of the author and do not necessarily represent
those of Radan Computational Ltd. The recipient(s) of this message should
check it and any attached files for viruses: Radan Computational will accept no
liability for any damage caused by any virus transmitted by this email.
