On Sat, Jul 09, 2005 at 04:21:05PM +0200, Piotr Fusik wrote:
> Here are some cosmetic changes of perlfunc:
> 
> 1. Documented no-operand versions of chdir, eval, exit, gmtime.
> 2. Normalized C<foo()> to foo().
> 3. Normalized $foo to C<$foo>.
> 4. Changed "=item import" to "=item import (LIST)".

This isn't all that was done.  I see an additional change right away:

@@ -1198,7 +1200,7 @@
 =item do BLOCK
 
 Not really a function.  Returns the value of the last command in the
-sequence of commands indicated by BLOCK.  When modified by a loop
+sequence of commands indicated by BLOCK.  When modified by the C<while> loop
 modifier, executes the BLOCK once before testing the loop condition.
 (On other statements the loop modifiers test the conditional first.)
 

Which isn't true.  do handles both "while" and "until".  I think the original
wording should hold.  Possibly perlsyn clarifies what a "loop modifier" is.

To avoid slips like this in the future, broad formatting changes should be 
provided separate of any other changes.  Several smaller, simpler patches 
are easier to review.


-- 
Michael G Schwern     [EMAIL PROTECTED]     http://www.pobox.com/~schwern
Reality is that which, when you stop believing in it, doesn't go away.
        -- Phillip K. Dick

Reply via email to