On Tue, 12 Jul 2005 13:18:34 -0700, Michael G Schwern <[EMAIL PROTECTED]>
wrote:
> On Tue, Jul 12, 2005 at 12:11:33PM +0100, Andrew Benham wrote:
> > Perl 5.8.6
> >
> > File /usr/lib/perl5/5.8.6/i386-linux-thread-multi/IO/Socket.pm on
> > Fedora Core 4.
> >
> > Line 407 (which is part of the POD) states:
> >
> > $sock->read(1024,$data) until $sock->atmark;
> >
> > I don't believe the arguments to the read() method are in the
> > correct order.
>
> You're right, they're not.
Thanks, applied as change #25131
Next time, could you try to provide the patch against a more complete path?
ext/IO/lib/IO/Socket.pm
that makes it easier to apply
> --- lib/IO/Socket.pm 2005/07/12 20:18:07 1.1
> +++ lib/IO/Socket.pm 2005/07/12 20:18:12
> @@ -404,7 +404,7 @@
> use IO::Socket;
>
> my $sock = IO::Socket::INET->new('some_server');
> - $sock->read(1024,$data) until $sock->atmark;
> + $sock->read($data, 1024) until $sock->atmark;
>
> Note: this is a reasonably new addition to the family of socket
> functions, so all systems may not support this yet. If it is
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using Perl 5.6.2, 5.8.0, 5.8.5, & 5.9.2 on HP-UX 10.20, 11.00 & 11.11,
AIX 4.3 & 5.2, SuSE 9.2 & 9.3, and Cygwin. http://www.cmve.net/~merijn
Smoking perl: http://www.test-smoke.org, perl QA: http://qa.perl.org
reports to: [EMAIL PROTECTED], perl-qa@perl.org
