On 15 Jul 2005 08:41:10 -0700, Gisle Aas <[EMAIL PROTECTED]> wrote: > "H.Merijn Brand" <[EMAIL PROTECTED]> writes: > > > On Fri, 15 Jul 2005 02:57:05 -0700, Michael G Schwern <[EMAIL PROTECTED]> > > wrote: > > > > > On Fri, Jul 15, 2005 at 02:32:50AM -0700, Gisle Aas wrote: > > > + ok($@ =~ /^The fchmod function is unimplemented at/, "fchmod is > > > unimplemented"); > > > > + ok($@ =~ /^The fchown function is unimplemented at/, "fchown is > > > > unimplemented"); > > > > + ok($@ =~ /^The fchdir function is unimplemented at/, "fchdir is > > > > unimplemented"); > > > > > > Minor nit. Those are better written with like(): > > > > > > like( $@, qr/^The fchdir function is unimplementated at/, > > > "fchdir is unimplemented" ); > > > > Do I apply the patch, or do you have enough tuits to re-submit with > > like's? > > It is easier for me if you apply the patch asis and then I'll come > back with a followup patch to fix up these. It would be even easier > for me if you just edit these 3 lines after you applied the patch :)
OK, I did just that in change #25157 Thanks guys -- H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/) using Perl 5.6.2, 5.8.0, 5.8.5, & 5.9.2 on HP-UX 10.20, 11.00 & 11.11, AIX 4.3 & 5.2, SuSE 9.2 & 9.3, and Cygwin. http://www.cmve.net/~merijn Smoking perl: http://www.test-smoke.org, perl QA: http://qa.perl.org reports to: [EMAIL PROTECTED], perl-qa@perl.org
