On Sat, Jul 16, 2005 at 02:51:14PM -0700, Earl Hood wrote: > It appears that cp_if_diff() was supposed to be coded > to only warn about non-existent file do to the initial > -f $from check. But all that is printed is a warning from > the check, and the following open() call fails. > > As it is coded, the -f $from is basically an expensive noop. > > What follows is a patch that if -f $from fails, a warning > is printed, and the routine returns without aborting > execution.
Thanks, I'll patch that in. > NOTE: All this came about due to the metafile target for > MakeMaker is dependent on create_distdir (which is something > added in later releases). The problem is if META.yml does > not exist (since the developer knows that MakeMaker will > do it automatically), metafile target always fails due > to create_distdir failing since META.yml is in the MANIFEST > which metafile target is supposed to create. The solution for this is to delete META.yml from your MANIFEST and let MakeMaker add it to the copy in the distdir. -- Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern You are wicked and wrong to have broken inside and peeked at the implementation and then relied upon it. -- tchrist in <[EMAIL PROTECTED]>
