On Fri, Mar 15, 2002 at 06:10:11PM -0500, Simon Glover wrote:
>
> On Fri, 15 Mar 2002, Simon Cozens wrote:
>
> > You didn't resync. I just updated packout.c to take this function out.
> > There's a reason step 1 included CVS updating. :)
>
> Yep, just figured that out for myself - I rsync'd, rather than doing a
> cvs checkout, and not realizing it doesn't do quite the same thing.
>
> With a proper fresh checkout, everything builds OK here, but I've run
> into another problem: Parrot::Assembler:Utils uses Text::Balanced, but
> that's not a core module in 5.6.x and earlier. Weren't we trying to
> stay compatible with Perl's back to 5.5.3 ?
Along these lines, here's a patch for anyone else on the 5.5.3 train
to revert the our's to 'use vars' in Makefile.PL.
dean.
--- Packfile.pm Fri Mar 15 17:36:25 2002
+++ Packfile.pm.bak Fri Mar 15 14:15:14 2002
@@ -1,6 +1,6 @@
package Parrot::Packfile;
-require 5.005_03;
+require 5.005_62;
use strict;
use warnings;
use Carp;
@@ -9,9 +9,7 @@
require DynaLoader;
use AutoLoader;
-use vars qw(@ISA %EXPORT_TAGS @EXPORT_OK @EXPORT $VERSION);
-
-@ISA = qw(Exporter DynaLoader);
+our @ISA = qw(Exporter DynaLoader);
# Items to export into callers namespace by default. Note: do not export
# names by default without a very good reason. Use EXPORT_OK instead.
@@ -20,16 +18,16 @@
# This allows declaration use Parrot::Packfile ':all';
# If you do not need this, moving things directly into @EXPORT or @EXPORT_OK
# will save memory.
-%EXPORT_TAGS = ( 'all' => [ qw(
+our %EXPORT_TAGS = ( 'all' => [ qw(
) ] );
-@EXPORT_OK = ( @{ $EXPORT_TAGS{'all'} } );
+our @EXPORT_OK = ( @{ $EXPORT_TAGS{'all'} } );
-@EXPORT = qw(
+our @EXPORT = qw(
);
-$VERSION = '0.01';
+our $VERSION = '0.01';
sub AUTOLOAD {
# This AUTOLOAD is used to 'autoload' constants from the constant()
@@ -37,7 +35,7 @@
# to the AUTOLOAD in AutoLoader.
my $constname;
- $AUTOLOAD;
+ our $AUTOLOAD;
($constname = $AUTOLOAD) =~ s/.*:://;
croak "& not defined" if $constname eq 'constant';
my $val = constant($constname, @_ ? $_[0] : 0);
