On Fri, Jun 25, 2004 at 02:43:14PM +0200, Leopold Toetsch wrote: > Nicholas Clark <[EMAIL PROTECTED]> wrote: > > On Fri, Jun 25, 2004 at 09:46:53AM +0200, Leopold Toetsch wrote: > >> > >> Yep. I'd swap function names as well as argument order, so that > >> everything matches the vtable prototype. > > > > void Parrot_PMC_set_intkey_intval(Parrot_INTERP interp, Parrot_PMC > > pmc, Parrot_Int value, Parrot_Int key) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > "as well as argument order"
D'oh. Silly me. > But I don't care, as long as vtables remain ;) I committed the change I suggested (change parameter order so that value is always last) and then committed the change to ponie to keep it in sync, and then realised I'd not checked the entire parrot source tree for any other instances of these functions. docs/pdds/pdd11_extending.pod:7 Er. I'm changing the design here. I guess I had better ask Dan - is this OK? Nicholas Clark
Index: docs/pdds/pdd11_extending.pod =================================================================== RCS file: /cvs/public/parrot/docs/pdds/pdd11_extending.pod,v retrieving revision 1.4 diff -d -u -r1.4 pdd11_extending.pod --- docs/pdds/pdd11_extending.pod 16 Mar 2004 22:13:31 -0000 1.4 +++ docs/pdds/pdd11_extending.pod 25 Jun 2004 19:50:11 -0000 @@ -135,7 +135,7 @@ Assign the passed-in Parrot_STRING to the passed-in PMC. =item C<Parrot_PMC_set_string_intkey(interp, -pmc, Parrot_STRING value, Parrot_Int key)> +pmc, Parrot_Int key, Parrot_STRING value)> Keyed version of C<Parrot_PMC_set_string>. Assigns C<value> to the PMC stored at element <key> of the passed-in PMC. @@ -144,12 +144,12 @@ Assign the passed-in pointer to the passed-in PMC. -=item C<Parrot_PMC_set_pointer_intkey(interp, pmc, void *value, Parrot_Int key)> +=item C<Parrot_PMC_set_pointer_intkey(interp, pmc, Parrot_Int key, void *value)> Keyed version of C<Parrot_PMC_set_pointer>. Assigns C<value> to the PMC stored at element <key> of the passed-in PMC. -=item C<Parrot_PMC_set_pmc_intkey(interp, pmc, Parrot_PMC value, Parrot_Int key)> +=item C<Parrot_PMC_set_pmc_intkey(interp, pmc, Parrot_Int key, Parrot_PMC value)> Assigns C<value> to the PMC stored at element <key> of the passed-in PMC. @@ -158,7 +158,7 @@ Assign the passed-in Parrot integer to the passed-in PMC. =item C<Parrot_PMC_set_intval_intkey(interp, -pmc, Parrot_Int value, Parrot_Int key)> +pmc, Parrot_Int key, Parrot_Int value)> Keyed version of C<Parrot_PMC_set_intval>. Assigns C<value> to the PMC stored at element <key> of the passed-in PMC. @@ -168,7 +168,7 @@ Assign the passed-in Parrot number to the passed-in PMC. =item C<Parrot_PMC_set_numval_intkey(interp, -pmc, Parrot_Float value, Parrot_Int key)> +pmc, Parrot_Int key, Parrot_Float value)> Keyed version of C<Parrot_PMC_set_numval>. Assigns C<value> to the PMC stored at element <key> of the passed-in PMC. @@ -179,7 +179,7 @@ assign it to the passed-in PMC. =item C<Parrot_PMC_set_cstring_intkey(interp, -pmc, const char *value, Parrot_Int key)> +pmc, Parrot_Int key, const char *value)> Keyed version of C<Parrot_PMC_set_cstring>. Converts C<value> to a Parrot_STRING and assigns it to the PMC stored at element <key> of the @@ -195,7 +195,7 @@ Parrot_STRING should be assumed to contain garbage. =item C<Parrot_PMC_set_cstringn_intkey(interp, -pmc, const char *value, Parrot_int length, Parrot_Int key)> +pmc, const char *value, Parrot_Int key, Parrot_int length)> Keyed version of C<Parrot_PMC_set_cstringn>. Converts the first C<length> characters of C<value> to a Parrot_STRING and assigns the resulting string
