On Mon 18 Oct 2004 16:34, "H.Merijn Brand" <[EMAIL PROTECTED]> wrote:
> On Fri 15 Oct 2004 05:20, Michael G Schwern <[EMAIL PROTECTED]> wrote:
> > Its about freakin' time.  Has it really been two years since the last
> > stable release?  Yes it has.
> > 
> > This is 0.48_02 plus a minor test and MANIFEST fix.
> > 
> > INCOMPATIBILITIES WITH PREVIOUS VERSIONS
> > * Threading is no longer automatically turned on.  You must turn it on
> > before you use
> >   Test::More if you want it.  See BUGS and CAVEATS for info.
> 
> Please consider 0.50 very soon, in which you fix 'err' calls that are an
> obvious mistake given defined-or functionality in blead and 5.8.x-dor:

That would be too easy to call. here's a patch ...

All tests successful, 2 tests and 7 subtests skipped.
Files=46, Tests=290, 11 wallclock secs ( 8.79 cusr +  0.97 csys =  9.76 CPU)

--8<--- TS49_01.diff
diff -r -pu Test-Simple-0.49/t/fail-more.t Test-Simple-0.49_01/t/fail-more.t
--- Test-Simple-0.49/t/fail-more.t      2004-10-15 05:07:33 +0200
+++ Test-Simple-0.49_01/t/fail-more.t   2004-10-18 16:37:22 +0200
@@ -38,7 +38,7 @@ sub ok ($;$) {
 }
 
 
-sub main::err ($) {
+sub main::Err ($) {
     my($expect) = @_;
     my $got = $err->read;
 
@@ -65,7 +65,7 @@ $tb->use_numbers(0);
 # Preserve the line numbers.
 #line 38
 ok( 0, 'failing' );
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 38)
 ERR
 
@@ -74,7 +74,7 @@ is( "foo", "bar", 'foo is bar?');
 is( undef, '',    'undef is empty string?');
 is( undef, 0,     'undef is 0?');
 is( '',    0,     'empty string is 0?' );
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 40)
 #          got: 'foo'
 #     expected: 'bar'
@@ -93,7 +93,7 @@ ERR
 isnt("foo", "foo", 'foo isnt foo?' );
 isn't("foo", "foo",'foo isn\'t foo?' );
 isnt(undef, undef, 'undef isnt undef?');
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 45)
 #     'foo'
 #         ne
@@ -111,7 +111,7 @@ ERR
 #line 48
 like( "foo", '/that/',  'is foo like that' );
 unlike( "foo", '/foo/', 'is foo unlike foo' );
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 48)
 #                   'foo'
 #     doesn't match '/that/'
@@ -122,21 +122,21 @@ ERR
 
 # Nick Clark found this was a bug.  Fixed in 0.40.
 like( "bug", '/(%)/',   'regex with % in it' );
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 60)
 #                   'bug'
 #     doesn't match '/(%)/'
 ERR
 
 fail('fail()');
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 67)
 ERR
 
 #line 52
 can_ok('Mooble::Hooble::Yooble', qw(this that));
 can_ok('Mooble::Hooble::Yooble', ());
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 52)
 #     Mooble::Hooble::Yooble->can('this') failed
 #     Mooble::Hooble::Yooble->can('that') failed
@@ -149,7 +149,7 @@ isa_ok(bless([], "Foo"), "Wibble");
 isa_ok(42,    "Wibble", "My Wibble");
 isa_ok(undef, "Wibble", "Another Wibble");
 isa_ok([],    "HASH");
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 55)
 #     The object isn't a 'Wibble' it's a 'Foo'
 #     Failed test ($0 at line 56)
@@ -168,7 +168,7 @@ cmp_ok( 1,     '&&', 0    , '       &&' 
 cmp_ok( 42,    '==', "foo", '       == with strings' );
 cmp_ok( 42,    'eq', "foo", '       eq with numbers' );
 cmp_ok( undef, 'eq', 'foo', '       eq with undef' );
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 68)
 #          got: 'foo'
 #     expected: 'bar'
@@ -201,7 +201,7 @@ my $Errno_String = $!.'';
 #line 80
 cmp_ok( $!,    'eq', '',    '       eq with stringified errno' );
 cmp_ok( $!,    '==', -1,    '       eq with numerified errno' );
-err( <<ERR );
+Err( <<ERR );
 #     Failed test ($0 at line 80)
 #          got: '$Errno_String'
 #     expected: ''
diff -r -pu Test-Simple-0.49/t/harness_active.t Test-Simple-0.49_01/t/harness_active.t
--- Test-Simple-0.49/t/harness_active.t 2004-10-15 05:07:33 +0200
+++ Test-Simple-0.49_01/t/harness_active.t      2004-10-18 16:37:48 +0200
@@ -37,7 +37,7 @@ sub ok ($;$) {
 }
 
 
-sub main::err ($) {
+sub main::Err ($) {
     my($expect) = @_;
     my $got = $err->read;
 
@@ -63,13 +63,13 @@ Test::More->builder->no_ending(1);
 
 #line 62
     fail( "this fails" );
-    err( <<ERR );
+    Err( <<ERR );
 #     Failed test ($0 at line 62)
 ERR
 
 #line 72
     is( 1, 0 );
-    err( <<ERR );
+    Err( <<ERR );
 #     Failed test ($0 at line 72)
 #          got: '1'
 #     expected: '0'
@@ -81,7 +81,7 @@ ERR
                    
 #line 71
     fail( "this fails" );
-    err( <<ERR );
+    Err( <<ERR );
 
 #     Failed test ($0 at line 71)
 ERR
@@ -89,7 +89,7 @@ ERR
 
 #line 84
     is( 1, 0 );
-    err( <<ERR );
+    Err( <<ERR );
 
 #     Failed test ($0 at line 84)
 #          got: '1'
-->8---

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.3, & 5.9.x, and 809 on  HP-UX 10.20 & 11.00, 11i,
   AIX 4.3, SuSE 9.0, and Win2k.           http://www.cmve.net/~merijn/
http://archives.develooper.com/[EMAIL PROTECTED]/   [EMAIL PROTECTED]
send smoke reports to: [EMAIL PROTECTED], QA: http://qa.perl.org

Attachment: TS.diff
Description: Binary data

Reply via email to