On Saturday 02 October 2004 12:49, Leopold Toetsch wrote: > Does this patch help? No, it makes things worse:
--- without-patch.txt 2004-10-03 14:35:58.824775096 +0200 +++ with-patch.txt 2004-10-03 14:35:37.843964664 +0200 @@ -30,7 +30,12 @@ # expected: '500500 # 500500 # ' -ok 6 - detach +not ok 6 - detach +# Failed test (t/pmc/threads.t at line 257) +# 'thread +# ' +# doesn't match '/(done\nthread\n)|(thread\ndone\n)/ +# ' not ok 7 - share a PMC # Failed test (t/pmc/threads.t at line 285) # got: 'thread @@ -73,4 +78,4 @@ # ' ok 10 # skip no shared PerlStrings yet ok 11 # skip no shared PerlStrings yet -# Looks like you failed 6 tests of 11. +# Looks like you failed 7 tests of 11. without-patch.txt: $ perl -Ilib t/pmc/threads.t 1..11 ok 1 - interp identity not ok 2 - thread type 1 # Failed test (t/pmc/threads.t at line 61) # got: 'thread 1 # ' # expected: 'thread 1 # main 10 # ' not ok 3 - thread type 2 # Failed test (t/pmc/threads.t at line 98) # got: 'ok 1 # ok 2 # hello from 1 thread # ParrotThread tid 1 # Sub # ' # expected: 'ok 1 # ok 2 # hello from 1 thread # ParrotThread tid 1 # Sub # from 10 interp # ' ok 4 - thread - kill not ok 5 - join, get retval # Failed test (t/pmc/threads.t at line 189) # got: '' # expected: '500500 # 500500 # ' not ok 6 - detach # Failed test (t/pmc/threads.t at line 257) # 'thread # ' # doesn't match '/(done\nthread\n)|(thread\ndone\n)/ # ' not ok 7 - share a PMC # Failed test (t/pmc/threads.t at line 285) # got: 'thread # 20 # ' # expected: 'thread # 20 # done # 21 # ' not ok 8 - multi-threaded # Failed test (t/pmc/threads.t at line 320) # got: '3 # 1 # 2 # 3 # done thread # ' # expected: '3 # 1 # 2 # 3 # done thread # done main # ' not ok 9 - multi-threaded strings via SharedRef # Failed test (t/pmc/threads.t at line 368) # got: '3 # ok 1 # ok 2 # ok 3 # done thread # ' # expected: '3 # ok 1 # ok 2 # ok 3 # done thread # done main # ' ok 10 # skip no shared PerlStrings yet ok 11 # skip no shared PerlStrings yet # Looks like you failed 7 tests of 11. without-patch.txt: $ perl -Ilib t/pmc/threads.t 1..11 ok 1 - interp identity not ok 2 - thread type 1 # Failed test (t/pmc/threads.t at line 61) # got: 'thread 1 # ' # expected: 'thread 1 # main 10 # ' not ok 3 - thread type 2 # Failed test (t/pmc/threads.t at line 98) # got: 'ok 1 # ok 2 # hello from 1 thread # ParrotThread tid 1 # Sub # ' # expected: 'ok 1 # ok 2 # hello from 1 thread # ParrotThread tid 1 # Sub # from 10 interp # ' ok 4 - thread - kill not ok 5 - join, get retval # Failed test (t/pmc/threads.t at line 189) # got: '' # expected: '500500 # 500500 # ' ok 6 - detach not ok 7 - share a PMC # Failed test (t/pmc/threads.t at line 285) # got: 'thread # 20 # ' # expected: 'thread # 20 # done # 21 # ' not ok 8 - multi-threaded # Failed test (t/pmc/threads.t at line 320) # got: '3 # 1 # 2 # 3 # done thread # ' # expected: '3 # 1 # 2 # 3 # done thread # done main # ' not ok 9 - multi-threaded strings via SharedRef # Failed test (t/pmc/threads.t at line 368) # got: '3 # ok 1 # ok 2 # ok 3 # done thread # ' # expected: '3 # ok 1 # ok 2 # ok 3 # done thread # done main # ' ok 10 # skip no shared PerlStrings yet ok 11 # skip no shared PerlStrings yet # Looks like you failed 6 tests of 11. jens
