On Sun, 23 Apr 2006, Bernhard Schmalhofer wrote: > Will Coleda schrieb: > > > This change was made here: > > > > r11744 | bernhard | 2006-02-26 05:55:39 -0500 (Sun, 26 Feb 2006) | 7 lines > > > > Bernhard, was the upgrade to 5.8 intentional and necessary? > > In February I was fairly sure that Perl 5.8.0 was already required. But I must > have mixed that up > as I can't find that mentioned on p6i.
> > The reason for making an explicit check was that I didn't recall whether > 'our' was introduced in 5.6.0 or 5.8.0. As 'our' was introduced in 5.6.0, > I have lowered the requirements for Configure.pl to 5.006. Thanks, but, alas, it now fails at Determining whether ICU is installed....................................no.Perl v5.8.0 required--this is only v5.6.2, stopped at lib/Parrot/Revision.pm line 25. The patch included below changes lib/Parrot/Revision.pm and lib/Parrot/Distribution.pm back to 5.006, and appears to be the minimal change needed to get back to building with perl-5.6.x. Looking further, the following files still require 5.008: ./languages/m4/lib/Parrot/Test/M4/Gnu.pm:use 5.008; ./languages/m4/lib/Parrot/Test/M4/PIR.pm:use 5.008; ./languages/m4/lib/Parrot/Test/M4.pm:use 5.008; ./languages/m4/tools/scrutinize.pl:use 5.008; I haven't looked in languages/m4 for a long time, so I don't have any useful comment on those. ./lib/Pod/Simple/TranscodeSmart.pm:use 5.008; This contains the singularly unhelpful comment: ## Anything before 5.8.0 is GIMPY! I have no idea what that was intended to mean. ./t/codingstd/cppcomments.t:use 5.008; Offhand, I don't see why ./t/codingstd/cppcomments.t really needs 5.008, but I haven't had time check it out carefully. ./tools/dev/check_source_standards.pl:use 5.008; ./tools/dev/mk_manifest_and_skip.pl:use 5.008; These are developer tools; their requirements needn't be the same as those required for ordinary users to build parrot. As before, I have no strong opinion on which version to use, but the main parrot README certainly ought to reflect reality. diff -r -u parrot-current/lib/Parrot/Distribution.pm parrot-andy/lib/Parrot/Distribution.pm --- parrot-current/lib/Parrot/Distribution.pm Tue Mar 14 19:15:06 2006 +++ parrot-andy/lib/Parrot/Distribution.pm Mon Apr 24 12:07:49 2006 @@ -31,7 +31,7 @@ use strict; use warnings; -use 5.008; +use 5.006; use Data::Dumper; use ExtUtils::Manifest; diff -r -u parrot-current/lib/Parrot/Revision.pm parrot-andy/lib/Parrot/Revision.pm --- parrot-current/lib/Parrot/Revision.pm Sat Mar 4 19:15:04 2006 +++ parrot-andy/lib/Parrot/Revision.pm Mon Apr 24 12:07:43 2006 @@ -22,7 +22,7 @@ use strict; use warnings; -use 5.008; +use 5.006; our $svn_entries = undef; -- Andy Dougherty [EMAIL PROTECTED]