# New Ticket Created by  Ron Blaschke 
# Please include the string:  [perl #39914]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=39914 >


Problem: Most of the t/pmc/file.t tests fail because of the Slashing
Madness; Win32 likes backslashed paths, which don't work well with
interpolated strings.

Failed Test  Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t\pmc\file.t    5  1280     7    5  71.43%  1-2 5-7
2 subtests skipped.
Failed 1/1 test scripts, 0.00% okay. 5/7 subtests failed, 28.57% okay.


Solution: Attached patch replaces all double quoted filenames with
single quoted, bringing the test down to a single failure ("File exists"
during rename).

t\pmc\file....ok 1/7
t\pmc\file....NOK 6#     Failed test (t\pmc\file.t at line 212)
#          got: 'File exists
# current instr.: 'main' pc 33 (D:\src\Parrot\trunk\t\pmc\file_6.pir:11)
# '
#     expected: 'ok
# ok
# '
# '.\parrot.exe -b --gc-debug  "D:\src\Parrot\trunk\t\pmc\file_6.pir"'
failed with exit code 1
# Looks like you failed 1 test of 7.
t\pmc\file....dubious
        Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 6
        Failed 1/7 tests, 85.71% okay (less 2 skipped tests: 4 okay, 57.14%)
Failed Test  Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t\pmc\file.t    1   256     7    1  14.29%  6
2 subtests skipped.
Failed 1/1 test scripts, 0.00% okay. 1/7 subtests failed, 85.71% okay.


Changed Files:
    t/pmc/file.t

Ron

Index: t/pmc/file.t
===================================================================
--- t/pmc/file.t        (revision 13432)
+++ t/pmc/file.t        (working copy)
@@ -49,7 +49,7 @@
 .sub main :main
         \$P1 = new .File
 
-        \$S1 = "$xpto"
+        \$S1 = '$xpto'
         \$I1 = \$P1."is_dir"(\$S1)
 
         if \$I1 goto ok1
@@ -81,7 +81,7 @@
 .sub main :main
         \$P1 = new .File
 
-        \$S1 = "$xpto"
+        \$S1 = '$xpto'
         \$I1 = \$P1."is_file"(\$S1)
         \$I1 = !\$I1
 
@@ -91,7 +91,7 @@
 ok1:
         print "ok 1\\n"
 
-        \$S1 = "$otpx"
+        \$S1 = '$otpx'
         \$I1 = \$P1."is_file"(\$S1)
 
         if \$I1 goto ok2
@@ -119,7 +119,7 @@
 .sub main :main
         \$P1 = new .File
 
-        \$S1 = "$lotpx"
+        \$S1 = '$lotpx'
         \$I1 = \$P1."is_link"(\$S1)
 
         if \$I1 goto ok1
@@ -127,7 +127,7 @@
 ok1:
         print "ok 1\\n"
 
-        \$S1 = "$otpx"
+        \$S1 = '$otpx'
         \$I1 = \$P1."is_link"(\$S1)
         \$I1 = !\$I1
         if \$I1 goto ok2
@@ -154,7 +154,7 @@
 .sub main :main
         \$P1 = new .File
 
-        \$S1 = "$xptol"
+        \$S1 = '$xptol'
         \$I1 = \$P1."is_link"(\$S1)
 
         if \$I1 goto ok1
@@ -162,7 +162,7 @@
 ok1:
         print "ok 1\\n"
 
-        \$S1 = "$xpto"
+        \$S1 = '$xpto'
         \$I1 = \$P1."is_link"(\$S1)
         \$I1 = !\$I1
         if \$I1 goto ok2
@@ -181,8 +181,8 @@
 # test copy
 pir_output_is(<<"CODE", <<"OUT", "Test copy for files");
 .sub main :main
-       \$S1 = "$otpx"
-       \$S2 = "$otpxcopy"
+       \$S1 = '$otpx'
+       \$S2 = '$otpxcopy'
 
        \$P1 = new .File
        \$P2 = new .OS
@@ -211,8 +211,8 @@
 # test rename
 pir_output_is(<<"CODE", <<"OUT", "Test rename for files");
 .sub main :main
-       \$S1 = "$otpx"
-       \$S2 = "$otpxcopy"
+       \$S1 = '$otpx'
+       \$S2 = '$otpxcopy'
 
        \$P1 = new .File
        \$P2 = new .OS

Reply via email to