jerry gay wrote:
On 4/12/07, Ron Blaschke <[EMAIL PROTECTED]> wrote:
Attached is a proposed patch to change the libparrot names and locations
for Windows. I have tested the changes for "core" Parrot on Win32
Visual C++, Cygwin GCC, MinGW GCC and Ubuntu GCC.
<snip reasoning>
this looks fabulous. thank you for providing your strategy, and the
detailed references. however, there are some minor problems.
Thanks! Any thoughts are greatly appreciated.
Index: tools/build/ln_rel_sf.pl
===================================================================
+
+sub usage {
+ my ($arg) = @_;
+ print "Missing argument: $arg\n";
+ print "usage: ln_rel_sf <target> <source>\n";
+ print " target existing destination of link\n";
+ print " source link source to be created\n";
+
+ exit 1;
+}
+
+my ($target, $source) = @ARGV;
+
+if (!defined $target) {
+ usage('target');
+}
+
+if (!defined $source) {
+ usage('source');
+}
+
+
the above logic misses the case where there are too many arguments.
i notice you haven't provided tests, either--that's not a reason for
rejection, just a note that we need to enter a CAGE ticket to write
some after applying this.
True, I should really improve this.
- # If we are building shared, need to include dynamic
libparrot.lib, otherwise
+
+ # If we are building shared, need to include dynamic
parrot.lib, otherwise
# the static libparrot.lib.
this code section and this comment in particular interests me. it
shows me that the name of the dynamic lib is different than the static
lib. this reminds me of some time ago when static/dynamic builds of
parrot were overhauled, allowing either type to be built. i always
wondered if we could build *both*. do you think this patch gets us
closer to building both static and dynamic parrot in the same build?
The patch doesn't change that. Previously, the static library was built
at F<blib/lib/libparrot.lib>, the import library at F<libparrot.lib> (no
blib/lib here!). Now it's F<blib/lib/libparrot.lib> and
F<blib/lib/parrot.lib>, respectively.
11.04.2007 20:58 19.226.530 libparrot.lib
11.04.2007 19:43 2.685.438 parrot.lib
Both libraries get built during make, but I'm not sure if libparrot is
usable. Are we talking about a statically linked parrot.exe? I can
look into this if you like.
Ron
