tewk wrote:
This is a clean up attempt. Passes tests.
Excellent! I applied tewk's patch and Patrick R's comments, then pulled more comments out of the thread and cleaned up the code a bit (reusing the new macros where relevant). What I ultimately ended up with (based on which idioms were repeated and so most in need of macros) is somewhere between tewk's patch and Patrick R's patch.
(chromatic and I have been talking about holding a "file of the week" cleanup task. This is a great start on the first one.)
Allison
