On 5/8/07, Mark Glines via RT <[EMAIL PROTECTED]> wrote:
On Sat May 05 09:37:44 2007, particle wrote: > On 5/4/07, via RT Mark Glines <parrotbug-followup <!-- x --> at parrotcode.org> wrote: > > * Standardize on PARROT_*_GUARD style names for these lines (some > > headers used a style that looks like "__PIRLEXER_H" instead) > > > there's a problem here... compilers/imcc/pirlexer.h is a *generated* > header file. yeah, I patched compilers/pirc/src/pirlexer.h, not compilers/imcc/pirlexer.h. In fact, I'm having difficulty finding a compilers/imcc/pirlexer.h file, even after a fresh build, so I'm confused. Mark mmmm, it might be a good idea to think about pirc vs imcc and their header
files. I'm not sure whether IMCC uses the name "pir" somewhere, if it does, the header guards may clash (especially if some renaming is done, dunno if that 'll happen). (and yes, compilers/pirc is all hand-written, so no generated files and thus there should be no problem with header guards there). regards, klaasjan
