# New Ticket Created by James Keenan # Please include the string: [perl #44125] # in the subject line of all future correspondence about this issue. # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=44125 >
In Configure.pl, some function/method calls take $args as an argument. Other functions, for legacy reasons, take %args or $args {somekey} as an argument. But %args is merely %$args. Let's make this internally consistent. The patch attached eliminates %args in favor of $args. You should observe no change in functionality. I'll apply this patch in a couple of days unless someone objects or beats me to it. kid51
Index: Configure.pl =================================================================== --- Configure.pl (revision 20150) +++ Configure.pl (working copy) @@ -324,7 +324,6 @@ svnid => '$Id$', } ); exit(1) unless defined $args; -my %args = %{$args}; my $opttest = Parrot::Configure::Options::Test->new($args); # configuration tests will only be run if you requested them @@ -332,7 +331,7 @@ $opttest->run_configure_tests(); # from Parrot::Configure::Messages -print_introduction($parrot_version) unless exists $args{step}; +print_introduction($parrot_version) unless exists $args->{step}; my $conf = Parrot::Configure->new; @@ -340,15 +339,15 @@ $conf->add_steps(get_steps_list()); # from Parrot::Configure::Data -$conf->options->set(%args); +$conf->options->set(%{$args}); -if ( exists $args{step} ) { +if ( exists $args->{step} ) { # from Parrot::Configure::Data $conf->data()->slurp(); $conf->data()->slurp_temp() - if $args{step} =~ /gen::makefiles/; + if $args->{step} =~ /gen::makefiles/; # from Parrot::Configure - $conf->runstep( $args{step} ); + $conf->runstep( $args->{step} ); print "\n"; } else { @@ -362,8 +361,7 @@ $opttest->run_build_tests(); # from Parrot::Configure::Messages -print_conclusion($conf->data->get('make')) unless exists $args{step}; - +print_conclusion($conf->data->get('make')) unless exists $args->{step}; exit(0); ################### DOCUMENTATION ###################