On 22/08/07, Steve Peters <[EMAIL PROTECTED]> wrote:
> On Wed, Aug 22, 2007 at 04:11:38PM +0200, Paul Cochrane wrote:
> > > --- src/encoding.c.old Wed Aug 22 08:15:22 2007
> > > +++ src/encoding.c Wed Aug 22 08:15:58 2007
> > > @@ -105,6 +105,7 @@
> > > {
> > > UNUSED(encodingname);
> > > real_exception(interp, NULL, UNIMPLEMENTED, "Can't load encodings
> > > yet");
> > > + return NULL;
> > > }
> > >
> > > /*
> > > --- src/interpreter.c.old Wed Aug 22 08:16:48 2007
> > > +++ src/interpreter.c Wed Aug 22 08:17:39 2007
> > > @@ -692,6 +692,7 @@
> > > PIO_eprintf(interp,
> > > "Computed goto unavailable in this configuration.\n");
> > > Parrot_exit(interp, 1);
> > > + return pc;
> > > #endif
> > > }
> > >
> >
> > I don't know if these two changes bring anything. Neither function
> > actually returns even though there is a return value expected, so the
> > added code is actually dead code as it will never get executed. The
> > function real_exception() doesn't return, and we should be able to
> > tell the compiler that (this is what Andy Lester has been doing a lot
> > of with his recent function attribute work). I'm guessing that suncc
> > throws a warning here can be rectified in the fullness of time.
> >
> > Just my $0.02
> >
> > Paul
>
> We can leave it out, but then we'll never be able to compile Parrot with
> Solaris CC.
That's weird as I had suncc compiling Parrot recently...
