Is it ok to revert r22361 now (where chromatic removed the linelength test from the set of default run tests)?
kjs On Oct 31, 2007 10:55 AM, Klaas-Jan Stol <[EMAIL PROTECTED]> wrote: > > On Oct 31, 2007 10:08 AM, Paul Cochrane <[EMAIL PROTECTED]> wrote: > > > > On 31/10/2007, Klaas-Jan Stol <[EMAIL PROTECTED]> wrote: > > > On Oct 31, 2007 4:35 AM, chromatic <[EMAIL PROTECTED]> wrote: > > > > On Tuesday 30 October 2007 19:27:52 James Keenan wrote: > > > > > > > > > As has been the case lately, a couple of 'pirc'-related files have > > > > > been failing metadata and coding standards tests. Here's results > > > > > from make test on Linux tonight (approx rev 22628). > > > > > > > > > > t/distro/file_metadata.......................# Collecting svn:mime- > > > > > type attributes... > > > > > # Collecting svn:keywords attributes... > > > > > # Collecting svn:eol-style attributes... > > > > > > > > > > # Failed test (t/distro/file_metadata.t at line 147) > > > > > # got: 'Set svn:eol-style with: > > > > > # svn ps svn:eol-style 'native' compilers/pirc/macro/macrolexer.c; > > > > > # ' > > > > > # expected: '' > > > > > # Collecting svn:eol-style attributes... > > > > > # Looks like you failed 1 test of 4. > > > > > dubious > > > > > Test returned status 1 (wstat 256, 0x100) > > > > > DIED. FAILED test 3 > > > > > Failed 1/4 tests, 75.00% okay > > > > > > > > If you or anyone else see failures like this, feel free to run that > > > > command > > > > and check in the modified files. That's a quick and easy fix, and it > > > > should > > > > have no bearing on tests of functional behavior. Fixed in r22630. > > > > > > > > > t/codingstd/linelength....................... > > > > > # Failed test (t/codingstd/linelength.t at line 82) > > > > > # Lines longer than coding standard limit (100 columns) in 2 files: > > > > > # /home/jimk/work/backtrace/compilers/pirc/macro/macrolexer.c:2179: > > > > > 109 cols > > > > > # /home/jimk/work/backtrace/compilers/pirc/macro/macroparser.c:759: > > > > > 102 cols > > > > > # Looks like you failed 1 test of 1. > > > > > dubious > > > > > Test returned status 1 (wstat 256, 0x100) > > > > > DIED. FAILED test 1 > > > > > Failed 1/1 tests, 0.00% okay > > > > > > > > This test should be TODO, or not run by default. It's been a broken > > > > window > > > > for several days, and whoever made it run by default hasn't fixed it. > > > > Removed from the default test run in r22631. > > > > > > > > -- c > > > > > > > I'm the one to blame here. The macro parser/lexer is implemented using > > > bison/flex, meaning that the C files are generated. I had a look at > > > which lines failed, and both are generated. > > > I added all files of compilers/pirc/macro to the list of exemptions in > > > lib/parrot/Distribution.pm, but somehow that doesn't work, apparently. > > > > > > I'd like to have it fixed, but I don't know how I can help at this > > > point, except removing the files. > > > > kjs: I just realised that the linelength test organises its exemptions > > differently to the rest of the coding standards tests. The exemptions > > are listed at the end of the file. Sorry! I could/should have told > > you that last night.... If you add the relevant files to the __DATA__ > > section in t/codinstd/linelength.t then everything should be sorted. > > > > Paul > > i've added them, should be fixed now. Thanks for the pointer! > > kjs > > > >
