On Thu Nov 01 23:50:36 2007, magnachef wrote: > I have, IMO, finished this TODO. I am not sure who is responsible for > commiting this to the repository. > > I have included the diff below: > > [EMAIL PROTECTED] build]$ diff -U0 c2str.pl c2str.pl.escaped > --- c2str.pl 2007-10-30 23:43:57.000000000 -0400 > +++ c2str.pl.escaped 2007-11-02 02:43:35.000000000 -0400 > @@ -138 +138 @@ > - # TODO maybe cope with escaped \" > + # Find the number of quotes (ignoring escaped quotes) > @@ -139,0 +140,2 @@ > + $cnt -= scalar (() = $_ =~ /(\\")/g); > + > > -Dan >
Applied in r22713. Suggestions for your next patch: 1. Create the patch from the point of the top directory in your Parrot working directory rather than the directory where the file to be patched is located. In this case, the resulting patch would have started '-- tools/build/c2str.pl' and would have been easier to apply with the 'patch' program. 2. Send the actual patch in an attachment to your submission to RT (whether you submit via list or via GUI) rather than directly including it in the text. This will enable any reviewer to click on the 'save attachment' link and get your patch to the correct location on their disk for review. Thanks for your first patch! magnachef++ kid51
