# New Ticket Created by Andy Dougherty
# Please include the string: [perl #47606]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=47606 >
The following patch corrects the TODO message to more accurately reflect
the actual problem with this test, and adds comments to the specific
offending lines. All refer to the same RT ticket.
My actual preference is to just delete the test, since its premise (that
there is a warning flag accepted by all compilers) is simply false.
diff -r -u parrot-current/t/configure/115-auto_warnings.t
parrot-cc/t/configure/115-auto_warnings.t
--- parrot-current/t/configure/115-auto_warnings.t Sat Nov 17 03:15:10 2007
+++ parrot-andy/t/configure/115-auto_warnings.t Mon Nov 19 12:18:22 2007
@@ -24,17 +24,16 @@
my $step = 'dummy';
my $conf = Parrot::Configure->new;
-$conf->data->set('cc', 'cc');
-$conf->data->set('ccflags', '-I/usr/include');
+$conf->data->set('cc', 'cc'); # XXX Can't assume there's a compiler 'cc'
+$conf->data->set('ccflags', '-I/usr/include'); # XXX Can't assume this.
my $cwd = cwd();
my $warning;
TODO: {
# http://rt.perl.org/rt3/Ticket/Display.html?id=47395
- local $TODO =
- q<Reported failing where vendor-supplied Perl 5 Config.pm does not
match true state of system available for Parrot configuration>;
- $warning = "-Wall";
+ local $TODO = q<Not all compilers support -Wall>;
+ $warning = "-Wall"; # XXX Can't assume all compilers accept -Wall.
{
my $verbose = 0;
my $rv = auto::warnings::try_warning($step, $conf, $warning);
--
Andy Dougherty [EMAIL PROTECTED]
