On Wed Feb 13 19:21:59 2008, coke wrote: > From PDD07: > > PIR source files should end with this coda: > > # Local Variables: > # mode: pir > # fill-column: 100 > # End: > # vim: expandtab shiftwidth=4: > > > However, there are files that are now checked that weren't before[1] > that have a slightly different version: > > # Local Variables: > # mode: pir > # fill-column: 100 > # End: > # vim: expandtab shiftwidth=4 ft=pir: > > Note the added 'ft' directive. > > We need to choose one of: > > 1) ruthlessly eliminate this upstart coda[2] > 2) update all other PIR codas, the test, and the PDD to match this new > style (take that, Eurasia...) > 3) Make the test a little more lenient.
I'm voting for 3; If someone could just verify my understanding that we should only be specifying ft=pir when the file extension is not '.pir', I think we have a dual coda for PIR (identical except for the ft=pir specification on .t files). Feedback? > Once the test passes again, we can add it back to the list of > codingstd tests that are automatically run in > 'lib/Parrot/Harness/DefaultTests.pm' > > [1] we are now checking all .t files that claim to be PIR as well; > before it was just .pir > [2] 25084 petdance # vim: expandtab shiftwidth=4 ft=pir: >
